You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/29 15:26:59 UTC
[GitHub] [pulsar] heesung-sn opened a new pull request, #15394: [PIP-156][fix][ci] fixed KinesisSinkTest record format error by deaggregation
heesung-sn opened a new pull request, #15394:
URL: https://github.com/apache/pulsar/pull/15394
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
Master Issue: #15207
### Motivation
- As per the [Java build 17 upgrade work](https://github.com/apache/pulsar/pull/15264/files/c17f0bfdfbdb969a06771433d0a6da2a9596860d#r858924350), KinesisSink's default aggregation is exposed in the KinesisSinkTester. We need to cover this record aggregation behavior in the test.
### Modifications
- Updated the KinesisSinkTester to deaggregate response records, if aggregated.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
This change is already covered by existing tests, such as *PulsarSinksTest#testKinesis*.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API: (yes / **no**)
- The schema: (yes / **no** / don't know)
- The default values of configurations: (yes / **no**)
- The wire protocol: (yes / **no**)
- The rest endpoints: (yes / **no**)
- The admin cli options: (yes / **no**)
- Anything that affects deployment: (yes / **no** / don't know)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `no-need-doc`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-added`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #15394: [PIP-156][fix][ci] fixed KinesisSinkTest record format error by deaggregation
Posted by GitBox <gi...@apache.org>.
merlimat merged PR #15394:
URL: https://github.com/apache/pulsar/pull/15394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org