You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/07/14 10:30:16 UTC
[GitHub] [ozone] sodonnel opened a new pull request #2414: HDDS-5174. EC: Allow EC blocks to be requests from OM
sodonnel opened a new pull request #2414:
URL: https://github.com/apache/ozone/pull/2414
## What changes were proposed in this pull request?
Allow EC block requests to propagate from OM to SCM, as currently only STANDALONE and RATIS are supported.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5174
## How was this patch tested?
Existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] umamaheswararao merged pull request #2414: HDDS-5174. EC: Allow EC blocks to be requested from OM
Posted by GitBox <gi...@apache.org>.
umamaheswararao merged pull request #2414:
URL: https://github.com/apache/ozone/pull/2414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sodonnel commented on a change in pull request #2414: HDDS-5174. EC: Allow EC blocks to be requested from OM
Posted by GitBox <gi...@apache.org>.
sodonnel commented on a change in pull request #2414:
URL: https://github.com/apache/ozone/pull/2414#discussion_r678077663
##########
File path: hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/protocolPB/ScmBlockLocationProtocolClientSideTranslatorPB.java
##########
@@ -170,6 +171,9 @@ private SCMBlockLocationResponse handleError(SCMBlockLocationResponse resp)
requestBuilder.setFactor(
((RatisReplicationConfig) replicationConfig).getReplicationFactor());
break;
+ case EC:
+ requestBuilder.setEcReplicationConfig(
+ ((ECReplicationConfig)replicationConfig).toProto());
Review comment:
Ah. Well spotted. I will create a small patch today to fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] umamaheswararao commented on a change in pull request #2414: HDDS-5174. EC: Allow EC blocks to be requested from OM
Posted by GitBox <gi...@apache.org>.
umamaheswararao commented on a change in pull request #2414:
URL: https://github.com/apache/ozone/pull/2414#discussion_r678070683
##########
File path: hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/protocolPB/ScmBlockLocationProtocolClientSideTranslatorPB.java
##########
@@ -170,6 +171,9 @@ private SCMBlockLocationResponse handleError(SCMBlockLocationResponse resp)
requestBuilder.setFactor(
((RatisReplicationConfig) replicationConfig).getReplicationFactor());
break;
+ case EC:
+ requestBuilder.setEcReplicationConfig(
+ ((ECReplicationConfig)replicationConfig).toProto());
Review comment:
Since this is merged, Let's handle in next patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] umamaheswararao commented on a change in pull request #2414: HDDS-5174. EC: Allow EC blocks to be requested from OM
Posted by GitBox <gi...@apache.org>.
umamaheswararao commented on a change in pull request #2414:
URL: https://github.com/apache/ozone/pull/2414#discussion_r678070028
##########
File path: hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/protocolPB/ScmBlockLocationProtocolClientSideTranslatorPB.java
##########
@@ -170,6 +171,9 @@ private SCMBlockLocationResponse handleError(SCMBlockLocationResponse resp)
requestBuilder.setFactor(
((RatisReplicationConfig) replicationConfig).getReplicationFactor());
break;
+ case EC:
+ requestBuilder.setEcReplicationConfig(
+ ((ECReplicationConfig)replicationConfig).toProto());
Review comment:
Looks like we missed break here. Sorry missed this in previous review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org