You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/07/13 20:05:36 UTC

[kudu-CR] KUDU-2671 range-specific hash schemas enabled by default

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18727


Change subject: KUDU-2671 range-specific hash schemas enabled by default
......................................................................

KUDU-2671 range-specific hash schemas enabled by default

This patch sets the default value for --enable_per_range_hash_schemas
to be 'true' by default, enabling the support for range-specific hash
schemas for the server side right out of the box.

Change-Id: Iae6220bfec4089819b292d4f6879c4421e05e444
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartitionPruner.java
M src/kudu/client/client-test.cc
M src/kudu/client/flex_partitioning_client-test.cc
M src/kudu/client/scan_token-test.cc
M src/kudu/integration-tests/table_locations-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
10 files changed, 3 insertions(+), 68 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/18727/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18727
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae6220bfec4089819b292d4f6879c4421e05e444
Gerrit-Change-Number: 18727
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] KUDU-2671 range-specific hash schemas enabled by default

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18727 )

Change subject: KUDU-2671 range-specific hash schemas enabled by default
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18727
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae6220bfec4089819b292d4f6879c4421e05e444
Gerrit-Change-Number: 18727
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 14 Jul 2022 01:21:09 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2671 range-specific hash schemas enabled by default

Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18727 )

Change subject: KUDU-2671 range-specific hash schemas enabled by default
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18727
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae6220bfec4089819b292d4f6879c4421e05e444
Gerrit-Change-Number: 18727
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Wed, 13 Jul 2022 21:07:45 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2671 range-specific hash schemas enabled by default

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18727 )

Change subject: KUDU-2671 range-specific hash schemas enabled by default
......................................................................

KUDU-2671 range-specific hash schemas enabled by default

This patch sets the default value for --enable_per_range_hash_schemas
to be 'true' by default, enabling the support for range-specific hash
schemas for the server side right out of the box.

Change-Id: Iae6220bfec4089819b292d4f6879c4421e05e444
Reviewed-on: http://gerrit.cloudera.org:8080/18727
Tested-by: Kudu Jenkins
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Reviewed-by: Yingchun Lai <ac...@gmail.com>
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartitionPruner.java
M src/kudu/client/client-test.cc
M src/kudu/client/flex_partitioning_client-test.cc
M src/kudu/client/scan_token-test.cc
M src/kudu/integration-tests/table_locations-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
10 files changed, 3 insertions(+), 68 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Mahesh Reddy: Looks good to me, but someone else must approve
  Yingchun Lai: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18727
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae6220bfec4089819b292d4f6879c4421e05e444
Gerrit-Change-Number: 18727
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>