You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/08 02:59:13 UTC
[GitHub] [apisix-dashboard] iamayushdas opened a new pull request #1863: chore: refactored test create-route-with-cors-form.spec.js
iamayushdas opened a new pull request #1863:
URL: https://github.com/apache/apisix-dashboard/pull/1863
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
- [x] Refactor
**What changes will this PR take into?**
Refactor Testcase for Frontend.
**Related issues**
related issue #1774
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [x] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1863: chore: refactored test create-route-with-cors-form.spec.js
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1863:
URL: https://github.com/apache/apisix-dashboard/pull/1863#issuecomment-835006143
Deploy preview for *apisix-dashboard* ready!
Built with commit 1512d2634ace959df0c829b7597dadeb7561a57a
https://deploy-preview-1863--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun merged pull request #1863: chore: refactored test create-route-with-cors-form.spec.js
Posted by GitBox <gi...@apache.org>.
LiteSun merged pull request #1863:
URL: https://github.com/apache/apisix-dashboard/pull/1863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1863: chore: refactored test create-route-with-cors-form.spec.js
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1863:
URL: https://github.com/apache/apisix-dashboard/pull/1863#issuecomment-839930443
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1863?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1863](https://codecov.io/gh/apache/apisix-dashboard/pull/1863?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7e92ae1) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c86017010927f1f387c4e844a18e5904bacc856b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c860170) will **increase** coverage by `1.25%`.
> The diff coverage is `53.84%`.
> :exclamation: Current head 7e92ae1 differs from pull request most recent head 1512d26. Consider uploading reports for the commit 1512d26 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1863/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/1863?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1863 +/- ##
==========================================
+ Coverage 68.85% 70.10% +1.25%
==========================================
Files 122 48 -74
Lines 3111 3258 +147
Branches 745 0 -745
==========================================
+ Hits 2142 2284 +142
+ Misses 969 717 -252
- Partials 0 257 +257
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `45.82% <46.15%> (?)` | |
| backend-e2e-test-ginkgo | `48.28% <34.61%> (?)` | |
| backend-unit-test | `52.47% <66.66%> (?)` | |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1863?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1863/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `78.77% <0.00%> (ø)` | |
| [api/internal/utils/pid.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1863/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3BpZC5nbw==) | `26.66% <ø> (ø)` | |
| [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1863/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `45.92% <52.17%> (ø)` | |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1863/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `88.02% <100.00%> (ø)` | |
| [web/src/pages/SSL/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1863/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvc2VydmljZS50cw==) | | |
| [web/src/pages/SSL/components/Step1/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1863/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvY29tcG9uZW50cy9TdGVwMS9pbmRleC50c3g=) | | |
| [web/src/components/Upstream/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1863/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL3NlcnZpY2UudHM=) | | |
| [...eb/src/components/Upstream/components/TimeUnit.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1863/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVGltZVVuaXQudHN4) | | |
| [...eam/components/active-check/Unhealthy/Interval.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1863/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL1VuaGVhbHRoeS9JbnRlcnZhbC50c3g=) | | |
| [...mponents/Upstream/components/active-check/Host.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1863/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hvc3QudHN4) | | |
| ... and [150 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1863/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1863?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1863?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c860170...1512d26](https://codecov.io/gh/apache/apisix-dashboard/pull/1863?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1863: chore: refactored test create-route-with-cors-form.spec.js
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1863:
URL: https://github.com/apache/apisix-dashboard/pull/1863#issuecomment-839930443
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1863?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1863](https://codecov.io/gh/apache/apisix-dashboard/pull/1863?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1512d26) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c86017010927f1f387c4e844a18e5904bacc856b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c860170) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1863/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/1863?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1863 +/- ##
==========================================
+ Coverage 68.85% 68.91% +0.06%
==========================================
Files 122 122
Lines 3111 3111
Branches 745 745
==========================================
+ Hits 2142 2144 +2
+ Misses 969 967 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| frontend-e2e-test | `68.91% <ø> (+0.06%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1863?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1863/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `72.13% <0.00%> (+3.27%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1863?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1863?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c860170...1512d26](https://codecov.io/gh/apache/apisix-dashboard/pull/1863?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1863: chore: refactored test create-route-with-cors-form.spec.js
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1863:
URL: https://github.com/apache/apisix-dashboard/pull/1863#issuecomment-835006143
Deploy preview for *apisix-dashboard* processing.
Building with commit 1512d2634ace959df0c829b7597dadeb7561a57a
https://app.netlify.com/sites/apisix-dashboard/deploys/609c02063c48a1000707ab6e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1863: chore: refactored test create-route-with-cors-form.spec.js
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1863:
URL: https://github.com/apache/apisix-dashboard/pull/1863#issuecomment-839986567
> You can see them here:
>
> ![image](https://user-images.githubusercontent.com/72343596/118002482-3b777a80-b37a-11eb-9177-601a30b474c0.png)
>
>
Ohh i guess its due to the recent commit from plugin orchestration, i have fixed the conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1863: chore: refactored test create-route-with-cors-form.spec.js
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #1863:
URL: https://github.com/apache/apisix-dashboard/pull/1863#issuecomment-839869238
You can see them here:
![image](https://user-images.githubusercontent.com/72343596/118002482-3b777a80-b37a-11eb-9177-601a30b474c0.png)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun merged pull request #1863: chore: refactored test create-route-with-cors-form.spec.js
Posted by GitBox <gi...@apache.org>.
LiteSun merged pull request #1863:
URL: https://github.com/apache/apisix-dashboard/pull/1863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1863: chore: refactored test create-route-with-cors-form.spec.js
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1863:
URL: https://github.com/apache/apisix-dashboard/pull/1863#issuecomment-835006143
Deploy preview for *apisix-dashboard* processing.
Building with commit 21b1c5696723645eccd90a15d0bb5ab9ca6d7955
https://app.netlify.com/sites/apisix-dashboard/deploys/6095fe73c3ab8400088a1d55
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas closed pull request #1863: chore: refactored test create-route-with-cors-form.spec.js
Posted by GitBox <gi...@apache.org>.
iamayushdas closed pull request #1863:
URL: https://github.com/apache/apisix-dashboard/pull/1863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1863: chore: refactored test create-route-with-cors-form.spec.js
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1863:
URL: https://github.com/apache/apisix-dashboard/pull/1863#issuecomment-835006143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1863: chore: refactored test create-route-with-cors-form.spec.js
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #1863:
URL: https://github.com/apache/apisix-dashboard/pull/1863#issuecomment-839864936
There are some conflicts to be resolved here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1863: chore: refactored test create-route-with-cors-form.spec.js
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1863:
URL: https://github.com/apache/apisix-dashboard/pull/1863#issuecomment-835006143
Deploy preview for *apisix-dashboard* processing.
Building with commit 7e92ae172e98bc1f1db012b9621d4b01a759dfdd
https://app.netlify.com/sites/apisix-dashboard/deploys/609bfd4f9f0d320007dd5004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1863: chore: refactored test create-route-with-cors-form.spec.js
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1863:
URL: https://github.com/apache/apisix-dashboard/pull/1863#issuecomment-835006143
Deploy preview for *apisix-dashboard* ready!
Built with commit 21b1c5696723645eccd90a15d0bb5ab9ca6d7955
https://deploy-preview-1863--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1863: chore: refactored test create-route-with-cors-form.spec.js
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1863:
URL: https://github.com/apache/apisix-dashboard/pull/1863#issuecomment-839866962
> There are some conflicts to be resolved here
What are they?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1863: chore: refactored test create-route-with-cors-form.spec.js
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1863:
URL: https://github.com/apache/apisix-dashboard/pull/1863#issuecomment-835006143
Deploy preview for *apisix-dashboard* ready!
Built with commit 21b1c5696723645eccd90a15d0bb5ab9ca6d7955
https://deploy-preview-1863--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org