You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2016/02/26 08:01:46 UTC
Review Request 44059: Close icons on modal top right do not honor the
underlying logic associated with the close/cancel buttons
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44059/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Jaimin Jetly, and Nitiraj Rathore.
Bugs: AMBARI-15198
https://issues.apache.org/jira/browse/AMBARI-15198
Repository: ambari
Description
-------
- Removed data-dismiss attribute and added action 'close' so that it should be able to do all the task for modal close under the hood.
- Removed unused services for copy and move feature.
Diffs
-----
contrib/views/files/src/main/resources/ui/app/services/file-copy.js 7193177
contrib/views/files/src/main/resources/ui/app/services/file-move.js 859f04c
contrib/views/files/src/main/resources/ui/app/templates/components/copy-modal.hbs 3e561e5
contrib/views/files/src/main/resources/ui/app/templates/components/delete-modal.hbs 207a2a8
contrib/views/files/src/main/resources/ui/app/templates/components/move-modal.hbs 1655930
contrib/views/files/src/main/resources/ui/app/templates/components/new-directory.hbs bc21f31
contrib/views/files/src/main/resources/ui/app/templates/components/open-preview-modal.hbs 98a5459
contrib/views/files/src/main/resources/ui/app/templates/components/permission-modal.hbs e6dee66
contrib/views/files/src/main/resources/ui/app/templates/components/rename-modal.hbs 8b1fca7
contrib/views/files/src/main/resources/ui/app/templates/components/upload-file.hbs c1352dd
Diff: https://reviews.apache.org/r/44059/diff/
Testing
-------
Manual testing done.
Thanks,
Pallav Kulshreshtha
Re: Review Request 44059: Close icons on modal top right do not honor
the underlying logic associated with the close/cancel buttons
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44059/#review120844
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Feb. 26, 2016, 7:01 a.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44059/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 7:01 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Jaimin Jetly, and Nitiraj Rathore.
>
>
> Bugs: AMBARI-15198
> https://issues.apache.org/jira/browse/AMBARI-15198
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Removed data-dismiss attribute and added action 'close' so that it should be able to do all the task for modal close under the hood.
> - Removed unused services for copy and move feature.
>
>
> Diffs
> -----
>
> contrib/views/files/src/main/resources/ui/app/services/file-copy.js 7193177
> contrib/views/files/src/main/resources/ui/app/services/file-move.js 859f04c
> contrib/views/files/src/main/resources/ui/app/templates/components/copy-modal.hbs 3e561e5
> contrib/views/files/src/main/resources/ui/app/templates/components/delete-modal.hbs 207a2a8
> contrib/views/files/src/main/resources/ui/app/templates/components/move-modal.hbs 1655930
> contrib/views/files/src/main/resources/ui/app/templates/components/new-directory.hbs bc21f31
> contrib/views/files/src/main/resources/ui/app/templates/components/open-preview-modal.hbs 98a5459
> contrib/views/files/src/main/resources/ui/app/templates/components/permission-modal.hbs e6dee66
> contrib/views/files/src/main/resources/ui/app/templates/components/rename-modal.hbs 8b1fca7
> contrib/views/files/src/main/resources/ui/app/templates/components/upload-file.hbs c1352dd
>
> Diff: https://reviews.apache.org/r/44059/diff/
>
>
> Testing
> -------
>
> Manual testing done.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>