You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2023/01/08 18:05:03 UTC
[GitHub] [iceberg] rdblue commented on a diff in pull request #6525: Python: Refactor loading manifests
rdblue commented on code in PR #6525:
URL: https://github.com/apache/iceberg/pull/6525#discussion_r1064181627
##########
python/pyiceberg/avro/file.py:
##########
@@ -93,49 +96,52 @@ def get_schema(self) -> Schema:
raise ValueError("No schema found in Avro file headers")
+F = TypeVar("F", bound=StructProtocol)
Review Comment:
What does `F` represent? I'd expect something like `T` (type) or `R` (record?). Avro itself uses `D` for datum, which may be a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org