You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/05 08:04:48 UTC
[GitHub] [arrow-ballista] nl5887 opened a new pull request, #58: Add ballista python module
nl5887 opened a new pull request, #58:
URL: https://github.com/apache/arrow-ballista/pull/58
# Rationale for this change
This will introduce the ballista python module, similar to the datafusion python module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove commented on pull request #58: Add ballista python module
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #58:
URL: https://github.com/apache/arrow-ballista/pull/58#issuecomment-1152678478
Hi @Jimexist. Now that we have restored the original DataFusion Python bindings in this repo, would you be willing to create a PR here to submit the improvements that you have made in the datafusion-contrib repo? That will reduce the size of this PR further. We need to be careful not to include changes from contributors that have not yet signed an ICLA but as far as I can see there are just two such commits and they could easily be excluded. If you don't have time to do this would you be ok with me creating the PR with your changes? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove commented on pull request #58: Add ballista python module
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #58:
URL: https://github.com/apache/arrow-ballista/pull/58#issuecomment-1160585878
Hi @Jimexist just in case you missed the previous message. Let me know what your thoughts are,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] nl5887 commented on pull request #58: Add ballista python module
Posted by GitBox <gi...@apache.org>.
nl5887 commented on PR #58:
URL: https://github.com/apache/arrow-ballista/pull/58#issuecomment-1150239659
@andygrove rebased this PR on top of #61. The conflicts shows how datafusion-contrib and this python converged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] thinkharderdev commented on pull request #58: Add ballista python module
Posted by GitBox <gi...@apache.org>.
thinkharderdev commented on PR #58:
URL: https://github.com/apache/arrow-ballista/pull/58#issuecomment-1147736586
Nice! This is a great contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove commented on pull request #58: Add ballista python module
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #58:
URL: https://github.com/apache/arrow-ballista/pull/58#issuecomment-1150132443
@nl5887 Now that https://github.com/apache/arrow-ballista/pull/61 is merged, could you rebase this PR on top of that, with the code going into the `python` directory rather than `ballista-python`. This will allow us to see the specific changes that are being contributed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove commented on pull request #58: Add ballista python module
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #58:
URL: https://github.com/apache/arrow-ballista/pull/58#issuecomment-1228546606
It's been just over a month without activity so I will close this in favor of https://github.com/apache/arrow-ballista/pull/157
Thanks for the help with this @nl5887 - I used the ballista context code from this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] Jimexist commented on a diff in pull request #58: Add ballista python module
Posted by GitBox <gi...@apache.org>.
Jimexist commented on code in PR #58:
URL: https://github.com/apache/arrow-ballista/pull/58#discussion_r890722358
##########
.github/workflows/ballista-python.build.yml:
##########
@@ -0,0 +1,127 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Python Release Build
+on:
+ push:
+ tags:
+ - "*-rc*"
+
+jobs:
+ generate-license:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+ - uses: actions-rs/toolchain@v1
+ with:
+ profile: minimal
+ toolchain: stable
+ override: true
+ - name: Generate license file
+ run: python ./dev/create_license.py
+ - uses: actions/upload-artifact@v2
+ with:
+ name: python-wheel-license
+ path: LICENSE.txt
+
+ build-python-mac-win:
+ needs: [generate-license]
+ name: Mac/Win
+ runs-on: ${{ matrix.os }}
+ strategy:
+ fail-fast: false
+ matrix:
+ python-version: ["3.10"]
+ os: [macos-latest, windows-latest]
+ steps:
+ - uses: actions/checkout@v2
+
+ - uses: actions/setup-python@v2
+ with:
+ python-version: ${{ matrix.python-version }}
+
+ - uses: actions-rs/toolchain@v1
+ with:
+ toolchain: stable
+
+ - name: Install dependencies
+ run: |
+ python -m pip install --upgrade pip
+ pip install maturin==0.12.16
+
+ - run: rm LICENSE.txt
+ - name: Download LICENSE.txt
+ uses: actions/download-artifact@v2
+ with:
+ name: python-wheel-license
+ path: .
+
+ - name: Build Python package
+ run: maturin build --release --strip --cargo-extra-args="--locked"
+
+ - name: List Windows wheels
+ if: matrix.os == 'windows-latest'
+ run: dir target\wheels\
+
+ - name: List Mac wheels
+ if: matrix.os != 'windows-latest'
+ run: find target/wheels/
+
+ - name: Archive wheels
+ uses: actions/upload-artifact@v2
+ with:
+ name: dist
+ path: target/wheels/*
+
+ build-manylinux:
+ needs: [generate-license]
+ name: Manylinux
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+ - run: rm LICENSE.txt
+ - name: Download LICENSE.txt
+ uses: actions/download-artifact@v2
+ with:
+ name: python-wheel-license
+ path: .
+ - run: cat LICENSE.txt
+ - name: Build wheels
+ run: |
+ export RUSTFLAGS='-C target-cpu=skylake'
+ docker run --rm -v $(pwd):/io \
+ --workdir /io \
+ konstin2/maturin:v0.12.16 \
Review Comment:
this won't work - it has only 0.12.10 pushed to dockerhub
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove commented on pull request #58: Add ballista python module
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #58:
URL: https://github.com/apache/arrow-ballista/pull/58#issuecomment-1146800436
Thank you for the contribution @nl5887. Having a Python repl as part of Ballista will make it much more accessible.
Because this builds on the `datafusion-python` module which was originally part of DataFusion but is now part of the `datafusion-contrib` GitHub org (outside of Apache Arrow governance) I need to figure out what the IP clearance situation is for this contribution.
One option may be for us to restore the original `datafusion-python` code here from before it was removed from this repo and then rebase your PR so it just has the additions on top of that. Another option will be for us to treat it like a regular donation which will require getting all contributors to sign an ICLA (or remove their contributions from the donation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove commented on pull request #58: Add ballista python module
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #58:
URL: https://github.com/apache/arrow-ballista/pull/58#issuecomment-1146815286
@thinkharderdev @yahoNanJing @realno @Ted-Jiang fyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove commented on pull request #58: Add ballista python module
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #58:
URL: https://github.com/apache/arrow-ballista/pull/58#issuecomment-1191258482
Hi @nl5887 Sorry for the delay on this but there have been discussions on the mailing list about this and it turns out that we can just go ahead and PR these changes after all. Would you mind rebasing this PR and I can go ahead and review. Thanks for your patience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove closed pull request #58: Add ballista python module
Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #58: Add ballista python module
URL: https://github.com/apache/arrow-ballista/pull/58
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org