[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6134: Adding a flag `-healthCheckServices` in PinotServiceManager to allow health check includes internal components

[GitBox <gi...@apache.org>]

jackjlli commented on a change in pull request #6134:
URL: https://github.com/apache/incubator-pinot/pull/6134#discussion_r519014317



##########
File path: pinot-tools/src/main/java/org/apache/pinot/tools/service/api/resources/PinotServiceManagerHealthCheck.java
##########
@@ -33,18 +35,37 @@
 import javax.ws.rs.core.MediaType;
 import javax.ws.rs.core.Response;
 import org.apache.pinot.common.utils.ServiceStatus;
+import org.apache.pinot.spi.services.ServiceRole;
+import org.apache.pinot.tools.service.PinotServiceManager;
 
 
 @Api(tags = "Health")
 @Path("/")
 public class PinotServiceManagerHealthCheck {
 
+  @Inject
+  private PinotServiceManager _pinotServiceManager;
+
   @GET
   @Produces(MediaType.TEXT_PLAIN)
   @Path("health")
   @ApiOperation(value = "Checking Pinot Service health")
   @ApiResponses(value = {@ApiResponse(code = 200, message = "Pinot Starter is healthy"), @ApiResponse(code = 503, message = "Pinot Starter is not healthy")})
   public String getStarterHealth() {
+    final Set<String> healthCheckServices = _pinotServiceManager.getHealthCheckServices();

Review comment:
       I guess you'd need to call this API somewhere but I don't see it in this PR. Is that the case?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org