You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/01/08 16:56:32 UTC

[GitHub] lebeg opened a new pull request #9349: Link fix

lebeg opened a new pull request #9349: Link fix
URL: https://github.com/apache/incubator-mxnet/pull/9349
 
 
   ## Description ##
   Fixes the C++ unit tests. The operation registrations were not invoked due to symbol stripping by the linker on Mac (clang).
   
   ## Dependencies ##
   
   This change depends on:
   
   - **Fix broken unit test compilation** [#9321](https://github.com/apache/incubator-mxnet/pull/9321) 
   
   ## Checklist ##
   ### Essentials ###
   - [x] Passed code style checking (`make lint`)
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [x] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - Only [this commit](https://github.com/apache/incubator-mxnet/commit/41c9b45e8638ac9df0866445d3cb051ad483d19f) is unique to this pull request

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services