You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Slim Bouguerra <sb...@hortonworks.com> on 2018/11/20 02:03:48 UTC
Review Request 69404: HIVE-20932 adding vectorize wrapper for Druid
Storage Handler.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69404/
-----------------------------------------------------------
Review request for hive, Gopal V and Teddy Choi.
Bugs: HIVE-20932
https://issues.apache.org/jira/browse/HIVE-20932
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-20932
Diffs
-----
checkstyle/checkstyle.xml 12e166311b
data/files/datasets/druid_table_alltypesorc/load.hive.sql 5fde266a01
data/scripts/q_test_cleanup.sql 1c59381aa0
druid-handler/src/java/org/apache/hadoop/hive/druid/DruidKafkaUtils.java e0e29a3c6d
druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandler.java 7434559532
druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandlerUtils.java 6dc97d53b7
druid-handler/src/java/org/apache/hadoop/hive/druid/conf/DruidConstants.java 242f7be4dd
druid-handler/src/java/org/apache/hadoop/hive/druid/conf/package-info.java PRE-CREATION
druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidQueryBasedInputFormat.java c1e0e75f98
druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidRecordWriter.java 65edc665a3
druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidVectorizedWrapper.java PRE-CREATION
druid-handler/src/java/org/apache/hadoop/hive/druid/io/package-info.java PRE-CREATION
druid-handler/src/java/org/apache/hadoop/hive/druid/json/AvroBytesDecoder.java 3a1dbf7229
druid-handler/src/java/org/apache/hadoop/hive/druid/json/AvroParseSpec.java af71f9a732
druid-handler/src/java/org/apache/hadoop/hive/druid/json/AvroStreamInputRowParser.java d6e6624669
druid-handler/src/java/org/apache/hadoop/hive/druid/json/InlineSchemaAvroBytesDecoder.java 72d6cbbc1e
druid-handler/src/java/org/apache/hadoop/hive/druid/json/KafkaSupervisorIOConfig.java c1b3bf8d41
druid-handler/src/java/org/apache/hadoop/hive/druid/json/TaskReportData.java 9ecba1b18c
druid-handler/src/java/org/apache/hadoop/hive/druid/json/package-info.java PRE-CREATION
druid-handler/src/java/org/apache/hadoop/hive/druid/package-info.java PRE-CREATION
druid-handler/src/java/org/apache/hadoop/hive/druid/security/package-info.java PRE-CREATION
druid-handler/src/java/org/apache/hadoop/hive/druid/serde/DruidQueryRecordReader.java 53d74417f8
druid-handler/src/java/org/apache/hadoop/hive/druid/serde/DruidSerDe.java 516faf0814
druid-handler/src/java/org/apache/hadoop/hive/druid/serde/package-info.java PRE-CREATION
druid-handler/src/test/org/apache/hadoop/hive/druid/DerbyConnectorTestUtility.java bf42a74f0f
druid-handler/src/test/org/apache/hadoop/hive/druid/QTestDruidSerDe.java 099e5b3357
druid-handler/src/test/org/apache/hadoop/hive/druid/QTestDruidSerDe2.java f52e721763
druid-handler/src/test/org/apache/hadoop/hive/druid/TestDruidStorageHandler.java 0cb3c237b1
druid-handler/src/test/org/apache/hadoop/hive/druid/TestHiveDruidQueryBasedInputFormat.java 513119ea32
druid-handler/src/test/org/apache/hadoop/hive/druid/io/TestHiveDruidSplit.java 234c783d25
druid-handler/src/test/org/apache/hadoop/hive/druid/io/package-info.java PRE-CREATION
druid-handler/src/test/org/apache/hadoop/hive/druid/package-info.java PRE-CREATION
druid-handler/src/test/org/apache/hadoop/hive/druid/serde/TestDruidSerDe.java e27f8cf0e8
druid-handler/src/test/org/apache/hadoop/hive/druid/serde/package-info.java PRE-CREATION
druid-handler/src/test/org/apache/hadoop/hive/package-info.java PRE-CREATION
druid-handler/src/test/org/apache/hadoop/hive/ql/io/TestDruidRecordWriter.java 63efdc4d8f
druid-handler/src/test/org/apache/hadoop/hive/ql/io/package-info.java PRE-CREATION
ql/src/test/queries/clientpositive/druidkafkamini_basic.q 73593ef0b3
ql/src/test/queries/clientpositive/druidmini_dynamic_partition.q 1b208625e7
ql/src/test/queries/clientpositive/druidmini_expressions.q a39cd13cca
ql/src/test/queries/clientpositive/druidmini_extractTime.q 03afbe24f2
ql/src/test/queries/clientpositive/druidmini_floorTime.q b0dce67b50
ql/src/test/queries/clientpositive/druidmini_joins.q 1f92a0d1f0
ql/src/test/queries/clientpositive/druidmini_test1.q a4031c6ab1
ql/src/test/results/clientpositive/druid/druidkafkamini_basic.q.out 14522fb687
ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out b07ed52d06
ql/src/test/results/clientpositive/druid/druidmini_extractTime.q.out 4ea95f6930
ql/src/test/results/clientpositive/druid/druidmini_floorTime.q.out 8d9382443e
ql/src/test/results/clientpositive/druid/druidmini_test1.q.out 7aa1763161
ql/src/test/results/clientpositive/druid/druidmini_test_ts.q.out 9c412d97dd
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java ef5e5a6cc7
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java 51a0aed16a
storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/ColumnVector.java 01bd2f6e88
storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java f8ed7e29e5
Diff: https://reviews.apache.org/r/69404/diff/1/
Testing
-------
Qfiles tests added.
Thanks,
Slim Bouguerra
Re: Review Request 69404: HIVE-20932 adding vectorize wrapper for
Druid Storage Handler.
Posted by Slim Bouguerra <sb...@hortonworks.com>.
> On Nov. 20, 2018, 7:54 a.m., Nishant Bangarwa wrote:
> > data/files/datasets/druid_table_alltypesorc/load.hive.sql
> > Line 36 (original)
> > <https://reviews.apache.org/r/69404/diff/1/?file=2108896#file2108896line36>
> >
> > why not dropping this table ?
it is dropped later, this will allow us to add tests against the orc table to cross match results when not sure.
> On Nov. 20, 2018, 7:54 a.m., Nishant Bangarwa wrote:
> > druid-handler/src/java/org/apache/hadoop/hive/druid/DruidKafkaUtils.java
> > Line 188 (original), 183 (patched)
> > <https://reviews.apache.org/r/69404/diff/1/?file=2108898#file2108898line188>
> >
> > why this change ?
more java idomatic. In fact it will be better to have an enum ...
- Slim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69404/#review210699
-----------------------------------------------------------
On Nov. 20, 2018, 2:08 a.m., Slim Bouguerra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69404/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2018, 2:08 a.m.)
>
>
> Review request for hive, Gopal V and Teddy Choi.
>
>
> Bugs: HIVE-20932
> https://issues.apache.org/jira/browse/HIVE-20932
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-20932
> Note for reviewing
> most important changes are :
>
> - druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidVectorizedWrapper.java
> - org.apache.hadoop.hive.druid.serde.DruidSerDe#deserializeAsPrimitive
> - org.apache.hadoop.hive.druid.io.DruidQueryBasedInputFormat#getRecordReader
>
>
> Diffs
> -----
>
> checkstyle/checkstyle.xml 12e166311b
> data/files/datasets/druid_table_alltypesorc/load.hive.sql 5fde266a01
> data/scripts/q_test_cleanup.sql 1c59381aa0
> druid-handler/src/java/org/apache/hadoop/hive/druid/DruidKafkaUtils.java e0e29a3c6d
> druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandler.java 7434559532
> druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandlerUtils.java 6dc97d53b7
> druid-handler/src/java/org/apache/hadoop/hive/druid/conf/DruidConstants.java 242f7be4dd
> druid-handler/src/java/org/apache/hadoop/hive/druid/conf/package-info.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidQueryBasedInputFormat.java c1e0e75f98
> druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidRecordWriter.java 65edc665a3
> druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidVectorizedWrapper.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/io/package-info.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/AvroBytesDecoder.java 3a1dbf7229
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/AvroParseSpec.java af71f9a732
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/AvroStreamInputRowParser.java d6e6624669
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/InlineSchemaAvroBytesDecoder.java 72d6cbbc1e
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/KafkaSupervisorIOConfig.java c1b3bf8d41
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/TaskReportData.java 9ecba1b18c
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/package-info.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/package-info.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/security/package-info.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/serde/DruidQueryRecordReader.java 53d74417f8
> druid-handler/src/java/org/apache/hadoop/hive/druid/serde/DruidSerDe.java 516faf0814
> druid-handler/src/java/org/apache/hadoop/hive/druid/serde/package-info.java PRE-CREATION
> druid-handler/src/test/org/apache/hadoop/hive/druid/DerbyConnectorTestUtility.java bf42a74f0f
> druid-handler/src/test/org/apache/hadoop/hive/druid/QTestDruidSerDe.java 099e5b3357
> druid-handler/src/test/org/apache/hadoop/hive/druid/QTestDruidSerDe2.java f52e721763
> druid-handler/src/test/org/apache/hadoop/hive/druid/TestDruidStorageHandler.java 0cb3c237b1
> druid-handler/src/test/org/apache/hadoop/hive/druid/TestHiveDruidQueryBasedInputFormat.java 513119ea32
> druid-handler/src/test/org/apache/hadoop/hive/druid/io/TestHiveDruidSplit.java 234c783d25
> druid-handler/src/test/org/apache/hadoop/hive/druid/io/package-info.java PRE-CREATION
> druid-handler/src/test/org/apache/hadoop/hive/druid/package-info.java PRE-CREATION
> druid-handler/src/test/org/apache/hadoop/hive/druid/serde/TestDruidSerDe.java e27f8cf0e8
> druid-handler/src/test/org/apache/hadoop/hive/druid/serde/package-info.java PRE-CREATION
> druid-handler/src/test/org/apache/hadoop/hive/package-info.java PRE-CREATION
> druid-handler/src/test/org/apache/hadoop/hive/ql/io/TestDruidRecordWriter.java 63efdc4d8f
> druid-handler/src/test/org/apache/hadoop/hive/ql/io/package-info.java PRE-CREATION
> ql/src/test/queries/clientpositive/druidkafkamini_basic.q 73593ef0b3
> ql/src/test/queries/clientpositive/druidmini_dynamic_partition.q 1b208625e7
> ql/src/test/queries/clientpositive/druidmini_expressions.q a39cd13cca
> ql/src/test/queries/clientpositive/druidmini_extractTime.q 03afbe24f2
> ql/src/test/queries/clientpositive/druidmini_floorTime.q b0dce67b50
> ql/src/test/queries/clientpositive/druidmini_joins.q 1f92a0d1f0
> ql/src/test/queries/clientpositive/druidmini_test1.q a4031c6ab1
> ql/src/test/results/clientpositive/druid/druidkafkamini_basic.q.out 14522fb687
> ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out b07ed52d06
> ql/src/test/results/clientpositive/druid/druidmini_extractTime.q.out 4ea95f6930
> ql/src/test/results/clientpositive/druid/druidmini_floorTime.q.out 8d9382443e
> ql/src/test/results/clientpositive/druid/druidmini_test1.q.out 7aa1763161
> ql/src/test/results/clientpositive/druid/druidmini_test_ts.q.out 9c412d97dd
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java ef5e5a6cc7
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java 51a0aed16a
> storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/ColumnVector.java 01bd2f6e88
> storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java f8ed7e29e5
>
>
> Diff: https://reviews.apache.org/r/69404/diff/1/
>
>
> Testing
> -------
>
> Qfiles tests added.
>
>
> Thanks,
>
> Slim Bouguerra
>
>
Re: Review Request 69404: HIVE-20932 adding vectorize wrapper for
Druid Storage Handler.
Posted by Nishant Bangarwa <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69404/#review210699
-----------------------------------------------------------
data/files/datasets/druid_table_alltypesorc/load.hive.sql
Line 36 (original)
<https://reviews.apache.org/r/69404/#comment295434>
why not dropping this table ?
druid-handler/src/java/org/apache/hadoop/hive/druid/DruidKafkaUtils.java
Line 188 (original), 183 (patched)
<https://reviews.apache.org/r/69404/#comment295435>
why this change ?
- Nishant Bangarwa
On Nov. 20, 2018, 2:08 a.m., Slim Bouguerra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69404/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2018, 2:08 a.m.)
>
>
> Review request for hive, Gopal V and Teddy Choi.
>
>
> Bugs: HIVE-20932
> https://issues.apache.org/jira/browse/HIVE-20932
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-20932
> Note for reviewing
> most important changes are :
>
> - druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidVectorizedWrapper.java
> - org.apache.hadoop.hive.druid.serde.DruidSerDe#deserializeAsPrimitive
> - org.apache.hadoop.hive.druid.io.DruidQueryBasedInputFormat#getRecordReader
>
>
> Diffs
> -----
>
> checkstyle/checkstyle.xml 12e166311b
> data/files/datasets/druid_table_alltypesorc/load.hive.sql 5fde266a01
> data/scripts/q_test_cleanup.sql 1c59381aa0
> druid-handler/src/java/org/apache/hadoop/hive/druid/DruidKafkaUtils.java e0e29a3c6d
> druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandler.java 7434559532
> druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandlerUtils.java 6dc97d53b7
> druid-handler/src/java/org/apache/hadoop/hive/druid/conf/DruidConstants.java 242f7be4dd
> druid-handler/src/java/org/apache/hadoop/hive/druid/conf/package-info.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidQueryBasedInputFormat.java c1e0e75f98
> druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidRecordWriter.java 65edc665a3
> druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidVectorizedWrapper.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/io/package-info.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/AvroBytesDecoder.java 3a1dbf7229
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/AvroParseSpec.java af71f9a732
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/AvroStreamInputRowParser.java d6e6624669
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/InlineSchemaAvroBytesDecoder.java 72d6cbbc1e
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/KafkaSupervisorIOConfig.java c1b3bf8d41
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/TaskReportData.java 9ecba1b18c
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/package-info.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/package-info.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/security/package-info.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/serde/DruidQueryRecordReader.java 53d74417f8
> druid-handler/src/java/org/apache/hadoop/hive/druid/serde/DruidSerDe.java 516faf0814
> druid-handler/src/java/org/apache/hadoop/hive/druid/serde/package-info.java PRE-CREATION
> druid-handler/src/test/org/apache/hadoop/hive/druid/DerbyConnectorTestUtility.java bf42a74f0f
> druid-handler/src/test/org/apache/hadoop/hive/druid/QTestDruidSerDe.java 099e5b3357
> druid-handler/src/test/org/apache/hadoop/hive/druid/QTestDruidSerDe2.java f52e721763
> druid-handler/src/test/org/apache/hadoop/hive/druid/TestDruidStorageHandler.java 0cb3c237b1
> druid-handler/src/test/org/apache/hadoop/hive/druid/TestHiveDruidQueryBasedInputFormat.java 513119ea32
> druid-handler/src/test/org/apache/hadoop/hive/druid/io/TestHiveDruidSplit.java 234c783d25
> druid-handler/src/test/org/apache/hadoop/hive/druid/io/package-info.java PRE-CREATION
> druid-handler/src/test/org/apache/hadoop/hive/druid/package-info.java PRE-CREATION
> druid-handler/src/test/org/apache/hadoop/hive/druid/serde/TestDruidSerDe.java e27f8cf0e8
> druid-handler/src/test/org/apache/hadoop/hive/druid/serde/package-info.java PRE-CREATION
> druid-handler/src/test/org/apache/hadoop/hive/package-info.java PRE-CREATION
> druid-handler/src/test/org/apache/hadoop/hive/ql/io/TestDruidRecordWriter.java 63efdc4d8f
> druid-handler/src/test/org/apache/hadoop/hive/ql/io/package-info.java PRE-CREATION
> ql/src/test/queries/clientpositive/druidkafkamini_basic.q 73593ef0b3
> ql/src/test/queries/clientpositive/druidmini_dynamic_partition.q 1b208625e7
> ql/src/test/queries/clientpositive/druidmini_expressions.q a39cd13cca
> ql/src/test/queries/clientpositive/druidmini_extractTime.q 03afbe24f2
> ql/src/test/queries/clientpositive/druidmini_floorTime.q b0dce67b50
> ql/src/test/queries/clientpositive/druidmini_joins.q 1f92a0d1f0
> ql/src/test/queries/clientpositive/druidmini_test1.q a4031c6ab1
> ql/src/test/results/clientpositive/druid/druidkafkamini_basic.q.out 14522fb687
> ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out b07ed52d06
> ql/src/test/results/clientpositive/druid/druidmini_extractTime.q.out 4ea95f6930
> ql/src/test/results/clientpositive/druid/druidmini_floorTime.q.out 8d9382443e
> ql/src/test/results/clientpositive/druid/druidmini_test1.q.out 7aa1763161
> ql/src/test/results/clientpositive/druid/druidmini_test_ts.q.out 9c412d97dd
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java ef5e5a6cc7
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java 51a0aed16a
> storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/ColumnVector.java 01bd2f6e88
> storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java f8ed7e29e5
>
>
> Diff: https://reviews.apache.org/r/69404/diff/1/
>
>
> Testing
> -------
>
> Qfiles tests added.
>
>
> Thanks,
>
> Slim Bouguerra
>
>
Re: Review Request 69404: HIVE-20932 adding vectorize wrapper for
Druid Storage Handler.
Posted by Slim Bouguerra <sb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69404/
-----------------------------------------------------------
(Updated Nov. 22, 2018, 4:32 a.m.)
Review request for hive, Gopal V and Teddy Choi.
Bugs: HIVE-20932
https://issues.apache.org/jira/browse/HIVE-20932
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-20932
Note for reviewing
most important changes are :
- druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidVectorizedWrapper.java
- org.apache.hadoop.hive.druid.serde.DruidSerDe#deserializeAsPrimitive
- org.apache.hadoop.hive.druid.io.DruidQueryBasedInputFormat#getRecordReader
Diffs (updated)
-----
druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidQueryBasedInputFormat.java 70c923d18b
druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidVectorizedWrapper.java PRE-CREATION
druid-handler/src/java/org/apache/hadoop/hive/druid/serde/DruidSerDe.java 9bd84e8011
ql/src/test/queries/clientpositive/druidmini_expressions.q ce511de50a
ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out 0cd54fcf5a
Diff: https://reviews.apache.org/r/69404/diff/4/
Changes: https://reviews.apache.org/r/69404/diff/3-4/
Testing
-------
Qfiles tests added.
Thanks,
Slim Bouguerra
Re: Review Request 69404: HIVE-20932 adding vectorize wrapper for
Druid Storage Handler.
Posted by Slim Bouguerra <sb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69404/
-----------------------------------------------------------
(Updated Nov. 21, 2018, 9:41 p.m.)
Review request for hive, Gopal V and Teddy Choi.
Changes
-------
clean code style issue
Bugs: HIVE-20932
https://issues.apache.org/jira/browse/HIVE-20932
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-20932
Note for reviewing
most important changes are :
- druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidVectorizedWrapper.java
- org.apache.hadoop.hive.druid.serde.DruidSerDe#deserializeAsPrimitive
- org.apache.hadoop.hive.druid.io.DruidQueryBasedInputFormat#getRecordReader
Diffs (updated)
-----
druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidQueryBasedInputFormat.java 70c923d18b
druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidVectorizedWrapper.java PRE-CREATION
druid-handler/src/java/org/apache/hadoop/hive/druid/serde/DruidSerDe.java 9bd84e8011
ql/src/test/queries/clientpositive/druidmini_expressions.q ce511de50a
ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out 0cd54fcf5a
Diff: https://reviews.apache.org/r/69404/diff/3/
Changes: https://reviews.apache.org/r/69404/diff/2-3/
Testing
-------
Qfiles tests added.
Thanks,
Slim Bouguerra
Re: Review Request 69404: HIVE-20932 adding vectorize wrapper for
Druid Storage Handler.
Posted by Slim Bouguerra <sb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69404/
-----------------------------------------------------------
(Updated Nov. 21, 2018, 3:28 p.m.)
Review request for hive, Gopal V and Teddy Choi.
Changes
-------
split into 2 patches
Bugs: HIVE-20932
https://issues.apache.org/jira/browse/HIVE-20932
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-20932
Note for reviewing
most important changes are :
- druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidVectorizedWrapper.java
- org.apache.hadoop.hive.druid.serde.DruidSerDe#deserializeAsPrimitive
- org.apache.hadoop.hive.druid.io.DruidQueryBasedInputFormat#getRecordReader
Diffs (updated)
-----
druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidQueryBasedInputFormat.java 70c923d18b
druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidVectorizedWrapper.java PRE-CREATION
druid-handler/src/java/org/apache/hadoop/hive/druid/serde/DruidSerDe.java 9bd84e8011
ql/src/test/queries/clientpositive/druidmini_expressions.q ce511de50a
ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out 0cd54fcf5a
Diff: https://reviews.apache.org/r/69404/diff/2/
Changes: https://reviews.apache.org/r/69404/diff/1-2/
Testing
-------
Qfiles tests added.
Thanks,
Slim Bouguerra
Re: Review Request 69404: HIVE-20932 adding vectorize wrapper for
Druid Storage Handler.
Posted by Nishant Bangarwa <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69404/#review210700
-----------------------------------------------------------
please break down this into 2 separate patches.
The main benefits of separating this would be easy reviews as well as backporting the changes to other branches would be easier and would lead to less conflicts.
- Nishant Bangarwa
On Nov. 20, 2018, 2:08 a.m., Slim Bouguerra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69404/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2018, 2:08 a.m.)
>
>
> Review request for hive, Gopal V and Teddy Choi.
>
>
> Bugs: HIVE-20932
> https://issues.apache.org/jira/browse/HIVE-20932
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-20932
> Note for reviewing
> most important changes are :
>
> - druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidVectorizedWrapper.java
> - org.apache.hadoop.hive.druid.serde.DruidSerDe#deserializeAsPrimitive
> - org.apache.hadoop.hive.druid.io.DruidQueryBasedInputFormat#getRecordReader
>
>
> Diffs
> -----
>
> checkstyle/checkstyle.xml 12e166311b
> data/files/datasets/druid_table_alltypesorc/load.hive.sql 5fde266a01
> data/scripts/q_test_cleanup.sql 1c59381aa0
> druid-handler/src/java/org/apache/hadoop/hive/druid/DruidKafkaUtils.java e0e29a3c6d
> druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandler.java 7434559532
> druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandlerUtils.java 6dc97d53b7
> druid-handler/src/java/org/apache/hadoop/hive/druid/conf/DruidConstants.java 242f7be4dd
> druid-handler/src/java/org/apache/hadoop/hive/druid/conf/package-info.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidQueryBasedInputFormat.java c1e0e75f98
> druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidRecordWriter.java 65edc665a3
> druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidVectorizedWrapper.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/io/package-info.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/AvroBytesDecoder.java 3a1dbf7229
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/AvroParseSpec.java af71f9a732
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/AvroStreamInputRowParser.java d6e6624669
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/InlineSchemaAvroBytesDecoder.java 72d6cbbc1e
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/KafkaSupervisorIOConfig.java c1b3bf8d41
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/TaskReportData.java 9ecba1b18c
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/package-info.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/package-info.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/security/package-info.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/serde/DruidQueryRecordReader.java 53d74417f8
> druid-handler/src/java/org/apache/hadoop/hive/druid/serde/DruidSerDe.java 516faf0814
> druid-handler/src/java/org/apache/hadoop/hive/druid/serde/package-info.java PRE-CREATION
> druid-handler/src/test/org/apache/hadoop/hive/druid/DerbyConnectorTestUtility.java bf42a74f0f
> druid-handler/src/test/org/apache/hadoop/hive/druid/QTestDruidSerDe.java 099e5b3357
> druid-handler/src/test/org/apache/hadoop/hive/druid/QTestDruidSerDe2.java f52e721763
> druid-handler/src/test/org/apache/hadoop/hive/druid/TestDruidStorageHandler.java 0cb3c237b1
> druid-handler/src/test/org/apache/hadoop/hive/druid/TestHiveDruidQueryBasedInputFormat.java 513119ea32
> druid-handler/src/test/org/apache/hadoop/hive/druid/io/TestHiveDruidSplit.java 234c783d25
> druid-handler/src/test/org/apache/hadoop/hive/druid/io/package-info.java PRE-CREATION
> druid-handler/src/test/org/apache/hadoop/hive/druid/package-info.java PRE-CREATION
> druid-handler/src/test/org/apache/hadoop/hive/druid/serde/TestDruidSerDe.java e27f8cf0e8
> druid-handler/src/test/org/apache/hadoop/hive/druid/serde/package-info.java PRE-CREATION
> druid-handler/src/test/org/apache/hadoop/hive/package-info.java PRE-CREATION
> druid-handler/src/test/org/apache/hadoop/hive/ql/io/TestDruidRecordWriter.java 63efdc4d8f
> druid-handler/src/test/org/apache/hadoop/hive/ql/io/package-info.java PRE-CREATION
> ql/src/test/queries/clientpositive/druidkafkamini_basic.q 73593ef0b3
> ql/src/test/queries/clientpositive/druidmini_dynamic_partition.q 1b208625e7
> ql/src/test/queries/clientpositive/druidmini_expressions.q a39cd13cca
> ql/src/test/queries/clientpositive/druidmini_extractTime.q 03afbe24f2
> ql/src/test/queries/clientpositive/druidmini_floorTime.q b0dce67b50
> ql/src/test/queries/clientpositive/druidmini_joins.q 1f92a0d1f0
> ql/src/test/queries/clientpositive/druidmini_test1.q a4031c6ab1
> ql/src/test/results/clientpositive/druid/druidkafkamini_basic.q.out 14522fb687
> ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out b07ed52d06
> ql/src/test/results/clientpositive/druid/druidmini_extractTime.q.out 4ea95f6930
> ql/src/test/results/clientpositive/druid/druidmini_floorTime.q.out 8d9382443e
> ql/src/test/results/clientpositive/druid/druidmini_test1.q.out 7aa1763161
> ql/src/test/results/clientpositive/druid/druidmini_test_ts.q.out 9c412d97dd
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java ef5e5a6cc7
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java 51a0aed16a
> storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/ColumnVector.java 01bd2f6e88
> storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java f8ed7e29e5
>
>
> Diff: https://reviews.apache.org/r/69404/diff/1/
>
>
> Testing
> -------
>
> Qfiles tests added.
>
>
> Thanks,
>
> Slim Bouguerra
>
>
Re: Review Request 69404: HIVE-20932 adding vectorize wrapper for
Druid Storage Handler.
Posted by Slim Bouguerra <sb...@hortonworks.com>.
> On Nov. 20, 2018, 7:57 a.m., Nishant Bangarwa wrote:
> > checkstyle/checkstyle.xml
> > Lines 166 (patched)
> > <https://reviews.apache.org/r/69404/diff/1/?file=2108895#file2108895line166>
> >
> > please break down this into 2 separate patches.
> > The main benefits of separating this would be easy reviews as well as backporting the changes to other branches would be easier and would lead to less conflicts.
For the reviews i mentioned the classes that need to be looked at. All the reset is a checkstyle fix. Not sure why it is hard to backport since it will be a follow up anyway thus on master branch and other changes will follow.
I tend to minimize the number of patches to avoid huge wait time on the Test queue. My goal is to remove all the style issue, as you can see now the count is 0.
BTW i noticed that your license header is not the one used by Hive can you please fix it.
- Slim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69404/#review210701
-----------------------------------------------------------
On Nov. 20, 2018, 2:08 a.m., Slim Bouguerra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69404/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2018, 2:08 a.m.)
>
>
> Review request for hive, Gopal V and Teddy Choi.
>
>
> Bugs: HIVE-20932
> https://issues.apache.org/jira/browse/HIVE-20932
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-20932
> Note for reviewing
> most important changes are :
>
> - druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidVectorizedWrapper.java
> - org.apache.hadoop.hive.druid.serde.DruidSerDe#deserializeAsPrimitive
> - org.apache.hadoop.hive.druid.io.DruidQueryBasedInputFormat#getRecordReader
>
>
> Diffs
> -----
>
> checkstyle/checkstyle.xml 12e166311b
> data/files/datasets/druid_table_alltypesorc/load.hive.sql 5fde266a01
> data/scripts/q_test_cleanup.sql 1c59381aa0
> druid-handler/src/java/org/apache/hadoop/hive/druid/DruidKafkaUtils.java e0e29a3c6d
> druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandler.java 7434559532
> druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandlerUtils.java 6dc97d53b7
> druid-handler/src/java/org/apache/hadoop/hive/druid/conf/DruidConstants.java 242f7be4dd
> druid-handler/src/java/org/apache/hadoop/hive/druid/conf/package-info.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidQueryBasedInputFormat.java c1e0e75f98
> druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidRecordWriter.java 65edc665a3
> druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidVectorizedWrapper.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/io/package-info.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/AvroBytesDecoder.java 3a1dbf7229
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/AvroParseSpec.java af71f9a732
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/AvroStreamInputRowParser.java d6e6624669
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/InlineSchemaAvroBytesDecoder.java 72d6cbbc1e
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/KafkaSupervisorIOConfig.java c1b3bf8d41
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/TaskReportData.java 9ecba1b18c
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/package-info.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/package-info.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/security/package-info.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/serde/DruidQueryRecordReader.java 53d74417f8
> druid-handler/src/java/org/apache/hadoop/hive/druid/serde/DruidSerDe.java 516faf0814
> druid-handler/src/java/org/apache/hadoop/hive/druid/serde/package-info.java PRE-CREATION
> druid-handler/src/test/org/apache/hadoop/hive/druid/DerbyConnectorTestUtility.java bf42a74f0f
> druid-handler/src/test/org/apache/hadoop/hive/druid/QTestDruidSerDe.java 099e5b3357
> druid-handler/src/test/org/apache/hadoop/hive/druid/QTestDruidSerDe2.java f52e721763
> druid-handler/src/test/org/apache/hadoop/hive/druid/TestDruidStorageHandler.java 0cb3c237b1
> druid-handler/src/test/org/apache/hadoop/hive/druid/TestHiveDruidQueryBasedInputFormat.java 513119ea32
> druid-handler/src/test/org/apache/hadoop/hive/druid/io/TestHiveDruidSplit.java 234c783d25
> druid-handler/src/test/org/apache/hadoop/hive/druid/io/package-info.java PRE-CREATION
> druid-handler/src/test/org/apache/hadoop/hive/druid/package-info.java PRE-CREATION
> druid-handler/src/test/org/apache/hadoop/hive/druid/serde/TestDruidSerDe.java e27f8cf0e8
> druid-handler/src/test/org/apache/hadoop/hive/druid/serde/package-info.java PRE-CREATION
> druid-handler/src/test/org/apache/hadoop/hive/package-info.java PRE-CREATION
> druid-handler/src/test/org/apache/hadoop/hive/ql/io/TestDruidRecordWriter.java 63efdc4d8f
> druid-handler/src/test/org/apache/hadoop/hive/ql/io/package-info.java PRE-CREATION
> ql/src/test/queries/clientpositive/druidkafkamini_basic.q 73593ef0b3
> ql/src/test/queries/clientpositive/druidmini_dynamic_partition.q 1b208625e7
> ql/src/test/queries/clientpositive/druidmini_expressions.q a39cd13cca
> ql/src/test/queries/clientpositive/druidmini_extractTime.q 03afbe24f2
> ql/src/test/queries/clientpositive/druidmini_floorTime.q b0dce67b50
> ql/src/test/queries/clientpositive/druidmini_joins.q 1f92a0d1f0
> ql/src/test/queries/clientpositive/druidmini_test1.q a4031c6ab1
> ql/src/test/results/clientpositive/druid/druidkafkamini_basic.q.out 14522fb687
> ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out b07ed52d06
> ql/src/test/results/clientpositive/druid/druidmini_extractTime.q.out 4ea95f6930
> ql/src/test/results/clientpositive/druid/druidmini_floorTime.q.out 8d9382443e
> ql/src/test/results/clientpositive/druid/druidmini_test1.q.out 7aa1763161
> ql/src/test/results/clientpositive/druid/druidmini_test_ts.q.out 9c412d97dd
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java ef5e5a6cc7
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java 51a0aed16a
> storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/ColumnVector.java 01bd2f6e88
> storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java f8ed7e29e5
>
>
> Diff: https://reviews.apache.org/r/69404/diff/1/
>
>
> Testing
> -------
>
> Qfiles tests added.
>
>
> Thanks,
>
> Slim Bouguerra
>
>
Re: Review Request 69404: HIVE-20932 adding vectorize wrapper for
Druid Storage Handler.
Posted by Nishant Bangarwa <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69404/#review210701
-----------------------------------------------------------
checkstyle/checkstyle.xml
Lines 166 (patched)
<https://reviews.apache.org/r/69404/#comment295436>
please break down this into 2 separate patches.
The main benefits of separating this would be easy reviews as well as backporting the changes to other branches would be easier and would lead to less conflicts.
- Nishant Bangarwa
On Nov. 20, 2018, 2:08 a.m., Slim Bouguerra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69404/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2018, 2:08 a.m.)
>
>
> Review request for hive, Gopal V and Teddy Choi.
>
>
> Bugs: HIVE-20932
> https://issues.apache.org/jira/browse/HIVE-20932
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-20932
> Note for reviewing
> most important changes are :
>
> - druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidVectorizedWrapper.java
> - org.apache.hadoop.hive.druid.serde.DruidSerDe#deserializeAsPrimitive
> - org.apache.hadoop.hive.druid.io.DruidQueryBasedInputFormat#getRecordReader
>
>
> Diffs
> -----
>
> checkstyle/checkstyle.xml 12e166311b
> data/files/datasets/druid_table_alltypesorc/load.hive.sql 5fde266a01
> data/scripts/q_test_cleanup.sql 1c59381aa0
> druid-handler/src/java/org/apache/hadoop/hive/druid/DruidKafkaUtils.java e0e29a3c6d
> druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandler.java 7434559532
> druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandlerUtils.java 6dc97d53b7
> druid-handler/src/java/org/apache/hadoop/hive/druid/conf/DruidConstants.java 242f7be4dd
> druid-handler/src/java/org/apache/hadoop/hive/druid/conf/package-info.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidQueryBasedInputFormat.java c1e0e75f98
> druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidRecordWriter.java 65edc665a3
> druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidVectorizedWrapper.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/io/package-info.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/AvroBytesDecoder.java 3a1dbf7229
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/AvroParseSpec.java af71f9a732
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/AvroStreamInputRowParser.java d6e6624669
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/InlineSchemaAvroBytesDecoder.java 72d6cbbc1e
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/KafkaSupervisorIOConfig.java c1b3bf8d41
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/TaskReportData.java 9ecba1b18c
> druid-handler/src/java/org/apache/hadoop/hive/druid/json/package-info.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/package-info.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/security/package-info.java PRE-CREATION
> druid-handler/src/java/org/apache/hadoop/hive/druid/serde/DruidQueryRecordReader.java 53d74417f8
> druid-handler/src/java/org/apache/hadoop/hive/druid/serde/DruidSerDe.java 516faf0814
> druid-handler/src/java/org/apache/hadoop/hive/druid/serde/package-info.java PRE-CREATION
> druid-handler/src/test/org/apache/hadoop/hive/druid/DerbyConnectorTestUtility.java bf42a74f0f
> druid-handler/src/test/org/apache/hadoop/hive/druid/QTestDruidSerDe.java 099e5b3357
> druid-handler/src/test/org/apache/hadoop/hive/druid/QTestDruidSerDe2.java f52e721763
> druid-handler/src/test/org/apache/hadoop/hive/druid/TestDruidStorageHandler.java 0cb3c237b1
> druid-handler/src/test/org/apache/hadoop/hive/druid/TestHiveDruidQueryBasedInputFormat.java 513119ea32
> druid-handler/src/test/org/apache/hadoop/hive/druid/io/TestHiveDruidSplit.java 234c783d25
> druid-handler/src/test/org/apache/hadoop/hive/druid/io/package-info.java PRE-CREATION
> druid-handler/src/test/org/apache/hadoop/hive/druid/package-info.java PRE-CREATION
> druid-handler/src/test/org/apache/hadoop/hive/druid/serde/TestDruidSerDe.java e27f8cf0e8
> druid-handler/src/test/org/apache/hadoop/hive/druid/serde/package-info.java PRE-CREATION
> druid-handler/src/test/org/apache/hadoop/hive/package-info.java PRE-CREATION
> druid-handler/src/test/org/apache/hadoop/hive/ql/io/TestDruidRecordWriter.java 63efdc4d8f
> druid-handler/src/test/org/apache/hadoop/hive/ql/io/package-info.java PRE-CREATION
> ql/src/test/queries/clientpositive/druidkafkamini_basic.q 73593ef0b3
> ql/src/test/queries/clientpositive/druidmini_dynamic_partition.q 1b208625e7
> ql/src/test/queries/clientpositive/druidmini_expressions.q a39cd13cca
> ql/src/test/queries/clientpositive/druidmini_extractTime.q 03afbe24f2
> ql/src/test/queries/clientpositive/druidmini_floorTime.q b0dce67b50
> ql/src/test/queries/clientpositive/druidmini_joins.q 1f92a0d1f0
> ql/src/test/queries/clientpositive/druidmini_test1.q a4031c6ab1
> ql/src/test/results/clientpositive/druid/druidkafkamini_basic.q.out 14522fb687
> ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out b07ed52d06
> ql/src/test/results/clientpositive/druid/druidmini_extractTime.q.out 4ea95f6930
> ql/src/test/results/clientpositive/druid/druidmini_floorTime.q.out 8d9382443e
> ql/src/test/results/clientpositive/druid/druidmini_test1.q.out 7aa1763161
> ql/src/test/results/clientpositive/druid/druidmini_test_ts.q.out 9c412d97dd
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java ef5e5a6cc7
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java 51a0aed16a
> storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/ColumnVector.java 01bd2f6e88
> storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java f8ed7e29e5
>
>
> Diff: https://reviews.apache.org/r/69404/diff/1/
>
>
> Testing
> -------
>
> Qfiles tests added.
>
>
> Thanks,
>
> Slim Bouguerra
>
>
Re: Review Request 69404: HIVE-20932 adding vectorize wrapper for
Druid Storage Handler.
Posted by Slim Bouguerra <sb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69404/
-----------------------------------------------------------
(Updated Nov. 20, 2018, 2:08 a.m.)
Review request for hive, Gopal V and Teddy Choi.
Bugs: HIVE-20932
https://issues.apache.org/jira/browse/HIVE-20932
Repository: hive-git
Description (updated)
-------
https://issues.apache.org/jira/browse/HIVE-20932
Note for reviewing
most important changes are :
- druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidVectorizedWrapper.java
- org.apache.hadoop.hive.druid.serde.DruidSerDe#deserializeAsPrimitive
- org.apache.hadoop.hive.druid.io.DruidQueryBasedInputFormat#getRecordReader
Diffs
-----
checkstyle/checkstyle.xml 12e166311b
data/files/datasets/druid_table_alltypesorc/load.hive.sql 5fde266a01
data/scripts/q_test_cleanup.sql 1c59381aa0
druid-handler/src/java/org/apache/hadoop/hive/druid/DruidKafkaUtils.java e0e29a3c6d
druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandler.java 7434559532
druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandlerUtils.java 6dc97d53b7
druid-handler/src/java/org/apache/hadoop/hive/druid/conf/DruidConstants.java 242f7be4dd
druid-handler/src/java/org/apache/hadoop/hive/druid/conf/package-info.java PRE-CREATION
druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidQueryBasedInputFormat.java c1e0e75f98
druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidRecordWriter.java 65edc665a3
druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidVectorizedWrapper.java PRE-CREATION
druid-handler/src/java/org/apache/hadoop/hive/druid/io/package-info.java PRE-CREATION
druid-handler/src/java/org/apache/hadoop/hive/druid/json/AvroBytesDecoder.java 3a1dbf7229
druid-handler/src/java/org/apache/hadoop/hive/druid/json/AvroParseSpec.java af71f9a732
druid-handler/src/java/org/apache/hadoop/hive/druid/json/AvroStreamInputRowParser.java d6e6624669
druid-handler/src/java/org/apache/hadoop/hive/druid/json/InlineSchemaAvroBytesDecoder.java 72d6cbbc1e
druid-handler/src/java/org/apache/hadoop/hive/druid/json/KafkaSupervisorIOConfig.java c1b3bf8d41
druid-handler/src/java/org/apache/hadoop/hive/druid/json/TaskReportData.java 9ecba1b18c
druid-handler/src/java/org/apache/hadoop/hive/druid/json/package-info.java PRE-CREATION
druid-handler/src/java/org/apache/hadoop/hive/druid/package-info.java PRE-CREATION
druid-handler/src/java/org/apache/hadoop/hive/druid/security/package-info.java PRE-CREATION
druid-handler/src/java/org/apache/hadoop/hive/druid/serde/DruidQueryRecordReader.java 53d74417f8
druid-handler/src/java/org/apache/hadoop/hive/druid/serde/DruidSerDe.java 516faf0814
druid-handler/src/java/org/apache/hadoop/hive/druid/serde/package-info.java PRE-CREATION
druid-handler/src/test/org/apache/hadoop/hive/druid/DerbyConnectorTestUtility.java bf42a74f0f
druid-handler/src/test/org/apache/hadoop/hive/druid/QTestDruidSerDe.java 099e5b3357
druid-handler/src/test/org/apache/hadoop/hive/druid/QTestDruidSerDe2.java f52e721763
druid-handler/src/test/org/apache/hadoop/hive/druid/TestDruidStorageHandler.java 0cb3c237b1
druid-handler/src/test/org/apache/hadoop/hive/druid/TestHiveDruidQueryBasedInputFormat.java 513119ea32
druid-handler/src/test/org/apache/hadoop/hive/druid/io/TestHiveDruidSplit.java 234c783d25
druid-handler/src/test/org/apache/hadoop/hive/druid/io/package-info.java PRE-CREATION
druid-handler/src/test/org/apache/hadoop/hive/druid/package-info.java PRE-CREATION
druid-handler/src/test/org/apache/hadoop/hive/druid/serde/TestDruidSerDe.java e27f8cf0e8
druid-handler/src/test/org/apache/hadoop/hive/druid/serde/package-info.java PRE-CREATION
druid-handler/src/test/org/apache/hadoop/hive/package-info.java PRE-CREATION
druid-handler/src/test/org/apache/hadoop/hive/ql/io/TestDruidRecordWriter.java 63efdc4d8f
druid-handler/src/test/org/apache/hadoop/hive/ql/io/package-info.java PRE-CREATION
ql/src/test/queries/clientpositive/druidkafkamini_basic.q 73593ef0b3
ql/src/test/queries/clientpositive/druidmini_dynamic_partition.q 1b208625e7
ql/src/test/queries/clientpositive/druidmini_expressions.q a39cd13cca
ql/src/test/queries/clientpositive/druidmini_extractTime.q 03afbe24f2
ql/src/test/queries/clientpositive/druidmini_floorTime.q b0dce67b50
ql/src/test/queries/clientpositive/druidmini_joins.q 1f92a0d1f0
ql/src/test/queries/clientpositive/druidmini_test1.q a4031c6ab1
ql/src/test/results/clientpositive/druid/druidkafkamini_basic.q.out 14522fb687
ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out b07ed52d06
ql/src/test/results/clientpositive/druid/druidmini_extractTime.q.out 4ea95f6930
ql/src/test/results/clientpositive/druid/druidmini_floorTime.q.out 8d9382443e
ql/src/test/results/clientpositive/druid/druidmini_test1.q.out 7aa1763161
ql/src/test/results/clientpositive/druid/druidmini_test_ts.q.out 9c412d97dd
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java ef5e5a6cc7
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java 51a0aed16a
storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/ColumnVector.java 01bd2f6e88
storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java f8ed7e29e5
Diff: https://reviews.apache.org/r/69404/diff/1/
Testing
-------
Qfiles tests added.
Thanks,
Slim Bouguerra