You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by andreaTP <gi...@git.apache.org> on 2017/03/17 10:06:29 UTC
[GitHub] zeppelin pull request #2150: [ZEPPELIN-2278] Env variable to configure Npm r...
GitHub user andreaTP opened a pull request:
https://github.com/apache/zeppelin/pull/2150
[ZEPPELIN-2278] Env variable to configure Npm registry
### What is this PR for?
When deploying Zeppelin in private Cloud or within closed networks, it happens that Npm Registry isn't directly reachable, so we want to configure our own proxy/registry otherwise we couldn't fetch dependencies. It is anyhow worth to let user configure npm registry instead of hardcoding the URL.
### What type of PR is it?
Improvement
### What is the Jira issue?
[ZEPPELIN-2278]
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nokia/zeppelin npmConfig
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2150.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2150
----
commit 653ff57f10e398b4c4fb1f5c779cc392069b74b5
Author: Andrea Peruffo <an...@gmail.com>
Date: 2017-03-17T09:59:44Z
[ZEPPELIN-2278] Env variable to configure Npm registry
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2150: [ZEPPELIN-2278] Env variable to configure Npm registry
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2150
Looks like Jenkins build script still does not handle contribution from organization repository very well.
Let me try fix this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2150: [ZEPPELIN-2278] Env variable to configure Npm registry
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2150
probably you have a problem on Jenkins, Travis is currently building without errors:
https://travis-ci.org/nokia/zeppelin
still this PR is marked as Failed...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2150: [ZEPPELIN-2278] Env variable to configure Npm r...
Posted by andreaTP <gi...@git.apache.org>.
GitHub user andreaTP reopened a pull request:
https://github.com/apache/zeppelin/pull/2150
[ZEPPELIN-2278] Env variable to configure Npm registry
### What is this PR for?
When deploying Zeppelin in private Cloud or within closed networks, it happens that Npm Registry isn't directly reachable, so we want to configure our own proxy/registry otherwise we couldn't fetch dependencies. It is anyhow worth to let user configure npm registry instead of hardcoding the URL.
### What type of PR is it?
Improvement
### What is the Jira issue?
[ZEPPELIN-2278]
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nokia/zeppelin npmConfig
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2150.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2150
----
commit 56fab25ff9f01014e5666f46b121ce65c8a07cb2
Author: Andrea Peruffo <an...@gmail.com>
Date: 2017-03-17T09:59:44Z
[ZEPPELIN-2278] Env variable to configure Npm registry
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2150: [ZEPPELIN-2278] Env variable to configure Npm registry
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2150
I updated Jenkins build command. @andreaTP can you close / reopen this PR? Jenkins now will check https://travis-ci.org/nokia/zeppelin/builds/213131116 correctly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2150: [ZEPPELIN-2278] Env variable to configure Npm r...
Posted by andreaTP <gi...@git.apache.org>.
GitHub user andreaTP reopened a pull request:
https://github.com/apache/zeppelin/pull/2150
[ZEPPELIN-2278] Env variable to configure Npm registry
### What is this PR for?
When deploying Zeppelin in private Cloud or within closed networks, it happens that Npm Registry isn't directly reachable, so we want to configure our own proxy/registry otherwise we couldn't fetch dependencies. It is anyhow worth to let user configure npm registry instead of hardcoding the URL.
### What type of PR is it?
Improvement
### What is the Jira issue?
[ZEPPELIN-2278]
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nokia/zeppelin npmConfig
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2150.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2150
----
commit 56fab25ff9f01014e5666f46b121ce65c8a07cb2
Author: Andrea Peruffo <an...@gmail.com>
Date: 2017-03-17T09:59:44Z
[ZEPPELIN-2278] Env variable to configure Npm registry
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2150: [ZEPPELIN-2278] Env variable to configure Npm registry
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2150
Done, let see the result!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2150: [ZEPPELIN-2278] Env variable to configure Npm registry
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2150
failures looks unrelated ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2150: [ZEPPELIN-2278] Env variable to configure Npm registry
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2150
@andreaTP There are some conflict files after #2093 merged. Can you resolve them?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2150: [ZEPPELIN-2278] Env variable to configure Npm r...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2150
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2150: [ZEPPELIN-2278] Env variable to configure Npm registry
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2150
Travis itself succed https://travis-ci.org/nokia/zeppelin/builds/213131116
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2150: [ZEPPELIN-2278] Env variable to configure Npm registry
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2150
Thanks for the feedback @1ambda , travis should be configured properly now, I will try to dig into but it looks tests spuriously fail, anyhow any help on getting the right direction is highly appreciated!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2150: [ZEPPELIN-2278] Env variable to configure Npm registry
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2150
I made a mistake. And updated the jenkins command again. @andreaTP Could you close/reopen once more? :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2150: [ZEPPELIN-2278] Env variable to configure Npm r...
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP closed the pull request at:
https://github.com/apache/zeppelin/pull/2150
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2150: [ZEPPELIN-2278] Env variable to configure Npm registry
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2150
@andreaTP
Problem on CI just has fixed on master branch.
Could you try rebase or merge master branch and see if CI passes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2150: [ZEPPELIN-2278] Env variable to configure Npm registry
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2150
Please go on! Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2150: [ZEPPELIN-2278] Env variable to configure Npm registry
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2150
It might be due to flaky tests. If so, please just restart failed jobs.
I'v just looked your travis build and it's ok
- https://travis-ci.org/andreaTP/zeppelin/builds/212066501
After CI is green, please close and re-open this PR. Then jenkins will update status.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2150: [ZEPPELIN-2278] Env variable to configure Npm r...
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP closed the pull request at:
https://github.com/apache/zeppelin/pull/2150
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2150: [ZEPPELIN-2278] Env variable to configure Npm r...
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP closed the pull request at:
https://github.com/apache/zeppelin/pull/2150
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2150: [ZEPPELIN-2278] Env variable to configure Npm registry
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2150
@AhyoungRyu rebased on top of current *master*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2150: [ZEPPELIN-2278] Env variable to configure Npm registry
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2150
Hi @andreaTP. Thanks for contribution.
- Zeppelin build system relies on travis. So please setup your travis account and travis project for Zeppelin.
- https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
- The repository name must be `zeppelin` (not `incubator-zeppelin`, ...)
- It's not mandatory to pass all tests to be reviewed. But some reviewers might select passed PRs first
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2150: [ZEPPELIN-2278] Env variable to configure Npm registry
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2150
Thanks @andreaTP for the improvement!
LGTM and merge to master if no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2150: [ZEPPELIN-2278] Env variable to configure Npm r...
Posted by andreaTP <gi...@git.apache.org>.
GitHub user andreaTP reopened a pull request:
https://github.com/apache/zeppelin/pull/2150
[ZEPPELIN-2278] Env variable to configure Npm registry
### What is this PR for?
When deploying Zeppelin in private Cloud or within closed networks, it happens that Npm Registry isn't directly reachable, so we want to configure our own proxy/registry otherwise we couldn't fetch dependencies. It is anyhow worth to let user configure npm registry instead of hardcoding the URL.
### What type of PR is it?
Improvement
### What is the Jira issue?
[ZEPPELIN-2278]
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nokia/zeppelin npmConfig
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2150.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2150
----
commit 6bebed23805b409a050c22606250ba1bef9f3c44
Author: Andrea Peruffo <an...@gmail.com>
Date: 2017-03-17T09:59:44Z
[ZEPPELIN-2278] Env variable to configure Npm registry
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2150: [ZEPPELIN-2278] Env variable to configure Npm registry
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2150
@Leemoonsoo
rebased.
Unfortunately again failures on CI, this is on Jenkins side I guess https://builds.apache.org/job/zeppelin-pull-request/580/console
this is spurious since travis job is correctly started.
I go closing and re-opening the PR to trigger again the build (seemed to work last time)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2150: [ZEPPELIN-2278] Env variable to configure Npm registry
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2150
no luck again :-(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---