[GitHub] [accumulo-proxy] ctubbsii commented on pull request #68: Remove tests that switch users

["ctubbsii (via GitHub)" <gi...@apache.org>]

ctubbsii commented on PR #68:
URL: https://github.com/apache/accumulo-proxy/pull/68#issuecomment-1419536689

   > > Overall the changes look good. Was it discussed somewhere else as to why these tests are removed versus fixing?
   > 
   > Yea good point, sorry. There has been an effort to remove the use of multiple users in the proxy to reduce complexity. Most of that was taken care of in #59
   
   I think the previous comment by @Manno15 still had a point. Some of those tests probably needed fixing, rather than removal. For example, the permissions test could be changed so that the permissions are added/removed by the root user using the minicluster API directly, and the Proxy instance could be used to check the regular user's permissions are appropriately enabled/restricted.
   
   Similarly, the conditional writer test was doing some checks with the authorizations, which could have been manipulated in minicluster. Multiple proxy instances for separate users (using separate proxy config files for each separate user) would have also worked.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org