You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/13 06:47:31 UTC

[GitHub] [pulsar] lhotari opened a new pull request, #17606: [improve][CI] Ensure that ssh-access is only activated for PRs outside of apache/pulsar repo

lhotari opened a new pull request, #17606:
URL: https://github.com/apache/pulsar/pull/17606

   ### Motivation
   
   - the if condition was missing for the ssh-access step in pulsar-java-test-image build job
   
   ### Modifications
   
   - add the missing if condition to pulsar-java-test-image build job
   - add additional condition so that ssh-access is limited to pull requests in a forked repository
     - this is a better default
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
   
   - [x] `doc-not-needed` 
   (Please explain why)
   
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari merged pull request #17606: [improve][CI] Ensure that ssh-access is only activated for PRs outside of apache/pulsar repo

Posted by GitBox <gi...@apache.org>.
lhotari merged PR #17606:
URL: https://github.com/apache/pulsar/pull/17606


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #17606: [improve][CI] Ensure that ssh-access is only activated for PRs outside of apache/pulsar repo

Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #17606:
URL: https://github.com/apache/pulsar/pull/17606#issuecomment-1244973653

   I noticed the missing if condition since ssh-access was activated for this PR: https://github.com/apache/pulsar/actions/runs/3042275396/jobs/4901047274#step:4:134


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari closed pull request #17606: [improve][CI] Ensure that ssh-access is only activated for PRs outside of apache/pulsar repo

Posted by GitBox <gi...@apache.org>.
lhotari closed pull request #17606: [improve][CI] Ensure that ssh-access is only activated for PRs outside of apache/pulsar repo
URL: https://github.com/apache/pulsar/pull/17606


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org