You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Evelina Dumitrescu <ev...@gmail.com> on 2014/10/31 21:29:50 UTC
Review Request 27447: mesos: Renamed the Node class in Endpoint and
replaced
the ip and port pairs from UPID class and process namespace with this
concept.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27447/
-----------------------------------------------------------
Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
Bugs: MESOS-2019
https://issues.apache.org/jira/browse/MESOS-2019
Repository: mesos-git
Description
-------
The Node class abstracts the endpoint notion: it defines the association of the ip and port for a connection. A node defines more the host(which can have multiple active endpoints).
At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
I want to propose to rename this class in Endpoint and also extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
Diffs
-----
src/common/protobuf_utils.cpp a9b65e328c4c62bff7fbf5633dda25d742d79019
src/master/master.cpp 762d2ff6c168ac212f70b43275692a77496a7fcd
src/sched/sched.cpp 0fb8c7bda75545389f8024489b3c76ae115111f4
src/scheduler/scheduler.cpp fb88a3e029e97ba33eae5d50503be5ed9c9533e6
src/slave/http.cpp 965d78c3e3ea2e3c922f62aabf6fc87c5cf2ab8d
src/slave/slave.cpp 96fb5f7385b0762d46d8129f7e43207bd6311644
src/tests/files_tests.cpp a696aa22d56b37ee70c6e64c81a849da6d436451
src/tests/gc_tests.cpp f7747e2999cbd64ab0cd0321cca0021489dc3346
src/tests/logging_tests.cpp 58e9b3399c3de28b1c5b3a8ec8fdf85b7a31c6d5
src/tests/master_contender_detector_tests.cpp 8f7fb18f0ca985364565fc4cd50f113b1461fbe7
src/tests/master_tests.cpp 2e525749247626c05efb2f54a707599facb114b6
src/tests/monitor_tests.cpp 4b950e14bd94cdfa21212268b56bebdc1200078d
Diff: https://reviews.apache.org/r/27447/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 27447: mesos: Renamed the Node class in Endpoint
and
replaced the ip and port pairs from UPID class and process namespace with
this concept.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27447/#review59423
-----------------------------------------------------------
Patch looks great!
Reviews applied: [27446, 27447]
All tests passed.
- Mesos ReviewBot
On Oct. 31, 2014, 8:29 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27447/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2014, 8:29 p.m.)
>
>
> Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
>
>
> Bugs: MESOS-2019
> https://issues.apache.org/jira/browse/MESOS-2019
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The Node class abstracts the endpoint notion: it defines the association of the ip and port for a connection. A node defines more the host(which can have multiple active endpoints).
> At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
> I want to propose to rename this class in Endpoint and also extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.cpp a9b65e328c4c62bff7fbf5633dda25d742d79019
> src/master/master.cpp 762d2ff6c168ac212f70b43275692a77496a7fcd
> src/sched/sched.cpp 0fb8c7bda75545389f8024489b3c76ae115111f4
> src/scheduler/scheduler.cpp fb88a3e029e97ba33eae5d50503be5ed9c9533e6
> src/slave/http.cpp 965d78c3e3ea2e3c922f62aabf6fc87c5cf2ab8d
> src/slave/slave.cpp 96fb5f7385b0762d46d8129f7e43207bd6311644
> src/tests/files_tests.cpp a696aa22d56b37ee70c6e64c81a849da6d436451
> src/tests/gc_tests.cpp f7747e2999cbd64ab0cd0321cca0021489dc3346
> src/tests/logging_tests.cpp 58e9b3399c3de28b1c5b3a8ec8fdf85b7a31c6d5
> src/tests/master_contender_detector_tests.cpp 8f7fb18f0ca985364565fc4cd50f113b1461fbe7
> src/tests/master_tests.cpp 2e525749247626c05efb2f54a707599facb114b6
> src/tests/monitor_tests.cpp 4b950e14bd94cdfa21212268b56bebdc1200078d
>
> Diff: https://reviews.apache.org/r/27447/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 27447: mesos: Replaced the ip and port pairs from
UPID class and process namespace with Node class
Posted by Evelina Dumitrescu <ev...@gmail.com>.
> On Nov. 6, 2014, 5:49 p.m., Dominic Hamon wrote:
> > src/slave/slave.cpp, line 300
> > <https://reviews.apache.org/r/27447/diff/4/?file=751198#file751198line300>
> >
> > hm. so there is a getHostname but we don't use it in other places (see previous review where i recommended adding a host() method to Node).
Here is returned the name of the host. In the other case, is is used the string representation of the numerical value of the IP.
- Evelina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27447/#review60193
-----------------------------------------------------------
On Nov. 6, 2014, 2:49 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27447/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 2:49 a.m.)
>
>
> Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
>
>
> Bugs: MESOS-2019
> https://issues.apache.org/jira/browse/MESOS-2019
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
> I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.cpp 33ce782960e88e07b910f844fbdcae4c0f19d9a7
> src/master/master.cpp a860496d9d75ae4e007d35627d778caf10d08428
> src/sched/sched.cpp e5f828d0bf9dd03a01920634abfae685a7861b44
> src/scheduler/scheduler.cpp c74187cfeb57a748fd57198d3badd4b8773490eb
> src/slave/http.cpp 965d78c3e3ea2e3c922f62aabf6fc87c5cf2ab8d
> src/slave/slave.cpp dbfd1a8101d78dee8ea3ac19d990a6a7892e59be
> src/tests/fetcher_tests.cpp e026e875c7197cd214ef0432d7c40207553c8671
> src/tests/files_tests.cpp a696aa22d56b37ee70c6e64c81a849da6d436451
> src/tests/gc_tests.cpp f7747e2999cbd64ab0cd0321cca0021489dc3346
> src/tests/logging_tests.cpp 58e9b3399c3de28b1c5b3a8ec8fdf85b7a31c6d5
> src/tests/master_contender_detector_tests.cpp 8f7fb18f0ca985364565fc4cd50f113b1461fbe7
> src/tests/master_tests.cpp a6d1a4aaaaa5b7d50a88e5b101c43f62d21300cf
> src/tests/monitor_tests.cpp 4b950e14bd94cdfa21212268b56bebdc1200078d
>
> Diff: https://reviews.apache.org/r/27447/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 27447: mesos: Replaced the ip and port pairs from
UPID class and process namespace with Node class
Posted by Evelina Dumitrescu <ev...@gmail.com>.
> On Nov. 6, 2014, 5:49 p.m., Dominic Hamon wrote:
> > src/master/master.cpp, line 321
> > <https://reviews.apache.org/r/27447/diff/4/?file=751194#file751194line321>
> >
> > there really should be a utility method on node for this. especially as the check will need to be extended to ::1.
> >
> > Maybe 'isLoopback()'?
I intend to add for the IPAddress struct some methods to check for inaddr_any and loopback IPs:
bool is_loopback() const
{
if(family == AF_INET)
{
return ipv4_addr.s_addr == INADDR_LOOPBACK;
}
else if(family == AF_INET6)
{
IPAddress ipv6_loopback(in6addr_loopback);
return ipv6_loopback == ipv6_addr;
}
return false;
}
bool is_inaddrany() const
{
if(family == AF_INET)
{
return ipv4_addr.s_addr == INADDR_ANY;
}
else if(family == AF_INET6)
{
IPAddress ipv6_inaddr_any(in6addr_any);
return ipv6_inaddr_any == ipv6_addr;
}
return false;
}
- Evelina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27447/#review60193
-----------------------------------------------------------
On Nov. 6, 2014, 2:49 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27447/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 2:49 a.m.)
>
>
> Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
>
>
> Bugs: MESOS-2019
> https://issues.apache.org/jira/browse/MESOS-2019
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
> I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.cpp 33ce782960e88e07b910f844fbdcae4c0f19d9a7
> src/master/master.cpp a860496d9d75ae4e007d35627d778caf10d08428
> src/sched/sched.cpp e5f828d0bf9dd03a01920634abfae685a7861b44
> src/scheduler/scheduler.cpp c74187cfeb57a748fd57198d3badd4b8773490eb
> src/slave/http.cpp 965d78c3e3ea2e3c922f62aabf6fc87c5cf2ab8d
> src/slave/slave.cpp dbfd1a8101d78dee8ea3ac19d990a6a7892e59be
> src/tests/fetcher_tests.cpp e026e875c7197cd214ef0432d7c40207553c8671
> src/tests/files_tests.cpp a696aa22d56b37ee70c6e64c81a849da6d436451
> src/tests/gc_tests.cpp f7747e2999cbd64ab0cd0321cca0021489dc3346
> src/tests/logging_tests.cpp 58e9b3399c3de28b1c5b3a8ec8fdf85b7a31c6d5
> src/tests/master_contender_detector_tests.cpp 8f7fb18f0ca985364565fc4cd50f113b1461fbe7
> src/tests/master_tests.cpp a6d1a4aaaaa5b7d50a88e5b101c43f62d21300cf
> src/tests/monitor_tests.cpp 4b950e14bd94cdfa21212268b56bebdc1200078d
>
> Diff: https://reviews.apache.org/r/27447/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 27447: mesos: Replaced the ip and port pairs from
UPID class and process namespace with Node class
Posted by Evelina Dumitrescu <ev...@gmail.com>.
> On Nov. 6, 2014, 5:49 p.m., Dominic Hamon wrote:
> > src/master/master.cpp, line 290
> > <https://reviews.apache.org/r/27447/diff/4/?file=751194#file751194line290>
> >
> > possibility for a future patch: replace info_ ip and port with a protobuf 'node'?
I will consider this.
- Evelina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27447/#review60193
-----------------------------------------------------------
On Nov. 6, 2014, 2:49 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27447/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 2:49 a.m.)
>
>
> Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
>
>
> Bugs: MESOS-2019
> https://issues.apache.org/jira/browse/MESOS-2019
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
> I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.cpp 33ce782960e88e07b910f844fbdcae4c0f19d9a7
> src/master/master.cpp a860496d9d75ae4e007d35627d778caf10d08428
> src/sched/sched.cpp e5f828d0bf9dd03a01920634abfae685a7861b44
> src/scheduler/scheduler.cpp c74187cfeb57a748fd57198d3badd4b8773490eb
> src/slave/http.cpp 965d78c3e3ea2e3c922f62aabf6fc87c5cf2ab8d
> src/slave/slave.cpp dbfd1a8101d78dee8ea3ac19d990a6a7892e59be
> src/tests/fetcher_tests.cpp e026e875c7197cd214ef0432d7c40207553c8671
> src/tests/files_tests.cpp a696aa22d56b37ee70c6e64c81a849da6d436451
> src/tests/gc_tests.cpp f7747e2999cbd64ab0cd0321cca0021489dc3346
> src/tests/logging_tests.cpp 58e9b3399c3de28b1c5b3a8ec8fdf85b7a31c6d5
> src/tests/master_contender_detector_tests.cpp 8f7fb18f0ca985364565fc4cd50f113b1461fbe7
> src/tests/master_tests.cpp a6d1a4aaaaa5b7d50a88e5b101c43f62d21300cf
> src/tests/monitor_tests.cpp 4b950e14bd94cdfa21212268b56bebdc1200078d
>
> Diff: https://reviews.apache.org/r/27447/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 27447: mesos: Replaced the ip and port pairs from
UPID class and process namespace with Node class
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27447/#review60193
-----------------------------------------------------------
src/master/master.cpp
<https://reviews.apache.org/r/27447/#comment101551>
possibility for a future patch: replace info_ ip and port with a protobuf 'node'?
src/master/master.cpp
<https://reviews.apache.org/r/27447/#comment101553>
there really should be a utility method on node for this. especially as the check will need to be extended to ::1.
Maybe 'isLoopback()'?
src/slave/http.cpp
<https://reviews.apache.org/r/27447/#comment101556>
clumsy wrapping:
Try<string> masterHostname = net::getHostname(
slave->master.get().node.ip);
src/slave/slave.cpp
<https://reviews.apache.org/r/27447/#comment101557>
hm. so there is a getHostname but we don't use it in other places (see previous review where i recommended adding a host() method to Node).
- Dominic Hamon
On Nov. 5, 2014, 6:49 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27447/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2014, 6:49 p.m.)
>
>
> Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
>
>
> Bugs: MESOS-2019
> https://issues.apache.org/jira/browse/MESOS-2019
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
> I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.cpp 33ce782960e88e07b910f844fbdcae4c0f19d9a7
> src/master/master.cpp a860496d9d75ae4e007d35627d778caf10d08428
> src/sched/sched.cpp e5f828d0bf9dd03a01920634abfae685a7861b44
> src/scheduler/scheduler.cpp c74187cfeb57a748fd57198d3badd4b8773490eb
> src/slave/http.cpp 965d78c3e3ea2e3c922f62aabf6fc87c5cf2ab8d
> src/slave/slave.cpp dbfd1a8101d78dee8ea3ac19d990a6a7892e59be
> src/tests/fetcher_tests.cpp e026e875c7197cd214ef0432d7c40207553c8671
> src/tests/files_tests.cpp a696aa22d56b37ee70c6e64c81a849da6d436451
> src/tests/gc_tests.cpp f7747e2999cbd64ab0cd0321cca0021489dc3346
> src/tests/logging_tests.cpp 58e9b3399c3de28b1c5b3a8ec8fdf85b7a31c6d5
> src/tests/master_contender_detector_tests.cpp 8f7fb18f0ca985364565fc4cd50f113b1461fbe7
> src/tests/master_tests.cpp a6d1a4aaaaa5b7d50a88e5b101c43f62d21300cf
> src/tests/monitor_tests.cpp 4b950e14bd94cdfa21212268b56bebdc1200078d
>
> Diff: https://reviews.apache.org/r/27447/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 27447: mesos: Replaced the ip and port pairs from
UPID class and process namespace with Node class
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27447/#review60101
-----------------------------------------------------------
Patch looks great!
Reviews applied: [27446, 27447]
All tests passed.
- Mesos ReviewBot
On Nov. 6, 2014, 2:49 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27447/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 2:49 a.m.)
>
>
> Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
>
>
> Bugs: MESOS-2019
> https://issues.apache.org/jira/browse/MESOS-2019
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
> I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.cpp 33ce782960e88e07b910f844fbdcae4c0f19d9a7
> src/master/master.cpp a860496d9d75ae4e007d35627d778caf10d08428
> src/sched/sched.cpp e5f828d0bf9dd03a01920634abfae685a7861b44
> src/scheduler/scheduler.cpp c74187cfeb57a748fd57198d3badd4b8773490eb
> src/slave/http.cpp 965d78c3e3ea2e3c922f62aabf6fc87c5cf2ab8d
> src/slave/slave.cpp dbfd1a8101d78dee8ea3ac19d990a6a7892e59be
> src/tests/fetcher_tests.cpp e026e875c7197cd214ef0432d7c40207553c8671
> src/tests/files_tests.cpp a696aa22d56b37ee70c6e64c81a849da6d436451
> src/tests/gc_tests.cpp f7747e2999cbd64ab0cd0321cca0021489dc3346
> src/tests/logging_tests.cpp 58e9b3399c3de28b1c5b3a8ec8fdf85b7a31c6d5
> src/tests/master_contender_detector_tests.cpp 8f7fb18f0ca985364565fc4cd50f113b1461fbe7
> src/tests/master_tests.cpp a6d1a4aaaaa5b7d50a88e5b101c43f62d21300cf
> src/tests/monitor_tests.cpp 4b950e14bd94cdfa21212268b56bebdc1200078d
>
> Diff: https://reviews.apache.org/r/27447/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 27447: mesos: Replaced the ip and port pairs from
UPID class and process namespace with Node class.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27447/#review60301
-----------------------------------------------------------
Patch looks great!
Reviews applied: [27446, 27447]
All tests passed.
- Mesos ReviewBot
On Nov. 7, 2014, 3:23 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27447/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 3:23 a.m.)
>
>
> Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
>
>
> Bugs: MESOS-2019
> https://issues.apache.org/jira/browse/MESOS-2019
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
> I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.cpp 33ce782960e88e07b910f844fbdcae4c0f19d9a7
> src/master/master.cpp a860496d9d75ae4e007d35627d778caf10d08428
> src/sched/sched.cpp 8ca052635bf8772a6fa95972931b6254c6e452ef
> src/scheduler/scheduler.cpp c74187cfeb57a748fd57198d3badd4b8773490eb
> src/slave/http.cpp 965d78c3e3ea2e3c922f62aabf6fc87c5cf2ab8d
> src/slave/slave.cpp 81e0c4ba702d492976f9c771b8d779853c423187
> src/tests/fetcher_tests.cpp e026e875c7197cd214ef0432d7c40207553c8671
> src/tests/files_tests.cpp a696aa22d56b37ee70c6e64c81a849da6d436451
> src/tests/gc_tests.cpp f7747e2999cbd64ab0cd0321cca0021489dc3346
> src/tests/logging_tests.cpp 58e9b3399c3de28b1c5b3a8ec8fdf85b7a31c6d5
> src/tests/master_contender_detector_tests.cpp 8f7fb18f0ca985364565fc4cd50f113b1461fbe7
> src/tests/master_tests.cpp a6d1a4aaaaa5b7d50a88e5b101c43f62d21300cf
> src/tests/monitor_tests.cpp 4b950e14bd94cdfa21212268b56bebdc1200078d
>
> Diff: https://reviews.apache.org/r/27447/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 27447: mesos: Replaced the ip and port pairs from
UPID class and process namespace with Node class.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27447/#review60739
-----------------------------------------------------------
+1 looks good
- Michael Park
On Nov. 7, 2014, 3:23 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27447/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 3:23 a.m.)
>
>
> Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
>
>
> Bugs: MESOS-2019
> https://issues.apache.org/jira/browse/MESOS-2019
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
> I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.cpp 33ce782960e88e07b910f844fbdcae4c0f19d9a7
> src/master/master.cpp a860496d9d75ae4e007d35627d778caf10d08428
> src/sched/sched.cpp 8ca052635bf8772a6fa95972931b6254c6e452ef
> src/scheduler/scheduler.cpp c74187cfeb57a748fd57198d3badd4b8773490eb
> src/slave/http.cpp 965d78c3e3ea2e3c922f62aabf6fc87c5cf2ab8d
> src/slave/slave.cpp 81e0c4ba702d492976f9c771b8d779853c423187
> src/tests/fetcher_tests.cpp e026e875c7197cd214ef0432d7c40207553c8671
> src/tests/files_tests.cpp a696aa22d56b37ee70c6e64c81a849da6d436451
> src/tests/gc_tests.cpp f7747e2999cbd64ab0cd0321cca0021489dc3346
> src/tests/logging_tests.cpp 58e9b3399c3de28b1c5b3a8ec8fdf85b7a31c6d5
> src/tests/master_contender_detector_tests.cpp 8f7fb18f0ca985364565fc4cd50f113b1461fbe7
> src/tests/master_tests.cpp a6d1a4aaaaa5b7d50a88e5b101c43f62d21300cf
> src/tests/monitor_tests.cpp 4b950e14bd94cdfa21212268b56bebdc1200078d
>
> Diff: https://reviews.apache.org/r/27447/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 27447: mesos: Replaced the ip and port pairs from
UPID class and process namespace with Node class.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27447/#review60340
-----------------------------------------------------------
Ship it!
will wait for comments from other reviewers before committing.
- Dominic Hamon
On Nov. 6, 2014, 7:23 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27447/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 7:23 p.m.)
>
>
> Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
>
>
> Bugs: MESOS-2019
> https://issues.apache.org/jira/browse/MESOS-2019
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
> I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.cpp 33ce782960e88e07b910f844fbdcae4c0f19d9a7
> src/master/master.cpp a860496d9d75ae4e007d35627d778caf10d08428
> src/sched/sched.cpp 8ca052635bf8772a6fa95972931b6254c6e452ef
> src/scheduler/scheduler.cpp c74187cfeb57a748fd57198d3badd4b8773490eb
> src/slave/http.cpp 965d78c3e3ea2e3c922f62aabf6fc87c5cf2ab8d
> src/slave/slave.cpp 81e0c4ba702d492976f9c771b8d779853c423187
> src/tests/fetcher_tests.cpp e026e875c7197cd214ef0432d7c40207553c8671
> src/tests/files_tests.cpp a696aa22d56b37ee70c6e64c81a849da6d436451
> src/tests/gc_tests.cpp f7747e2999cbd64ab0cd0321cca0021489dc3346
> src/tests/logging_tests.cpp 58e9b3399c3de28b1c5b3a8ec8fdf85b7a31c6d5
> src/tests/master_contender_detector_tests.cpp 8f7fb18f0ca985364565fc4cd50f113b1461fbe7
> src/tests/master_tests.cpp a6d1a4aaaaa5b7d50a88e5b101c43f62d21300cf
> src/tests/monitor_tests.cpp 4b950e14bd94cdfa21212268b56bebdc1200078d
>
> Diff: https://reviews.apache.org/r/27447/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 27447: mesos: Replaced the ip and port pairs from
UPID class and process namespace with Node class.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27447/
-----------------------------------------------------------
(Updated Nov. 7, 2014, 3:23 a.m.)
Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
Summary (updated)
-----------------
mesos: Replaced the ip and port pairs from UPID class and process namespace with Node class.
Bugs: MESOS-2019
https://issues.apache.org/jira/browse/MESOS-2019
Repository: mesos-git
Description
-------
At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
Diffs (updated)
-----
src/common/protobuf_utils.cpp 33ce782960e88e07b910f844fbdcae4c0f19d9a7
src/master/master.cpp a860496d9d75ae4e007d35627d778caf10d08428
src/sched/sched.cpp 8ca052635bf8772a6fa95972931b6254c6e452ef
src/scheduler/scheduler.cpp c74187cfeb57a748fd57198d3badd4b8773490eb
src/slave/http.cpp 965d78c3e3ea2e3c922f62aabf6fc87c5cf2ab8d
src/slave/slave.cpp 81e0c4ba702d492976f9c771b8d779853c423187
src/tests/fetcher_tests.cpp e026e875c7197cd214ef0432d7c40207553c8671
src/tests/files_tests.cpp a696aa22d56b37ee70c6e64c81a849da6d436451
src/tests/gc_tests.cpp f7747e2999cbd64ab0cd0321cca0021489dc3346
src/tests/logging_tests.cpp 58e9b3399c3de28b1c5b3a8ec8fdf85b7a31c6d5
src/tests/master_contender_detector_tests.cpp 8f7fb18f0ca985364565fc4cd50f113b1461fbe7
src/tests/master_tests.cpp a6d1a4aaaaa5b7d50a88e5b101c43f62d21300cf
src/tests/monitor_tests.cpp 4b950e14bd94cdfa21212268b56bebdc1200078d
Diff: https://reviews.apache.org/r/27447/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 27447: mesos: Replaced the ip and port pairs from
UPID class and process namespace with Node class
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27447/
-----------------------------------------------------------
(Updated Nov. 6, 2014, 2:49 a.m.)
Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
Changes
-------
Last patch failed compilation.
Bugs: MESOS-2019
https://issues.apache.org/jira/browse/MESOS-2019
Repository: mesos-git
Description
-------
At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
Diffs (updated)
-----
src/common/protobuf_utils.cpp 33ce782960e88e07b910f844fbdcae4c0f19d9a7
src/master/master.cpp a860496d9d75ae4e007d35627d778caf10d08428
src/sched/sched.cpp e5f828d0bf9dd03a01920634abfae685a7861b44
src/scheduler/scheduler.cpp c74187cfeb57a748fd57198d3badd4b8773490eb
src/slave/http.cpp 965d78c3e3ea2e3c922f62aabf6fc87c5cf2ab8d
src/slave/slave.cpp dbfd1a8101d78dee8ea3ac19d990a6a7892e59be
src/tests/fetcher_tests.cpp e026e875c7197cd214ef0432d7c40207553c8671
src/tests/files_tests.cpp a696aa22d56b37ee70c6e64c81a849da6d436451
src/tests/gc_tests.cpp f7747e2999cbd64ab0cd0321cca0021489dc3346
src/tests/logging_tests.cpp 58e9b3399c3de28b1c5b3a8ec8fdf85b7a31c6d5
src/tests/master_contender_detector_tests.cpp 8f7fb18f0ca985364565fc4cd50f113b1461fbe7
src/tests/master_tests.cpp a6d1a4aaaaa5b7d50a88e5b101c43f62d21300cf
src/tests/monitor_tests.cpp 4b950e14bd94cdfa21212268b56bebdc1200078d
Diff: https://reviews.apache.org/r/27447/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 27447: mesos: Replaced the ip and port pairs from
UPID class and process namespace with Node class
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27447/
-----------------------------------------------------------
(Updated Nov. 6, 2014, 2:44 a.m.)
Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
Summary (updated)
-----------------
mesos: Replaced the ip and port pairs from UPID class and process namespace with Node class
Bugs: MESOS-2019
https://issues.apache.org/jira/browse/MESOS-2019
Repository: mesos-git
Description
-------
At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
Diffs (updated)
-----
src/common/protobuf_utils.cpp 33ce782960e88e07b910f844fbdcae4c0f19d9a7
src/master/master.cpp a860496d9d75ae4e007d35627d778caf10d08428
src/sched/sched.cpp e5f828d0bf9dd03a01920634abfae685a7861b44
src/scheduler/scheduler.cpp c74187cfeb57a748fd57198d3badd4b8773490eb
src/slave/http.cpp 965d78c3e3ea2e3c922f62aabf6fc87c5cf2ab8d
src/slave/slave.cpp dbfd1a8101d78dee8ea3ac19d990a6a7892e59be
src/tests/fetcher_tests.cpp e026e875c7197cd214ef0432d7c40207553c8671
src/tests/files_tests.cpp a696aa22d56b37ee70c6e64c81a849da6d436451
src/tests/gc_tests.cpp f7747e2999cbd64ab0cd0321cca0021489dc3346
src/tests/logging_tests.cpp 58e9b3399c3de28b1c5b3a8ec8fdf85b7a31c6d5
src/tests/master_contender_detector_tests.cpp 8f7fb18f0ca985364565fc4cd50f113b1461fbe7
src/tests/master_tests.cpp a6d1a4aaaaa5b7d50a88e5b101c43f62d21300cf
src/tests/monitor_tests.cpp 4b950e14bd94cdfa21212268b56bebdc1200078d
Diff: https://reviews.apache.org/r/27447/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 27447: mesos: Renamed the Node class in Endpoint
and
replaced the ip and port pairs from UPID class and process namespace with
this concept
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27447/
-----------------------------------------------------------
(Updated Nov. 6, 2014, 1:23 a.m.)
Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'.
Changes
-------
Switched back from Endpoint to Node
Summary (updated)
-----------------
mesos: Renamed the Node class in Endpoint and replaced the ip and port pairs from UPID class and process namespace with this concept
Bugs: MESOS-2019
https://issues.apache.org/jira/browse/MESOS-2019
Repository: mesos-git
Description (updated)
-------
At the moment, the Node class is used to keep a mapping from a socket to the ip & port pair in the process namespace.
I want to propose to extend its use by replacing the ip & port fields from the UPID class and process namespace with this type.
Diffs (updated)
-----
src/common/protobuf_utils.cpp 33ce782960e88e07b910f844fbdcae4c0f19d9a7
src/master/master.cpp a860496d9d75ae4e007d35627d778caf10d08428
src/sched/sched.cpp e5f828d0bf9dd03a01920634abfae685a7861b44
src/scheduler/scheduler.cpp c74187cfeb57a748fd57198d3badd4b8773490eb
src/slave/http.cpp 965d78c3e3ea2e3c922f62aabf6fc87c5cf2ab8d
src/slave/slave.cpp dbfd1a8101d78dee8ea3ac19d990a6a7892e59be
src/tests/files_tests.cpp a696aa22d56b37ee70c6e64c81a849da6d436451
src/tests/gc_tests.cpp f7747e2999cbd64ab0cd0321cca0021489dc3346
src/tests/logging_tests.cpp 58e9b3399c3de28b1c5b3a8ec8fdf85b7a31c6d5
src/tests/master_contender_detector_tests.cpp 8f7fb18f0ca985364565fc4cd50f113b1461fbe7
src/tests/master_tests.cpp a6d1a4aaaaa5b7d50a88e5b101c43f62d21300cf
src/tests/monitor_tests.cpp 4b950e14bd94cdfa21212268b56bebdc1200078d
Diff: https://reviews.apache.org/r/27447/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu