[GitHub] [iceberg] manuzhang commented on a diff in pull request #8195: Flink 1.17: Support specifying equality columns with write options

["manuzhang (via GitHub)" <gi...@apache.org>]

manuzhang commented on code in PR #8195:
URL: https://github.com/apache/iceberg/pull/8195#discussion_r1304045323


##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java:
##########
@@ -379,12 +381,11 @@ private String operatorName(String suffix) {
     }
 
     @VisibleForTesting
-    List<Integer> checkAndGetEqualityFieldIds() {
+    List<Integer> checkAndGetEqualityFieldIds(List<String> equalityColumns) {

Review Comment:
   It's for testing. Please check the changes in `[TestFlinkIcebergSinkV2.java](https://github.com/apache/iceberg/pull/8195/files#diff-560cafe3f640ca5cdff37ff1af2fe15d7e87dd644ca2669bf742c2999628bd5d)`



##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java:
##########
@@ -379,12 +381,11 @@ private String operatorName(String suffix) {
     }
 
     @VisibleForTesting
-    List<Integer> checkAndGetEqualityFieldIds() {
+    List<Integer> checkAndGetEqualityFieldIds(List<String> equalityColumns) {

Review Comment:
   It's for testing. Please check the changes in [TestFlinkIcebergSinkV2.java](https://github.com/apache/iceberg/pull/8195/files#diff-560cafe3f640ca5cdff37ff1af2fe15d7e87dd644ca2669bf742c2999628bd5d)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org