You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/11/26 15:04:03 UTC
(commons-logging) branch master updated (ed83294 -> b7bca0f)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-logging.git
from ed83294 Set java.logging as optional module #183.
new d3c1bb9 Remove duplicate
new 98a23a7 Use varargs
new b7bca0f Remove trailing whitespace
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
checkstyle.xml | 7 -------
src/main/java/org/apache/commons/logging/LogSource.java | 4 ++--
.../commons/logging/config/FirstPriorityConfigTestCase.java | 4 ++--
.../apache/commons/logging/config/PriorityConfigTestCase.java | 4 ++--
.../org/apache/commons/logging/jdk14/CustomConfigTestCase.java | 10 +++++-----
.../org/apache/commons/logging/log4j/log4j12/TestAppender.java | 4 ++--
.../org/apache/commons/logging/logkit/StandardTestCase.java | 8 ++++----
.../java/org/apache/commons/logging/noop/NoOpLogTestCase.java | 2 +-
.../commons/logging/simple/DateTimeCustomConfigTestCase.java | 4 ++--
.../org/apache/commons/logging/simple/DecoratedSimpleLog.java | 8 ++++----
.../apache/commons/logging/tccl/log/TcclDisabledTestCase.java | 4 ++--
.../apache/commons/logging/tccl/log/TcclEnabledTestCase.java | 4 ++--
.../commons/logging/tccl/logfactory/TcclDisabledTestCase.java | 4 ++--
.../commons/logging/tccl/logfactory/TcclEnabledTestCase.java | 4 ++--
14 files changed, 32 insertions(+), 39 deletions(-)
(commons-logging) 02/03: Use varargs
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-logging.git
commit 98a23a79802034c1fa3c32d488daea353d1e23dc
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Nov 26 10:03:51 2023 -0500
Use varargs
---
src/main/java/org/apache/commons/logging/LogSource.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/main/java/org/apache/commons/logging/LogSource.java b/src/main/java/org/apache/commons/logging/LogSource.java
index e194a0d..17d1e25 100644
--- a/src/main/java/org/apache/commons/logging/LogSource.java
+++ b/src/main/java/org/apache/commons/logging/LogSource.java
@@ -206,7 +206,7 @@ public class LogSource {
*/
static public void setLogImplementation(final Class<?> logClass)
throws LinkageError, ExceptionInInitializerError, NoSuchMethodException, SecurityException {
- logImplctor = logClass.getConstructor(new Class<?>[] { String.class });
+ logImplctor = logClass.getConstructor(String.class);
}
/**
@@ -222,7 +222,7 @@ public class LogSource {
static public void setLogImplementation(final String className) throws LinkageError, SecurityException {
try {
final Class<?> logClass = Class.forName(className);
- logImplctor = logClass.getConstructor(new Class<?>[] { String.class });
+ logImplctor = logClass.getConstructor(String.class);
} catch (final Throwable t) {
logImplctor = null;
}
(commons-logging) 03/03: Remove trailing whitespace
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-logging.git
commit b7bca0f8cc49f9fc3a848864cc3ddd81abf8ec71
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Nov 26 10:03:58 2023 -0500
Remove trailing whitespace
---
.../commons/logging/config/FirstPriorityConfigTestCase.java | 4 ++--
.../apache/commons/logging/config/PriorityConfigTestCase.java | 4 ++--
.../org/apache/commons/logging/jdk14/CustomConfigTestCase.java | 10 +++++-----
.../org/apache/commons/logging/log4j/log4j12/TestAppender.java | 4 ++--
.../org/apache/commons/logging/logkit/StandardTestCase.java | 8 ++++----
.../java/org/apache/commons/logging/noop/NoOpLogTestCase.java | 2 +-
.../commons/logging/simple/DateTimeCustomConfigTestCase.java | 4 ++--
.../org/apache/commons/logging/simple/DecoratedSimpleLog.java | 8 ++++----
.../apache/commons/logging/tccl/log/TcclDisabledTestCase.java | 4 ++--
.../apache/commons/logging/tccl/log/TcclEnabledTestCase.java | 4 ++--
.../commons/logging/tccl/logfactory/TcclDisabledTestCase.java | 4 ++--
.../commons/logging/tccl/logfactory/TcclEnabledTestCase.java | 4 ++--
12 files changed, 30 insertions(+), 30 deletions(-)
diff --git a/src/test/java/org/apache/commons/logging/config/FirstPriorityConfigTestCase.java b/src/test/java/org/apache/commons/logging/config/FirstPriorityConfigTestCase.java
index e7ce08d..64eb551 100644
--- a/src/test/java/org/apache/commons/logging/config/FirstPriorityConfigTestCase.java
+++ b/src/test/java/org/apache/commons/logging/config/FirstPriorityConfigTestCase.java
@@ -41,7 +41,7 @@ import junit.framework.TestCase;
*/
public class FirstPriorityConfigTestCase extends TestCase {
-
+
/**
* Return the tests included in this test suite.
@@ -99,7 +99,7 @@ public class FirstPriorityConfigTestCase extends TestCase {
LogFactory.releaseAll();
}
-
+
/**
* Verify that the config file being used is the one containing
* the desired configId value.
diff --git a/src/test/java/org/apache/commons/logging/config/PriorityConfigTestCase.java b/src/test/java/org/apache/commons/logging/config/PriorityConfigTestCase.java
index c35ece8..659096f 100644
--- a/src/test/java/org/apache/commons/logging/config/PriorityConfigTestCase.java
+++ b/src/test/java/org/apache/commons/logging/config/PriorityConfigTestCase.java
@@ -48,7 +48,7 @@ import junit.framework.TestCase;
public class PriorityConfigTestCase extends TestCase {
-
+
/**
* Return the tests included in this test suite.
@@ -117,7 +117,7 @@ public class PriorityConfigTestCase extends TestCase {
LogFactory.releaseAll();
}
-
+
/**
* Verify that the config file being used is the one containing
* the desired configId value.
diff --git a/src/test/java/org/apache/commons/logging/jdk14/CustomConfigTestCase.java b/src/test/java/org/apache/commons/logging/jdk14/CustomConfigTestCase.java
index 8457aa5..32c7abb 100644
--- a/src/test/java/org/apache/commons/logging/jdk14/CustomConfigTestCase.java
+++ b/src/test/java/org/apache/commons/logging/jdk14/CustomConfigTestCase.java
@@ -45,7 +45,7 @@ public class CustomConfigTestCase extends DefaultConfigTestCase {
protected static final String HANDLER_NAME = "org.apache.commons.logging.jdk14.TestHandler";
-
+
/**
* Make a class available in the system class loader even when its classfile is
@@ -83,7 +83,7 @@ public class CustomConfigTestCase extends DefaultConfigTestCase {
}
-
+
/**
* Given the name of a class that is somewhere in the classpath of the provided
@@ -155,7 +155,7 @@ public class CustomConfigTestCase extends DefaultConfigTestCase {
protected LogManager manager;
-
+
/**
* <p>The message levels that should have been logged.</p>
@@ -234,7 +234,7 @@ public class CustomConfigTestCase extends DefaultConfigTestCase {
}
-
+
// Log the messages with exceptions
protected void logExceptionMessages() {
@@ -307,7 +307,7 @@ public class CustomConfigTestCase extends DefaultConfigTestCase {
}
-
+
// Set up LogManager instance
protected void setUpManager(final String config) throws Exception {
diff --git a/src/test/java/org/apache/commons/logging/log4j/log4j12/TestAppender.java b/src/test/java/org/apache/commons/logging/log4j/log4j12/TestAppender.java
index 4a9ac63..90e6cad 100644
--- a/src/test/java/org/apache/commons/logging/log4j/log4j12/TestAppender.java
+++ b/src/test/java/org/apache/commons/logging/log4j/log4j12/TestAppender.java
@@ -36,7 +36,7 @@ public class TestAppender extends AppenderSkeleton {
// The set of logged events for this appender
private final List events;
-
+
/**
* Constructor.
@@ -46,7 +46,7 @@ public class TestAppender extends AppenderSkeleton {
}
-
+
@Override
protected void append(final LoggingEvent event) {
final StandardTests.LogEvent lev = new StandardTests.LogEvent();
diff --git a/src/test/java/org/apache/commons/logging/logkit/StandardTestCase.java b/src/test/java/org/apache/commons/logging/logkit/StandardTestCase.java
index 1000a71..f1c8969 100644
--- a/src/test/java/org/apache/commons/logging/logkit/StandardTestCase.java
+++ b/src/test/java/org/apache/commons/logging/logkit/StandardTestCase.java
@@ -39,7 +39,7 @@ import junit.framework.Test;
public class StandardTestCase extends AbstractLogTest {
-
+
/**
* Return the tests included in this test suite.
@@ -64,7 +64,7 @@ public class StandardTestCase extends AbstractLogTest {
protected LogFactory factory;
-
+
/**
* <p>The {@link Log} implementation we have selected.</p>
@@ -99,7 +99,7 @@ public class StandardTestCase extends AbstractLogTest {
return new LogKitLogger(this.getClass().getName());
}
-
+
/**
* Sets up instance variables required by this test case.
*/
@@ -144,7 +144,7 @@ public class StandardTestCase extends AbstractLogTest {
}
-
+
// Test Serializability of standard instance
public void testSerializable() throws Exception {
checkStandard();
diff --git a/src/test/java/org/apache/commons/logging/noop/NoOpLogTestCase.java b/src/test/java/org/apache/commons/logging/noop/NoOpLogTestCase.java
index 033b60f..ca835a6 100644
--- a/src/test/java/org/apache/commons/logging/noop/NoOpLogTestCase.java
+++ b/src/test/java/org/apache/commons/logging/noop/NoOpLogTestCase.java
@@ -82,7 +82,7 @@ public class NoOpLogTestCase extends AbstractLogTest {
}
-
+
// Test Serializability of standard instance
public void testSerializable() throws Exception {
Log log = LogFactory.getLog(this.getClass().getName());
diff --git a/src/test/java/org/apache/commons/logging/simple/DateTimeCustomConfigTestCase.java b/src/test/java/org/apache/commons/logging/simple/DateTimeCustomConfigTestCase.java
index 6c880e7..df94b57 100644
--- a/src/test/java/org/apache/commons/logging/simple/DateTimeCustomConfigTestCase.java
+++ b/src/test/java/org/apache/commons/logging/simple/DateTimeCustomConfigTestCase.java
@@ -32,7 +32,7 @@ import junit.framework.Test;
*/
public class DateTimeCustomConfigTestCase extends CustomConfigTestCase {
-
+
/**
* Return the tests included in this test suite.
* <p>
@@ -78,7 +78,7 @@ public class DateTimeCustomConfigTestCase extends CustomConfigTestCase {
}
-
+
/**
* Sets up system properties required by this unit test. Here, we
* set up the props defined in the parent class setProperties method,
diff --git a/src/test/java/org/apache/commons/logging/simple/DecoratedSimpleLog.java b/src/test/java/org/apache/commons/logging/simple/DecoratedSimpleLog.java
index ef33552..2f59138 100644
--- a/src/test/java/org/apache/commons/logging/simple/DecoratedSimpleLog.java
+++ b/src/test/java/org/apache/commons/logging/simple/DecoratedSimpleLog.java
@@ -33,7 +33,7 @@ import org.apache.commons.logging.impl.SimpleLog;
public class DecoratedSimpleLog extends SimpleLog {
-
+
/**
* Generated serial version ID.
@@ -44,7 +44,7 @@ public class DecoratedSimpleLog extends SimpleLog {
protected ArrayList cache = new ArrayList();
-
+
public DecoratedSimpleLog(final String name) {
super(name);
}
@@ -72,14 +72,14 @@ public class DecoratedSimpleLog extends SimpleLog {
}
-
+
public String getLogName() {
return logName;
}
-
+
public boolean getShowDateTime() {
return showDateTime;
diff --git a/src/test/java/org/apache/commons/logging/tccl/log/TcclDisabledTestCase.java b/src/test/java/org/apache/commons/logging/tccl/log/TcclDisabledTestCase.java
index 4ac197c..b34d966 100644
--- a/src/test/java/org/apache/commons/logging/tccl/log/TcclDisabledTestCase.java
+++ b/src/test/java/org/apache/commons/logging/tccl/log/TcclDisabledTestCase.java
@@ -42,7 +42,7 @@ public class TcclDisabledTestCase extends TestCase {
public static final String MY_LOG_IMPL =
MY_LOG_PKG + ".MyLog";
-
+
/**
* Return the tests included in this test suite.
*/
@@ -103,7 +103,7 @@ public class TcclDisabledTestCase extends TestCase {
LogFactory.releaseAll();
}
-
+
/**
* Verify that MyLog is only loadable via the tccl.
*/
diff --git a/src/test/java/org/apache/commons/logging/tccl/log/TcclEnabledTestCase.java b/src/test/java/org/apache/commons/logging/tccl/log/TcclEnabledTestCase.java
index 17f7628..9f1fc57 100644
--- a/src/test/java/org/apache/commons/logging/tccl/log/TcclEnabledTestCase.java
+++ b/src/test/java/org/apache/commons/logging/tccl/log/TcclEnabledTestCase.java
@@ -42,7 +42,7 @@ public class TcclEnabledTestCase extends TestCase {
public static final String MY_LOG_IMPL =
MY_LOG_PKG + ".MyLog";
-
+
/**
* Return the tests included in this test suite.
*/
@@ -103,7 +103,7 @@ public class TcclEnabledTestCase extends TestCase {
LogFactory.releaseAll();
}
-
+
/**
* Verify that MyLogFactoryImpl is only loadable via the tccl.
*/
diff --git a/src/test/java/org/apache/commons/logging/tccl/logfactory/TcclDisabledTestCase.java b/src/test/java/org/apache/commons/logging/tccl/logfactory/TcclDisabledTestCase.java
index 2ca5037..aa35d18 100644
--- a/src/test/java/org/apache/commons/logging/tccl/logfactory/TcclDisabledTestCase.java
+++ b/src/test/java/org/apache/commons/logging/tccl/logfactory/TcclDisabledTestCase.java
@@ -41,7 +41,7 @@ public class TcclDisabledTestCase extends TestCase {
public static final String MY_LOG_FACTORY_IMPL =
MY_LOG_FACTORY_PKG + ".MyLogFactoryImpl";
-
+
/**
* Return the tests included in this test suite.
@@ -105,7 +105,7 @@ public class TcclDisabledTestCase extends TestCase {
LogFactory.releaseAll();
}
-
+
/**
* Verify that MyLogFactoryImpl is only loadable via the tccl.
*/
diff --git a/src/test/java/org/apache/commons/logging/tccl/logfactory/TcclEnabledTestCase.java b/src/test/java/org/apache/commons/logging/tccl/logfactory/TcclEnabledTestCase.java
index 7d29d1c..05f15e4 100644
--- a/src/test/java/org/apache/commons/logging/tccl/logfactory/TcclEnabledTestCase.java
+++ b/src/test/java/org/apache/commons/logging/tccl/logfactory/TcclEnabledTestCase.java
@@ -35,7 +35,7 @@ import junit.framework.TestCase;
public class TcclEnabledTestCase extends TestCase {
-
+
/**
* Return the tests included in this test suite.
@@ -99,7 +99,7 @@ public class TcclEnabledTestCase extends TestCase {
LogFactory.releaseAll();
}
-
+
/**
* Verify that MyLogFactoryImpl is only loadable via the tccl.
*/
(commons-logging) 01/03: Remove duplicate
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-logging.git
commit d3c1bb95b9faedc3a560627aaf26ef49bfa1deb0
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Nov 26 10:01:54 2023 -0500
Remove duplicate
---
checkstyle.xml | 7 -------
1 file changed, 7 deletions(-)
diff --git a/checkstyle.xml b/checkstyle.xml
index 8618ab9..0b20a08 100644
--- a/checkstyle.xml
+++ b/checkstyle.xml
@@ -73,11 +73,4 @@ limitations under the License.
</module>
<module name="WhitespaceAfter" />
</module>
- <!-- @author tags are deprecated -->
- <module name="RegexpSingleline">
- <property name="format" value="^\s+\*\s+@author\s" />
- <property name="message" value="Deprecated @author tag" />
- <property name="fileExtensions" value="java" />
- <property name="severity" value="warning" />
- </module>
</module>