[GitHub] [solr] gerlowskija edited a comment on pull request #495: SOLR-15116: Support a HEAD request for managed resources

[GitBox <gi...@apache.org>]

gerlowskija edited a comment on pull request #495:
URL: https://github.com/apache/solr/pull/495#issuecomment-1016513198


   > As far as my use case is concerned, the status code is what really matters to me. You could consider "all HEAD requests should respond with the correct Content-Length" as a separate issue
   
   If we don't have bandwidth to chase down a better solution, then this sounds like a reasonable compromise to me.  It's not perfect but it moves us in the right direction.  I'd hate to see this contribution stall by letting the perfect get in the way of the good.  If we can get a test working, I wouldn't have any qualms about merging this.
   
   ---
   
   That said, if I was trying to fix this from scratch, I'd look higher up in the call stack.  The reporter ran into problems with synonyms/stopwords specifically, sure.  But Solr's handling of HEAD requests likely has similar issues across the board.  At a glance, `/select` and `/update` both have the same problem.  
   
   Could we find whatever `HttpServlet` implementation Solr is using and add a `doHead` method there, to handle this uniformly for all APIs?  Or alternately, could we find the specific code that zero's out the `Content-Length` and amend that to be http-method-aware?
   
   Conceptually my point I guess is that it feels like we're applying a narrow solution to a pretty broad problem.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org