You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/05/09 13:14:36 UTC
[GitHub] [incubator-seatunnel] legendtkl opened a new pull request, #1836: [Improve][UT] add ut for Flink SQL module
legendtkl opened a new pull request, #1836:
URL: https://github.com/apache/incubator-seatunnel/pull/1836
## Purpose of this pull request
1. Add UT for Flink SQL module
2. some code refactor
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on a diff in pull request #1836: [Improve][UT] add ut for Flink SQL module
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #1836:
URL: https://github.com/apache/incubator-seatunnel/pull/1836#discussion_r868749525
##########
seatunnel-core/seatunnel-core-flink-sql/src/main/java/org/apache/seatunnel/core/sql/job/Executor.java:
##########
@@ -79,7 +80,8 @@ private static StatementSet handleStatements(String workFlowContent, StreamTable
return statementSet;
}
- private static Optional<String[]> setOperationParse(String stmt) {
+ @VisibleForTesting
+ static Optional<String[]> parseSetOperation(String stmt) {
Review Comment:
```suggestion
static Optional<Pair<String, String>> parseSetOperation(String stmt) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on a diff in pull request #1836: [Improve][UT] add ut for Flink SQL module
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #1836:
URL: https://github.com/apache/incubator-seatunnel/pull/1836#discussion_r868749525
##########
seatunnel-core/seatunnel-core-flink-sql/src/main/java/org/apache/seatunnel/core/sql/job/Executor.java:
##########
@@ -79,7 +80,8 @@ private static StatementSet handleStatements(String workFlowContent, StreamTable
return statementSet;
}
- private static Optional<String[]> setOperationParse(String stmt) {
+ @VisibleForTesting
+ static Optional<String[]> parseSetOperation(String stmt) {
Review Comment:
```suggestion
static Pair<String, String> parseSetOperation(String stmt) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun merged pull request #1836: [Improve][UT] add ut for Flink SQL module
Posted by GitBox <gi...@apache.org>.
ruanwenjun merged PR #1836:
URL: https://github.com/apache/incubator-seatunnel/pull/1836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org