You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "ZhangNing10 (via GitHub)" <gi...@apache.org> on 2023/06/27 07:47:48 UTC

[GitHub] [incubator-devlake] ZhangNing10 opened a new pull request, #5583: Zhangning/ds 176 make lake to run with nonroot user

ZhangNing10 opened a new pull request, #5583:
URL: https://github.com/apache/incubator-devlake/pull/5583

   ### ⚠️ Pre Checklist
   
   > Please complete _ALL_ items in this checklist, and remove before submitting
   
   - [ ] I have read through the [Contributing Documentation](https://devlake.apache.org/community/).
   - [ ] I have added relevant tests.
   - [ ] I have added relevant documentation.
   - [ ] I will add labels to the PR, such as `pr-type/bug-fix`, `pr-type/feature-development`, etc.
   
   <!--
   Thanks for submitting a pull request!
   
   We appreciate you spending the time to work on these changes.
   Please fill out as many sections below as possible.
   -->
   
   ### Summary
   Make devlake to run as nonroot user
   ### Does this close any open issues?
   Closes https://github.com/apache/incubator-devlake/issues/5128
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] keon94 commented on pull request #5583: feat: make lake run with non-root users

Posted by "keon94 (via GitHub)" <gi...@apache.org>.
keon94 commented on PR #5583:
URL: https://github.com/apache/incubator-devlake/pull/5583#issuecomment-1619101845

   server starts fine but there's a log permissions issue:
   ![image](https://github.com/apache/incubator-devlake/assets/25063936/f052f21b-8801-465e-98c6-710860d8790e)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] keon94 commented on pull request #5583: feat: make lake run with non-root users

Posted by "keon94 (via GitHub)" <gi...@apache.org>.
keon94 commented on PR #5583:
URL: https://github.com/apache/incubator-devlake/pull/5583#issuecomment-1623138634

   @klesh No luck, same error. It looks like this [line](https://github.com/apache/incubator-devlake/blame/55e6835f87a752d1a182350fb0b1a6c34ff41c5f/backend/impls/logruslog/stream.go#L31) keeps creating a logs/ directory with 0755 permissions even though `os.ModePerm` is supposed to be an alias for 0777. 
   ![image](https://github.com/apache/incubator-devlake/assets/25063936/3dadec38-3990-4224-b5d4-23a5de237f8a)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] IronCore864 commented on pull request #5583: feat: make lake run with non-root users

Posted by "IronCore864 (via GitHub)" <gi...@apache.org>.
IronCore864 commented on PR #5583:
URL: https://github.com/apache/incubator-devlake/pull/5583#issuecomment-1616585765

   @klesh please have a review. Run as non-root.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] klesh commented on pull request #5583: feat: make lake run with non-root users

Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on PR #5583:
URL: https://github.com/apache/incubator-devlake/pull/5583#issuecomment-1639692101

   @ZhangNing10 @IronCore864 please take a look, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] hezyin merged pull request #5583: feat: make lake run with non-root users

Posted by "hezyin (via GitHub)" <gi...@apache.org>.
hezyin merged PR #5583:
URL: https://github.com/apache/incubator-devlake/pull/5583


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] matrixji commented on pull request #5583: feat: make lake run with non-root users

Posted by "matrixji (via GitHub)" <gi...@apache.org>.
matrixji commented on PR #5583:
URL: https://github.com/apache/incubator-devlake/pull/5583#issuecomment-1619525014

   > “Maybe we could set /app owned by devlake user.” => seems it's mandatory right now.
   > 
   > We could export /app/logs as a volume in Dockerfile we need a `RUN mkdir /app/logs` after `USER devlake` and use `VOLUME /app/logs` to export the /app/logs as a volume. After that:
   > 
   > * If the external volume is a named volume, then the owner of  /app/logs will keep devlake.
   > * If the external volume is an anonymous volume (in our case, a local path), the owner of /app/logs will use the host folders, so we could use chown -R 1010:1010 on our dev host.
   > 
   > For the Kubernetes deployment, I think no other changes are needed.
   
   @keon94 @ZhangNing10  could you also help verify it, I just have some simple test on local.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] awickham10 commented on pull request #5583: feat: make lake run with non-root users

Posted by "awickham10 (via GitHub)" <gi...@apache.org>.
awickham10 commented on PR #5583:
URL: https://github.com/apache/incubator-devlake/pull/5583#issuecomment-1638309984

   > As an FYI - I'm not sure this is totally working, unless it's not included in beta 1. I'm wondering if it's due to running under uid 1010. In my case it looks like my user is 1001470000.
   > 
   > Here's an excerpt from my logs.
   > 
   > ```
   > Version:  v0.18.0-beta1@
   > time="2023-07-17 12:58:12" level=warning msg="Failed to create filestream for logs. Logs will not be piped to files.
   > 	caused by: open /app/logs/devlake.log: permission denied
   > 	Wraps: (2) open /app/logs/devlake.log
   > 	Wraps: (3) permission denied
   > 	Error types: (1) *hintdetail.withDetail (2) *fs.PathError (3) syscall.Errno"
   > time="2023-07-17 12:58:12" level=info msg="migration initialized"
   > time="2023-07-17 12:58:12" level=info msg="plugin loaded ae"
   > time="2023-07-17 12:58:12" level=info msg="plugin loaded bamboo"
   > time="2023-07-17 12:58:12" level=info msg="plugin loaded bitbucket"
   > time="2023-07-17 12:58:12" level=info msg="plugin loaded customize"
   > time="2023-07-17 12:58:13" level=info msg="plugin loaded dbt"
   > time="2023-07-17 12:58:13" level=info msg="plugin loaded dora"
   > time="2023-07-17 12:58:13" level=info msg="plugin loaded feishu"
   > time="2023-07-17 12:58:13" level=info msg="plugin loaded gitee"
   > time="2023-07-17 12:58:13" level=info msg="plugin loaded gitextractor"
   > time="2023-07-17 12:58:13" level=info msg="plugin loaded github"
   > time="2023-07-17 12:58:13" level=info msg="plugin loaded github_graphql"
   > time="2023-07-17 12:58:13" level=info msg="plugin loaded gitlab"
   > time="2023-07-17 12:58:13" level=info msg="plugin loaded icla"
   > time="2023-07-17 12:58:13" level=info msg="plugin loaded jenkins"
   > time="2023-07-17 12:58:13" level=info msg="plugin loaded jira"
   > time="2023-07-17 12:58:13" level=info msg="plugin loaded org"
   > time="2023-07-17 12:58:13" level=info msg="plugin loaded pagerduty"
   > time="2023-07-17 12:58:13" level=info msg="plugin loaded refdiff"
   > time="2023-07-17 12:58:13" level=info msg="plugin loaded slack"
   > time="2023-07-17 12:58:13" level=info msg="plugin loaded sonarqube"
   > time="2023-07-17 12:58:14" level=info msg="plugin loaded starrocks"
   > time="2023-07-17 12:58:14" level=info msg="plugin loaded tapd"
   > time="2023-07-17 12:58:14" level=info msg="plugin loaded teambition"
   > time="2023-07-17 12:58:14" level=info msg="plugin loaded trello"
   > time="2023-07-17 12:58:14" level=info msg="plugin loaded webhook"
   > time="2023-07-17 12:58:14" level=info msg="plugin loaded zentao"
   > time="2023-07-17 12:58:14" level=info msg="Loading remote plugins"
   > time="2023-07-17 12:58:14" level=error msg="./run.sh: 20: poetry: Permission denied"
   > time="2023-07-17 12:58:14" level=error msg="failed to load plugins
   > 	caused by: Error calling plugin-info
   > 	Wraps: (2) get error when invoking remote function plugin-info
   > 	Wraps: (3) remote error response:
   > 	  | ./run.sh: 20: poetry: Permission denied
   > 	Wraps: (4) exit status 127
   > 	Wraps: (5) exit status 127
   > 	Error types: (1) *hintdetail.withDetail (2) *hintdetail.withDetail (3) *hintdetail.withDetail (4) *hintdetail.withDetail (5) *exec.ExitError"
   > panic: Error calling plugin-info
   > Wraps: (2) get error when invoking remote function plugin-info
   > Wraps: (3) remote error response:
   >   | ./run.sh: 20: poetry: Permission denied
   > Wraps: (4) exit status 127
   > Wraps: (5) exit status 127
   > Error types: (1) *hintdetail.withDetail (2) *hintdetail.withDetail (3) *hintdetail.withDetail (4) *hintdetail.withDetail (5) *exec.ExitError
   > 
   > goroutine 1 [running]:
   > github.com/apache/incubator-devlake/server/services.Init()
   > 	/app/server/services/init.go:90 +0x24d
   > github.com/apache/incubator-devlake/server/api.CreateApiService()
   > 	/app/server/api/api.go:61 +0x3d
   > main.main()
   > 	/app/server/main.go:33 +0x36
   > ```
   
   I was able to get this to work by setting the below in my values.yml.
   
   ```
   lake:
     securityContext:
       runAsUser: 1010
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] ZhangNing10 commented on pull request #5583: feat: make lake run with non-root users

Posted by "ZhangNing10 (via GitHub)" <gi...@apache.org>.
ZhangNing10 commented on PR #5583:
URL: https://github.com/apache/incubator-devlake/pull/5583#issuecomment-1639733569

   @awickham10 devlake can only run with non-root user 1010, do you mean you need to run as another user?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] matrixji commented on a diff in pull request #5583: feat: make lake run with non-root users

Posted by "matrixji (via GitHub)" <gi...@apache.org>.
matrixji commented on code in PR #5583:
URL: https://github.com/apache/incubator-devlake/pull/5583#discussion_r1249612048


##########
backend/Dockerfile:
##########
@@ -132,19 +131,23 @@ RUN apt-get update && \
 
 EXPOSE 8080
 
+RUN useradd -ms /bin/bash devlake -u 1010
+USER devlake
+ENV PYTHONUNBUFFERED=1
+
 WORKDIR /app

Review Comment:
   Maybe we could set /app owned by devlake user.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] matrixji commented on pull request #5583: feat: make lake run with non-root users

Posted by "matrixji (via GitHub)" <gi...@apache.org>.
matrixji commented on PR #5583:
URL: https://github.com/apache/incubator-devlake/pull/5583#issuecomment-1623639641

   > @klesh No luck, same error. It looks like this [line](https://github.com/apache/incubator-devlake/blame/55e6835f87a752d1a182350fb0b1a6c34ff41c5f/backend/impls/logruslog/stream.go#L31) keeps creating a logs/ directory with 0755 permissions even though `os.ModePerm` is supposed to be an alias for 0777. This causes the error on L37 when the log file tries to get made. ![image](https://user-images.githubusercontent.com/25063936/251377587-3dadec38-3990-4224-b5d4-23a5de237f8a.png)
   
   Have U try do the below operation in your local host before starting the containers by docker-compose:
   ```
   chown -R 1010:1010 logs/
   ```
   
   Maybe we use a named volume in docker-compose.yml is easier, but I think developers wants to see logs frequently.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] awickham10 commented on pull request #5583: feat: make lake run with non-root users

Posted by "awickham10 (via GitHub)" <gi...@apache.org>.
awickham10 commented on PR #5583:
URL: https://github.com/apache/incubator-devlake/pull/5583#issuecomment-1638094087

   As an FYI - I'm not sure this is totally working, unless it's not included in beta 1. Here's an excerpt from my logs.
   
   ```
   Version:  v0.18.0-beta1@
   time="2023-07-17 12:58:12" level=warning msg="Failed to create filestream for logs. Logs will not be piped to files.
   	caused by: open /app/logs/devlake.log: permission denied
   	Wraps: (2) open /app/logs/devlake.log
   	Wraps: (3) permission denied
   	Error types: (1) *hintdetail.withDetail (2) *fs.PathError (3) syscall.Errno"
   time="2023-07-17 12:58:12" level=info msg="migration initialized"
   time="2023-07-17 12:58:12" level=info msg="plugin loaded ae"
   time="2023-07-17 12:58:12" level=info msg="plugin loaded bamboo"
   time="2023-07-17 12:58:12" level=info msg="plugin loaded bitbucket"
   time="2023-07-17 12:58:12" level=info msg="plugin loaded customize"
   time="2023-07-17 12:58:13" level=info msg="plugin loaded dbt"
   time="2023-07-17 12:58:13" level=info msg="plugin loaded dora"
   time="2023-07-17 12:58:13" level=info msg="plugin loaded feishu"
   time="2023-07-17 12:58:13" level=info msg="plugin loaded gitee"
   time="2023-07-17 12:58:13" level=info msg="plugin loaded gitextractor"
   time="2023-07-17 12:58:13" level=info msg="plugin loaded github"
   time="2023-07-17 12:58:13" level=info msg="plugin loaded github_graphql"
   time="2023-07-17 12:58:13" level=info msg="plugin loaded gitlab"
   time="2023-07-17 12:58:13" level=info msg="plugin loaded icla"
   time="2023-07-17 12:58:13" level=info msg="plugin loaded jenkins"
   time="2023-07-17 12:58:13" level=info msg="plugin loaded jira"
   time="2023-07-17 12:58:13" level=info msg="plugin loaded org"
   time="2023-07-17 12:58:13" level=info msg="plugin loaded pagerduty"
   time="2023-07-17 12:58:13" level=info msg="plugin loaded refdiff"
   time="2023-07-17 12:58:13" level=info msg="plugin loaded slack"
   time="2023-07-17 12:58:13" level=info msg="plugin loaded sonarqube"
   time="2023-07-17 12:58:14" level=info msg="plugin loaded starrocks"
   time="2023-07-17 12:58:14" level=info msg="plugin loaded tapd"
   time="2023-07-17 12:58:14" level=info msg="plugin loaded teambition"
   time="2023-07-17 12:58:14" level=info msg="plugin loaded trello"
   time="2023-07-17 12:58:14" level=info msg="plugin loaded webhook"
   time="2023-07-17 12:58:14" level=info msg="plugin loaded zentao"
   time="2023-07-17 12:58:14" level=info msg="Loading remote plugins"
   time="2023-07-17 12:58:14" level=error msg="./run.sh: 20: poetry: Permission denied"
   time="2023-07-17 12:58:14" level=error msg="failed to load plugins
   	caused by: Error calling plugin-info
   	Wraps: (2) get error when invoking remote function plugin-info
   	Wraps: (3) remote error response:
   	  | ./run.sh: 20: poetry: Permission denied
   	Wraps: (4) exit status 127
   	Wraps: (5) exit status 127
   	Error types: (1) *hintdetail.withDetail (2) *hintdetail.withDetail (3) *hintdetail.withDetail (4) *hintdetail.withDetail (5) *exec.ExitError"
   panic: Error calling plugin-info
   Wraps: (2) get error when invoking remote function plugin-info
   Wraps: (3) remote error response:
     | ./run.sh: 20: poetry: Permission denied
   Wraps: (4) exit status 127
   Wraps: (5) exit status 127
   Error types: (1) *hintdetail.withDetail (2) *hintdetail.withDetail (3) *hintdetail.withDetail (4) *hintdetail.withDetail (5) *exec.ExitError
   
   goroutine 1 [running]:
   github.com/apache/incubator-devlake/server/services.Init()
   	/app/server/services/init.go:90 +0x24d
   github.com/apache/incubator-devlake/server/api.CreateApiService()
   	/app/server/api/api.go:61 +0x3d
   main.main()
   	/app/server/main.go:33 +0x36
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] ZhangNing10 commented on pull request #5583: Zhangning/ds 176 make lake to run with nonroot user

Posted by "ZhangNing10 (via GitHub)" <gi...@apache.org>.
ZhangNing10 commented on PR #5583:
URL: https://github.com/apache/incubator-devlake/pull/5583#issuecomment-1609027147

   @JorgeGar  @matrixji @keon94 @IronCore864 could you help review the pr? Thanks a ton!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] awickham10 commented on pull request #5583: feat: make lake run with non-root users

Posted by "awickham10 (via GitHub)" <gi...@apache.org>.
awickham10 commented on PR #5583:
URL: https://github.com/apache/incubator-devlake/pull/5583#issuecomment-1640065680

   > hi @awickham10 devlake can only run with non-root user 1010, do you mean you need to run as another user?
   
   I did manage to get it to run as 1010. Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] klesh commented on pull request #5583: feat: make lake run with non-root users

Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on PR #5583:
URL: https://github.com/apache/incubator-devlake/pull/5583#issuecomment-1617136503

   @keon94 @CamilleTeruel  Please take a look at this, would it affect the python plugin?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] klesh commented on pull request #5583: feat: make lake run with non-root users

Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on PR #5583:
URL: https://github.com/apache/incubator-devlake/pull/5583#issuecomment-1623106712

   @keon94 Hi, can you help verify if it is working now?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] ZhangNing10 commented on pull request #5583: feat: make lake run with non-root users

Posted by "ZhangNing10 (via GitHub)" <gi...@apache.org>.
ZhangNing10 commented on PR #5583:
URL: https://github.com/apache/incubator-devlake/pull/5583#issuecomment-1622078941

   Thanks for the reviews, bros! @matrixji Thanks for your considerate suggestions, it looks very good! And I have adjusted accordingly, could you check again?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] matrixji closed pull request #5583: feat: make lake run with non-root users

Posted by "matrixji (via GitHub)" <gi...@apache.org>.
matrixji closed pull request #5583: feat: make lake run with non-root users
URL: https://github.com/apache/incubator-devlake/pull/5583


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] Feggah commented on pull request #5583: feat: make lake run with non-root users

Posted by "Feggah (via GitHub)" <gi...@apache.org>.
Feggah commented on PR #5583:
URL: https://github.com/apache/incubator-devlake/pull/5583#issuecomment-1660929325

   @ZhangNing10 How should I install DevLake with docker-compose to work around this error?
   
   When I run docker-compose, the `logs` directory is created with `root` being the owner:
   ![image](https://github.com/apache/incubator-devlake/assets/11353912/10c87f2e-0a57-4a3f-8094-cded252cc7ff)
   
   How can I specify in docker-compose to create the `logs` dir with `1010` as owner?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] IronCore864 commented on a diff in pull request #5583: feat: make lake run with non-root users

Posted by "IronCore864 (via GitHub)" <gi...@apache.org>.
IronCore864 commented on code in PR #5583:
URL: https://github.com/apache/incubator-devlake/pull/5583#discussion_r1249419015


##########
backend/Dockerfile:
##########
@@ -132,19 +131,23 @@ RUN apt-get update && \
 
 EXPOSE 8080
 
+RUN useradd -ms /bin/bash devlake -u 1010
+USER devlake
+ENV PYTHONUNBUFFERED=1
+
 WORKDIR /app
 # Setup Python
 COPY python/ /app/python/
 RUN python3 -m pip install --no-cache --upgrade pip setuptools && \
-    python3 -m pip install --no-cache -r python/requirements.txt && \
-    rm -fr /usr/share/python-wheels/*
+    python3 -m pip install --no-cache -r python/requirements.txt
+
 # Setup Python Poetry package manager
 RUN curl -sSL https://install.python-poetry.org | python3 -
-RUN ln -sf /root/.local/bin/poetry /usr/local/bin
-# Build Python plugins
-RUN find /app/python/ -name "*.sh" | xargs -I{} chmod +x {}
-RUN /app/python/build.sh
+ENV PATH="$PATH:/home/devlake/.local/bin"
 
+# Build Python plugins, make sure the scripts has execute permission
+#RUN find /app/python/ -name "*.sh" | xargs -I{} chmod +x {}

Review Comment:
   missing space here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] matrixji commented on pull request #5583: feat: make lake run with non-root users

Posted by "matrixji (via GitHub)" <gi...@apache.org>.
matrixji commented on PR #5583:
URL: https://github.com/apache/incubator-devlake/pull/5583#issuecomment-1619311766

   “Maybe we could set /app owned by devlake user.” => seems it's mandatory right now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] matrixji commented on pull request #5583: feat: make lake run with non-root users

Posted by "matrixji (via GitHub)" <gi...@apache.org>.
matrixji commented on PR #5583:
URL: https://github.com/apache/incubator-devlake/pull/5583#issuecomment-1623635923

   > * chown -R 1010:1010
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] keon94 commented on pull request #5583: feat: make lake run with non-root users

Posted by "keon94 (via GitHub)" <gi...@apache.org>.
keon94 commented on PR #5583:
URL: https://github.com/apache/incubator-devlake/pull/5583#issuecomment-1624391409

   @matrixji Yeah, turned out to be permission issue on my local logs directory. Just deleting it and letting docker-compose create a new one was sufficient. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org