You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Toshiaki Hatano <to...@verio.net> on 2013/07/31 00:18:07 UTC
Review Request 13088: CLOUDSTACK-3959: [KVM] agent setup failed when
physical interface name is in pXpY format
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13088/
-----------------------------------------------------------
Review request for cloudstack, edison su and Wido den Hollander.
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3959
Repository: cloudstack-git
Description
-------
CloudStack failed to add kvm host when 'pXpY' name format (udev named) physical interface is a member of the bridge (kvm traffic label) on the host.
Root cause is in com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.matchPifFileInDirectory(String).
There're no handling code for 'pXpY' format interface, so I added that.
Diffs
-----
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 571bcc8
Diff: https://reviews.apache.org/r/13088/diff/
Testing
-------
Tested locally, advanced zone with vlan isolation, kvm hypervisor (ubuntu 13.04).
Thanks,
Toshiaki Hatano
Re: Review Request 13088: CLOUDSTACK-3959: [KVM] agent setup failed when
physical interface name is in pXpY format
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13088/#review24298
-----------------------------------------------------------
Commit 7774ecfd5ab3e2ecf1fc75634a959737a302dc79 in branch refs/heads/master from Toshiaki Hatano
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7774ecf ]
CLOUDSTACK-3959: [KVM] agent setup failed when physical interface name is in pXpY format
Add handling.
Signed-off-by: Edison Su <su...@gmail.com>
- ASF Subversion and Git Services
On July 30, 2013, 10:18 p.m., Toshiaki Hatano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13088/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 10:18 p.m.)
>
>
> Review request for cloudstack, edison su and Wido den Hollander.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3959
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CloudStack failed to add kvm host when 'pXpY' name format (udev named) physical interface is a member of the bridge (kvm traffic label) on the host.
>
> Root cause is in com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.matchPifFileInDirectory(String).
> There're no handling code for 'pXpY' format interface, so I added that.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 571bcc8
>
> Diff: https://reviews.apache.org/r/13088/diff/
>
>
> Testing
> -------
>
> Tested locally, advanced zone with vlan isolation, kvm hypervisor (ubuntu 13.04).
>
>
> Thanks,
>
> Toshiaki Hatano
>
>
Re: Review Request 13088: CLOUDSTACK-3959: [KVM] agent setup failed when
physical interface name is in pXpY format
Posted by edison su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13088/#review24299
-----------------------------------------------------------
Ship it!
Ship It!
- edison su
On July 30, 2013, 10:18 p.m., Toshiaki Hatano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13088/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 10:18 p.m.)
>
>
> Review request for cloudstack, edison su and Wido den Hollander.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3959
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CloudStack failed to add kvm host when 'pXpY' name format (udev named) physical interface is a member of the bridge (kvm traffic label) on the host.
>
> Root cause is in com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.matchPifFileInDirectory(String).
> There're no handling code for 'pXpY' format interface, so I added that.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 571bcc8
>
> Diff: https://reviews.apache.org/r/13088/diff/
>
>
> Testing
> -------
>
> Tested locally, advanced zone with vlan isolation, kvm hypervisor (ubuntu 13.04).
>
>
> Thanks,
>
> Toshiaki Hatano
>
>
Re: Review Request 13088: CLOUDSTACK-3959: [KVM] agent setup failed when
physical interface name is in pXpY format
Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13088/#review24303
-----------------------------------------------------------
Review 13088 PASSED the build test
The url of build cloudstack-master-with-patch #89 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/89/
- Jenkins Cloudstack.org
On July 30, 2013, 10:18 p.m., Toshiaki Hatano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13088/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 10:18 p.m.)
>
>
> Review request for cloudstack, edison su and Wido den Hollander.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3959
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CloudStack failed to add kvm host when 'pXpY' name format (udev named) physical interface is a member of the bridge (kvm traffic label) on the host.
>
> Root cause is in com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.matchPifFileInDirectory(String).
> There're no handling code for 'pXpY' format interface, so I added that.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 571bcc8
>
> Diff: https://reviews.apache.org/r/13088/diff/
>
>
> Testing
> -------
>
> Tested locally, advanced zone with vlan isolation, kvm hypervisor (ubuntu 13.04).
>
>
> Thanks,
>
> Toshiaki Hatano
>
>
Re: Review Request 13088: CLOUDSTACK-3959: [KVM] agent setup failed when
physical interface name is in pXpY format
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13088/#review24297
-----------------------------------------------------------
Commit a310815aacd5c742caecc0e00cdec08182a38230 in branch refs/heads/4.2 from Toshiaki Hatano
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a310815 ]
CLOUDSTACK-3959: [KVM] agent setup failed when physical interface name is in pXpY format
Add handling.
Signed-off-by: Edison Su <su...@gmail.com>
- ASF Subversion and Git Services
On July 30, 2013, 10:18 p.m., Toshiaki Hatano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13088/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 10:18 p.m.)
>
>
> Review request for cloudstack, edison su and Wido den Hollander.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3959
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CloudStack failed to add kvm host when 'pXpY' name format (udev named) physical interface is a member of the bridge (kvm traffic label) on the host.
>
> Root cause is in com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.matchPifFileInDirectory(String).
> There're no handling code for 'pXpY' format interface, so I added that.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 571bcc8
>
> Diff: https://reviews.apache.org/r/13088/diff/
>
>
> Testing
> -------
>
> Tested locally, advanced zone with vlan isolation, kvm hypervisor (ubuntu 13.04).
>
>
> Thanks,
>
> Toshiaki Hatano
>
>