You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/08/10 14:24:58 UTC
[GitHub] erisu opened a new pull request #392: Pinning Jasmine@3.1.0 for
Master Fix
erisu opened a new pull request #392: Pinning Jasmine@3.1.0 for Master Fix
URL: https://github.com/apache/cordova-ios/pull/392
### Platforms affected
ios (tests)
### What does this PR do?
This PR fixes the recent test failures on `master` branch.
These tests are failing because of the latest `Jasmine@3.2.0` that has been released within the past 2 days. (https://github.com/jasmine/jasmine-npm/releases/tag/v3.2.0)
At the time the original PR was submitted and tested, Jasmine was at version `3.1.0`. On this version, all tests were passing. https://travis-ci.org/apache/cordova-ios/builds/412472891
By pinning Jasmine@3.1.0 in `package.json`, the tests will continue to pass.
### What testing has been done on this change?
- local `npm test`
- Travis CI: https://travis-ci.org/erisu/cordova-ios/builds/414529064
- AppVeyor: https://ci.appveyor.com/project/erisu/cordova-ios/build/1.0.34
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org