You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/17 12:29:21 UTC

[GitHub] [skywalking] JayeshMuley opened a new issue #6570: How to detect the technology of auto detecting node.

JayeshMuley opened a new issue #6570:
URL: https://github.com/apache/skywalking/issues/6570


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [X] Question or discussion
   - [ ] Bug
   - [ ] Requirement
   - [ ] Feature or performance improvement
   
   ___
   ### Question
   
   Q1. In our echosystem we have services which are keep on talking with Neo4j on some specified IP Port . The question is, In the Instance Client or Server tables why its IP and Port not been detected. Is there any specific reason. 
   
   select  distinct  source_service_name,  dest_service_name  from  service_instance_relation_server_cpm;
   +---------------------+----------------------------------------------------------+
   | source_service_name | dest_service_name                                        |
   +---------------------+----------------------------------------------------------+
   | solutions.service   | x.x.x.x:5432                                             |
   | core.service        | x.x.x.x:5671                                             |
   +---------------------+----------------------------------------------------------+
   No Neo4j port information
   
   Q2. How we can know that particular server is of which technology like Postgres , RabbitMQ  ect. are we storing this information anywhere in database. 
   
   Kindly suggest. 
   Thanks and Regards,
   Jayesh
   
   ![image](https://user-images.githubusercontent.com/75727262/111467068-0966e500-874a-11eb-9ac2-6b41b89619dc.png)
   
   
   
   
   
   
   
   
   
   
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] JayeshMuley commented on issue #6570: Implement Neo4j client lib plugin

Posted by GitBox <gi...@apache.org>.
JayeshMuley commented on issue #6570:
URL: https://github.com/apache/skywalking/issues/6570#issuecomment-802830960


   Is it possible Skywalking detect all the IP and Ports a service communicated with and get stored in Instance Client/Server Relation tables. Irrespective of  available technology plugin. 
   
   Thanks and Regards,
   Jayesh Muley


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wallezhang commented on issue #6570: Implement Neo4j client lib plugin

Posted by GitBox <gi...@apache.org>.
wallezhang commented on issue #6570:
URL: https://github.com/apache/skywalking/issues/6570#issuecomment-856557150


   OK, I tried another solution, which can create exit span in IO thread, but when actually setting tag, because the current span is in asynchronous mode, it cannot be set, however setting operation name is fine. I think the reason is because the `isInAsyncMode` condition is not judged in `org.apache.skywalking.apm.agent.core.context.trace.ExitSpan#tag()` method.
   
   ```java
       @Override
       public AbstractTracingSpan tag(AbstractTag<?> tag, String value) {
           if (stackDepth == 1 || tag.isCanOverwrite()) {
               super.tag(tag, value);
           }
           return this;
       }
   
       @Override
       public AbstractTracingSpan setOperationName(String operationName) {
           if (stackDepth == 1 || isInAsyncMode) {
               return super.setOperationName(operationName);
           } else {
               return this;
           }
       }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wallezhang removed a comment on issue #6570: Implement Neo4j client lib plugin

Posted by GitBox <gi...@apache.org>.
wallezhang removed a comment on issue #6570:
URL: https://github.com/apache/skywalking/issues/6570#issuecomment-856587886


   No. The Neo4j client call processor are like these:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #6570: How to detect the technology of auto detecting node.

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6570:
URL: https://github.com/apache/skywalking/issues/6570#issuecomment-801046176


   Q1, it depends
   1. Whether the node showing on the topology?
   2. Whether the server has installed an agent?
   If both are YES, then the IP:port most likely is in the `network_address_alias`. The topology includes the logic name once the mapping/alias detected by OAP.
   
   Q2, you need to apply for an ID for the new component, https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml. Then use this component id in the new plugin. Then you could add the icon by using the name, like this, https://github.com/apache/skywalking-rocketbot-ui/pull/419/files


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wallezhang commented on issue #6570: Implement Neo4j client lib plugin

Posted by GitBox <gi...@apache.org>.
wallezhang commented on issue #6570:
URL: https://github.com/apache/skywalking/issues/6570#issuecomment-856548926


   @wu-sheng I have a problem when writing scenario test. The client of Neo4j uses asynchronous implementation, so if the asynchronous process is executed quickly, then `createExitSpan` will be executed in the main thread, and a new trace segment will not be created. If the execution is slow, the `createExitSpan` method will be executed in the callback thread and a new trace segment will be created. So in the `expectedData.yaml` file, the expected trace segment and the span in the segment cannot be determined. Is there any good solution to this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] JayeshMuley commented on issue #6570: How to detect the technology of auto detecting node.

Posted by GitBox <gi...@apache.org>.
JayeshMuley commented on issue #6570:
URL: https://github.com/apache/skywalking/issues/6570#issuecomment-801132890


   For Q1 : 
   Neo4j node is not showing up in topology. There is no agent installed on neo4j server as well. 
   
   But Postgres and RabbitMQ nodes are present in topology which are auto detected (no agent installed there as well).  So if Service is communicating with Neo4j IP than the Neo4j node should also be displayed and stored in instance client/server tables?
   
   Kindly advice. 
   
   Thanks and Regards,
   Jayesh Muley


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wallezhang commented on issue #6570: Implement Neo4j client lib plugin

Posted by GitBox <gi...@apache.org>.
wallezhang commented on issue #6570:
URL: https://github.com/apache/skywalking/issues/6570#issuecomment-856587886


   No. The Neo4j client call processor are like these:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wallezhang commented on issue #6570: Implement Neo4j client lib plugin

Posted by GitBox <gi...@apache.org>.
wallezhang commented on issue #6570:
URL: https://github.com/apache/skywalking/issues/6570#issuecomment-848674497


   @wu-sheng Please assign to me, I will try to implement it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #6570: How to detect the technology of auto detecting node.

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6570:
URL: https://github.com/apache/skywalking/issues/6570#issuecomment-801134036


   > For Q1 :
   > Neo4j node is not showing up in topology. There is no agent installed on neo4j server as well.
   > 
   > But Postgres and RabbitMQ nodes are present in topology which are auto detected (no agent installed there as well). So if Service is communicating with Neo4j IP than the Neo4j node should also be displayed and stored in instance client/server tables?
   > 
   > Kindly advice.
   > 
   > Thanks and Regards,
   > Jayesh Muley
   
   Then, it is most likely, you need a plugin for Neo4j client library. That is how the other servers work.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #6570: Implement Neo4j client lib plugin

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6570:
URL: https://github.com/apache/skywalking/issues/6570#issuecomment-856592036


   > > Oh, you mean it has finished in the sync mode. Yes, you need to add `isInAsyncMode` check. Please submit a separate PR for this.
   > 
   > Yes, do I still need to create a new issue to associate this pr?
   
   You don't have to. Writing the details in the pull request is fine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #6570: Implement Neo4j client lib plugin

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6570:
URL: https://github.com/apache/skywalking/issues/6570#issuecomment-856585198


   Are you facing `stackDepth > 1`? Which means nested logic exit span?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #6570: Implement Neo4j client lib plugin

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6570:
URL: https://github.com/apache/skywalking/issues/6570#issuecomment-848675510


   Done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wallezhang commented on issue #6570: Implement Neo4j client lib plugin

Posted by GitBox <gi...@apache.org>.
wallezhang commented on issue #6570:
URL: https://github.com/apache/skywalking/issues/6570#issuecomment-833196227


   @JayeshMuley Could you provide some information about server and client? E.g. server version, which client, and client version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #6570: Implement Neo4j client lib plugin

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #6570:
URL: https://github.com/apache/skywalking/issues/6570


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wallezhang commented on issue #6570: Implement Neo4j client lib plugin

Posted by GitBox <gi...@apache.org>.
wallezhang commented on issue #6570:
URL: https://github.com/apache/skywalking/issues/6570#issuecomment-856590742


   > Oh, you mean it has finished in the sync mode. Yes, you need to add `isInAsyncMode` check. Please submit a separate PR for this.
   
   Yes, do I still need to create a new issue to associate this pr?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #6570: Implement Neo4j client lib plugin

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6570:
URL: https://github.com/apache/skywalking/issues/6570#issuecomment-856588611


   Oh, you mean it has finished in the sync mode. Yes, you need to add `isInAsyncMode` check. Please submit a separate PR for this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #6570: Implement Neo4j client lib plugin

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6570:
URL: https://github.com/apache/skywalking/issues/6570#issuecomment-802832556


   They always will be detected by one plugin or another. Such as a plugin for the specific framework, or a plugin for the network level API. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #6570: Implement Neo4j client lib plugin

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6570:
URL: https://github.com/apache/skywalking/issues/6570#issuecomment-856550554


   OK, this would be very tricky. We usually expect you have certain segments. Because otherwise, the testing is meaningless.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org