You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@daffodil.apache.org by GitBox <gi...@apache.org> on 2019/01/16 23:50:39 UTC

[GitHub] mbeckerle commented on a change in pull request #167: Daffodil 2051 tests broken in windows

mbeckerle commented on a change in pull request #167: Daffodil 2051 tests broken in windows
URL: https://github.com/apache/incubator-daffodil/pull/167#discussion_r248490624
 
 

 ##########
 File path: daffodil-test-ibm1/src/test/resources/test-suite/tresys-contributed/AG.tdml
 ##########
 @@ -24,9 +24,9 @@
   <parserTestCase name="AG000" root="allZones" model="AG.dfdl.xsd"
     description="Discriminated choices"
     roundTrip="true">
-    <document><![CDATA[1
-zone 1
-]]></document>
+    <document>
+	  <documentPart type="text" replaceDFDLEntities="true"><![CDATA[1%LF;zone 1%LF;]]></documentPart>
 
 Review comment:
   I wonder how many tests would break if we changed the default for replaceDFDLEntitites so it defaults to "true". That would make these less cluttered, by allowing just <document><![CDATA[...]]></document> again.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services