You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/05 00:33:22 UTC
[GitHub] [airflow] fjmacagno opened a new issue #14613: Better "dependency already registered" warning message
fjmacagno opened a new issue #14613:
URL: https://github.com/apache/airflow/issues/14613
**Description**
I have started getting a bunch of warnings like:
```
[2021-03-05 00:28:49,472] {baseoperator.py:1151} WARNING - Dependency <Task(PythonOperator): hold_for_review>, notify_on_slack already registered
```
I am sure this is my fault, but it would be nice if this warning included the dag, or at least the file, so i would have more of an idea where it is happening.
**Use case / motivation**
Would make debugging easier.
**Are you willing to submit a PR?**
No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] fjmacagno commented on issue #14613: Better "dependency already registered" warning message
Posted by GitBox <gi...@apache.org>.
fjmacagno commented on issue #14613:
URL: https://github.com/apache/airflow/issues/14613#issuecomment-791805189
2.0.1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] fjmacagno commented on issue #14613: Better "dependency already registered" warning message
Posted by GitBox <gi...@apache.org>.
fjmacagno commented on issue #14613:
URL: https://github.com/apache/airflow/issues/14613#issuecomment-822643281
Solution looks good, ill test it once it is released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #14613: Better "dependency already registered" warning message
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #14613:
URL: https://github.com/apache/airflow/issues/14613#issuecomment-791805009
what version of Airflow do you use?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] fjmacagno commented on issue #14613: Better "dependency already registered" warning message
Posted by GitBox <gi...@apache.org>.
fjmacagno commented on issue #14613:
URL: https://github.com/apache/airflow/issues/14613#issuecomment-1043474714
BTW Changes look great, it just took forever to get us migrated to a newer version of Airflow. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Goodkat commented on issue #14613: Better "dependency already registered" warning message
Posted by GitBox <gi...@apache.org>.
Goodkat commented on issue #14613:
URL: https://github.com/apache/airflow/issues/14613#issuecomment-798986923
As I understand, we just need to extend the **add_only_new** function with one more input parameter **dag** and then add the third argument to the warning message there: self.log.warning('Dependency %s, %s already registered', self, item).
All changes are in the **baseoperator.py** file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on issue #14613: Better "dependency already registered" warning message
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on issue #14613:
URL: https://github.com/apache/airflow/issues/14613#issuecomment-806008022
Hi @Goodkat , here you go :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Goodkat commented on issue #14613: Better "dependency already registered" warning message
Posted by GitBox <gi...@apache.org>.
Goodkat commented on issue #14613:
URL: https://github.com/apache/airflow/issues/14613#issuecomment-822632026
The warning message was extended with dag_id to be more informative.
The respective changes were implemented and merged according to the PR #14860.
Please consider whether this issue can be closed now.
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Goodkat commented on issue #14613: Better "dependency already registered" warning message
Posted by GitBox <gi...@apache.org>.
Goodkat commented on issue #14613:
URL: https://github.com/apache/airflow/issues/14613#issuecomment-806005004
Can someone assign this to me, since I am already working on it as per the PR #14860?
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] fjmacagno closed issue #14613: Better "dependency already registered" warning message
Posted by GitBox <gi...@apache.org>.
fjmacagno closed issue #14613:
URL: https://github.com/apache/airflow/issues/14613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Goodkat edited a comment on issue #14613: Better "dependency already registered" warning message
Posted by GitBox <gi...@apache.org>.
Goodkat edited a comment on issue #14613:
URL: https://github.com/apache/airflow/issues/14613#issuecomment-798986923
As I understand, we just need to extend the **add_only_new** function with one more input parameter **dag** and add then the third argument to the warning message there: self.log.warning('Dependency %s, %s already registered', self, item).
All changes are in the **baseoperator.py** file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org