You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/10/16 05:07:46 UTC
[GitHub] [netbeans] jGauravGupta opened a new pull request #1485: JEDDICT-322 org.netbeans.modules.db.core convert friend to public packages
jGauravGupta opened a new pull request #1485:
URL: https://github.com/apache/netbeans/pull/1485
Github issue: https://github.com/jeddict/jeddict/issues/322
Friend API of the Apache NetBeans Platform used by Jeddict modules:
| NetBeans Module name | NetBeans Module location | APIs | Used by Jeddict modules | Requirement | Why access needed? |
| --- | --- | --- | --- | --- | --------- |
| org.netbeans.modules:org-netbeans-modules-db-core | netbeans\ide\db.core | org.netbeans.modules.db.api.sql.execute | io.github.jeddict.jpa.modeler | public-packages | SQL Editor integration in JPA Modeler |
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #1485: JEDDICT-322 org.netbeans.modules.db.core convert friend to public packages
Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #1485:
URL: https://github.com/apache/netbeans/pull/1485
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #1485: JEDDICT-322 org.netbeans.modules.db.core convert friend to public packages
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #1485:
URL: https://github.com/apache/netbeans/pull/1485#issuecomment-710295850
@lkishalmi why was this rushed in? There are open comments and @jGauravGupta asked what to do about that. Given that nobody really ensured db api is sane I'm already icky, that this is solved without a fried dependency, at least the changes I commented should have been done.
And yes - I should have marked this as changes requested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #1485: JEDDICT-322 org.netbeans.modules.db.core convert friend to public packages
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #1485:
URL: https://github.com/apache/netbeans/pull/1485#issuecomment-710494238
Ok - I reread, reevaluated - lets keep as is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #1485: JEDDICT-322 org.netbeans.modules.db.core convert friend to public packages
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #1485:
URL: https://github.com/apache/netbeans/pull/1485#issuecomment-710312832
I'll propose an update for this shortly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jGauravGupta commented on pull request #1485: JEDDICT-322 org.netbeans.modules.db.core convert friend to public packages
Posted by GitBox <gi...@apache.org>.
jGauravGupta commented on pull request #1485:
URL: https://github.com/apache/netbeans/pull/1485#issuecomment-710121362
Hi @lkishalmi ,
It can be part of the next release 12.3, so merge in the master will be ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #1485: JEDDICT-322 org.netbeans.modules.db.core convert friend to public packages
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #1485:
URL: https://github.com/apache/netbeans/pull/1485#issuecomment-710071743
Well, the question is? Is this intended to go into 12.2? or just in master.
I'm a bit confused. The version change in manifest.mf would indicate that this would meant to be in 12.2 with an API change.
Yet the milestone has not been set and the base branch is master.
If this is meant to be on master, then the version shall reflect that (fix the conflict)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jGauravGupta closed pull request #1485: JEDDICT-322 org.netbeans.modules.db.core convert friend to public packages
Posted by GitBox <gi...@apache.org>.
jGauravGupta closed pull request #1485:
URL: https://github.com/apache/netbeans/pull/1485
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jGauravGupta commented on pull request #1485: JEDDICT-322 org.netbeans.modules.db.core convert friend to public packages
Posted by GitBox <gi...@apache.org>.
jGauravGupta commented on pull request #1485:
URL: https://github.com/apache/netbeans/pull/1485#issuecomment-709562619
I will create another PR to add Jeddict modules as friend.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jGauravGupta commented on pull request #1485: JEDDICT-322 org.netbeans.modules.db.core convert friend to public packages
Posted by GitBox <gi...@apache.org>.
jGauravGupta commented on pull request #1485:
URL: https://github.com/apache/netbeans/pull/1485#issuecomment-710123670
`org.netbeans.modules.db.api.sql.execute.SQLExecution` API is used by the Jeddict module. Do you want me to move the `org.netbeans.modules.db.api.sql.execute.LogFileLogger` & `org.netbeans.modules.db.api.sql.execute.SQLExecuteOptions` classes to `org.netbeans.modules.db.impl.sql.execute.*`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #1485: JEDDICT-322 org.netbeans.modules.db.core convert friend to public packages
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #1485:
URL: https://github.com/apache/netbeans/pull/1485#issuecomment-710504304
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #1485: JEDDICT-322 org.netbeans.modules.db.core convert friend to public packages
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #1485:
URL: https://github.com/apache/netbeans/pull/1485#issuecomment-709783477
Why you want another PR to increase the list of friends? I gave you go and Matthias wanted few more trivial fixes. Increasing list of 3rd party friends is contra-productive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists