You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by chandnisingh <gi...@git.apache.org> on 2015/11/05 19:34:26 UTC
[GitHub] incubator-apex-malhar pull request: MLHR-1874 #resolve #comment Im...
GitHub user chandnisingh opened a pull request:
https://github.com/apache/incubator-apex-malhar/pull/82
MLHR-1874 #resolve #comment Implementation of file output operator in…
… hive doesn't move tmp files to actual files
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chandnisingh/incubator-apex-malhar MLHR-1874
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-malhar/pull/82.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #82
----
commit 450cb9ae1aa5ec0844d337e89746587abc0bcf29
Author: Chandni Singh <cs...@apache.org>
Date: 2015-11-05T18:09:38Z
MLHR-1874 #resolve #comment Implementation of file output operator in hive doesn't move tmp files to actual files
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: MLHR-1874 #resolve #comment Im...
Posted by chandnisingh <gi...@git.apache.org>.
Github user chandnisingh closed the pull request at:
https://github.com/apache/incubator-apex-malhar/pull/82
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: MLHR-1874 #resolve #comment Im...
Posted by brightchen <gi...@git.apache.org>.
Github user brightchen commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/82#discussion_r44825680
--- Diff: contrib/src/main/java/com/datatorrent/contrib/hive/AbstractFSRollingOutputOperator.java ---
@@ -183,12 +184,7 @@ protected void rotateCall(String lastFile)
try {
this.rotate(lastFile);
}
- catch (IOException ex) {
- logger.debug(ex.getMessage());
- DTThrowable.rethrow(ex);
- }
- catch (ExecutionException ex) {
- logger.debug(ex.getMessage());
+ catch (IOException | ExecutionException ex) {
--- End diff --
The HiveMockTest also has a issue. the fsRolling.setRotationWindows should be called to set the window.
And the HiveMockTest is using the embed Hive, you in fact can test even if Hive not installed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---