[GitHub] [spark] srowen commented on a change in pull request #24140: [SPARK-27198][core] Heartbeat interval mismatch in driver and executor

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #24140: [SPARK-27198][core] Heartbeat interval mismatch in driver and executor
URL: https://github.com/apache/spark/pull/24140#discussion_r267047453
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
 ##########
 @@ -855,7 +855,9 @@ private[spark] class Executor(
    * Schedules a task to report heartbeat and partial metrics for active tasks to driver.
    */
   private def startDriverHeartbeater(): Unit = {
-    val intervalMs = conf.getTimeAsMs("spark.executor.heartbeatInterval", "10s")
+    val intervalMs = conf
 
 Review comment:
   I agree with the change. In branch 2.4 this is accessed both with getTimeAsSeconds and getTimeAsMs. The only question is which interpretation was intended? it's not a best practice to not specify the units, but hey it can happen.
   
   In master, this is interpreted as milliseconds by default. I think we should instead switch how it's read in SparkConf instead?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org