[GitHub] [hadoop-ozone] anuengineer commented on a change in pull request #283: HDDS-2651 Make startId parameter non-mandatory while listing containe…

[GitBox <gi...@apache.org>]

anuengineer commented on a change in pull request #283: HDDS-2651 Make startId parameter non-mandatory while listing containe…
URL: https://github.com/apache/hadoop-ozone/pull/283#discussion_r354293920
 
 

 ##########
 File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/SCMContainerManager.java
 ##########
 @@ -217,7 +217,7 @@ public ContainerInfo getContainer(final ContainerID containerID)
       Collections.sort(containersIds);
 
       return containersIds.stream()
-          .filter(id -> id.getId() > startId)
+          .filter(id -> id.getId() >= startId)
 
 Review comment:
   +1 from me too. we can break backward compact now, no issues at all. We are still at the Alpha tag. As soon as we move to beta rules change :)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org