You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Colin MacNaughton (JIRA)" <ji...@apache.org> on 2009/03/31 02:49:34 UTC

[jira] Created: (AMQ-2189) activemq-flow: bug fixes in BrokerDatabase and KahaDBStore

activemq-flow: bug fixes in BrokerDatabase and KahaDBStore
----------------------------------------------------------

                 Key: AMQ-2189
                 URL: https://issues.apache.org/activemq/browse/AMQ-2189
             Project: ActiveMQ
          Issue Type: Bug
    Affects Versions: incubation
         Environment: N/A
            Reporter: Colin MacNaughton
             Fix For: incubation
         Attachments: AMQ-2189patch.txt

The attached fix resolves a problem in KahaDBStore.KahaDBSession in which addMessage() wasn't using the caller supplied message key but instead allocated a new key. Without using the user supplied key, subsequent deletes would not properly delete the message. Also fixed corresponding test cases to provide a message key when adding messages. 

Also made some fixes to synchronization and delayed event processing in BrokerDatabase. The resulting code is not as performant in swimlanes testing, and should be optimized in the future (the problem is too many threads synchronizing on the opQueue is causing a lot of contention). 

Finally added some miscellaneous fixes to OpenwireProtocolHandler and the test drivers to avoid/detect duplicate messageIds. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (AMQ-2189) activemq-flow: bug fixes in BrokerDatabase and KahaDBStore

Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hiram Chirino resolved AMQ-2189.
--------------------------------

    Resolution: Fixed

applied.  Thanks!

> activemq-flow: bug fixes in BrokerDatabase and KahaDBStore
> ----------------------------------------------------------
>
>                 Key: AMQ-2189
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2189
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: incubation
>         Environment: N/A
>            Reporter: Colin MacNaughton
>             Fix For: incubation
>
>         Attachments: AMQ-2189patch.txt
>
>
> The attached fix resolves a problem in KahaDBStore.KahaDBSession in which addMessage() wasn't using the caller supplied message key but instead allocated a new key. Without using the user supplied key, subsequent deletes would not properly delete the message. Also fixed corresponding test cases to provide a message key when adding messages. 
> Also made some fixes to synchronization and delayed event processing in BrokerDatabase. The resulting code is not as performant in swimlanes testing, and should be optimized in the future (the problem is too many threads synchronizing on the opQueue is causing a lot of contention). 
> Finally added some miscellaneous fixes to OpenwireProtocolHandler and the test drivers to avoid/detect duplicate messageIds. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AMQ-2189) activemq-flow: bug fixes in BrokerDatabase and KahaDBStore

Posted by "Colin MacNaughton (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Colin MacNaughton updated AMQ-2189:
-----------------------------------

    Attachment: AMQ-2189patch.txt

Patch file.

> activemq-flow: bug fixes in BrokerDatabase and KahaDBStore
> ----------------------------------------------------------
>
>                 Key: AMQ-2189
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2189
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: incubation
>         Environment: N/A
>            Reporter: Colin MacNaughton
>             Fix For: incubation
>
>         Attachments: AMQ-2189patch.txt
>
>
> The attached fix resolves a problem in KahaDBStore.KahaDBSession in which addMessage() wasn't using the caller supplied message key but instead allocated a new key. Without using the user supplied key, subsequent deletes would not properly delete the message. Also fixed corresponding test cases to provide a message key when adding messages. 
> Also made some fixes to synchronization and delayed event processing in BrokerDatabase. The resulting code is not as performant in swimlanes testing, and should be optimized in the future (the problem is too many threads synchronizing on the opQueue is causing a lot of contention). 
> Finally added some miscellaneous fixes to OpenwireProtocolHandler and the test drivers to avoid/detect duplicate messageIds. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.