You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Hisoka-X (via GitHub)" <gi...@apache.org> on 2023/07/29 03:49:25 UTC
[GitHub] [spark] Hisoka-X commented on a diff in pull request #42221: [SPARK-44595][CONNECT] Make the user session cache number and cache time be configurable in spark connect service
Hisoka-X commented on code in PR #42221:
URL: https://github.com/apache/spark/pull/42221#discussion_r1278228410
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala:
##########
@@ -121,4 +121,22 @@ object Connect {
.version("3.5.0")
.booleanConf
.createWithDefault(false)
+
+ val CONNECT_USER_SESSION_CACHE_SIZE =
+ ConfigBuilder("spark.connect.userSession.cacheSize")
+ .doc("""
+ |Sets the cache size of user session.
+ |""".stripMargin)
Review Comment:
```suggestion
.doc("Sets the cache size of user session.")
```
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala:
##########
@@ -121,4 +121,22 @@ object Connect {
.version("3.5.0")
.booleanConf
.createWithDefault(false)
+
+ val CONNECT_USER_SESSION_CACHE_SIZE =
+ ConfigBuilder("spark.connect.userSession.cacheSize")
+ .doc("""
+ |Sets the cache size of user session.
+ |""".stripMargin)
+ .version("4.0.0")
+ .intConf
+ .createWithDefault(100)
+
+ val CONNECT_USER_SESSION_CACHE_TIMEOUT =
+ ConfigBuilder("spark.connect.userSession.cacheTimeout")
+ .doc("""
+ |Sets the cache timeout of user session.
+ |""".stripMargin)
Review Comment:
```suggestion
.doc("Sets the cache timeout of user session.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org