You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by jackylk <gi...@git.apache.org> on 2018/03/03 05:42:14 UTC

[GitHub] carbondata pull request #2026: [CARBONDATA-2098] Add datamap managment descr...

GitHub user jackylk opened a pull request:

    https://github.com/apache/carbondata/pull/2026

    [CARBONDATA-2098] Add datamap managment description

    Enhance document for datamap
    
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
    
     - [ ] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jackylk/incubator-carbondata doc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2026.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2026
    
----
commit 0fad0ec79b1ddd7daf80eda54ccfc3daf20ab220
Author: Jacky Li <ja...@...>
Date:   2018-03-03T05:40:59Z

    change

----


---

[GitHub] carbondata issue #2026: [CARBONDATA-2098] Add datamap managment description

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2026
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4055/



---

[GitHub] carbondata issue #2026: [CARBONDATA-2098] Add datamap managment description

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2026
  
    LGTM


---

[GitHub] carbondata issue #2026: [CARBONDATA-2098] Add datamap managment description

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2026
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4058/



---

[GitHub] carbondata pull request #2026: [CARBONDATA-2098] Add datamap managment descr...

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2026#discussion_r172009728
  
    --- Diff: docs/datamap/preaggregate-datamap-guide.md ---
    @@ -193,8 +230,10 @@ main table but not performed on pre-aggregate table, all queries still can benef
     pre-aggregate tables. To further improve the query performance, compaction on pre-aggregate tables 
     can be triggered to merge the segments and files in the pre-aggregate tables. 
     
    -#### Data Management on pre-aggregate tables
    -Once there is pre-aggregate table created on the main table, following command on the main table
    +## Data Management with pre-aggregate tables
    +In current implementation, data consistence need to maintained for both main table and pre-aggregate
    --- End diff --
    
    typo `need to be maintained`


---

[GitHub] carbondata issue #2026: [CARBONDATA-2098] Add datamap managment description

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2026
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2812/



---

[GitHub] carbondata issue #2026: [CARBONDATA-2098] Add datamap managment description

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2026
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2809/



---

[GitHub] carbondata pull request #2026: [CARBONDATA-2098] Add datamap managment descr...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2026


---