You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Benedikt Ritter (JIRA)" <ji...@apache.org> on 2014/01/02 17:21:00 UTC

[jira] [Closed] (LANG-929) OctalUnescaper code is complex, leading to bugs

     [ https://issues.apache.org/jira/browse/LANG-929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benedikt Ritter closed LANG-929.
--------------------------------


> OctalUnescaper code is complex, leading to bugs
> -----------------------------------------------
>
>                 Key: LANG-929
>                 URL: https://issues.apache.org/jira/browse/LANG-929
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.text.translate.*
>            Reporter: Henri Yandell
>            Assignee: Henri Yandell
>             Fix For: 3.2
>
>
> My gut is that the code in OctalUnescaper is unnecessarily complex. It feels simpler to look at the legitimate values for an Octal more explicitly. 
> Thinking the current code through, it fails if you pass it \279. That should be octal \27 followed by a 9, but instead it will try to parse it as an Octal and throw a NumberFormatException. 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)