You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2011/10/10 22:20:32 UTC
[jira] [Commented] (SHINDIG-1637) Introduce abstract
LockedDomainService implementation to enable easier customization
[ https://issues.apache.org/jira/browse/SHINDIG-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124456#comment-13124456 ]
jiraposter@reviews.apache.org commented on SHINDIG-1637:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2333/
-----------------------------------------------------------
(Updated 2011-10-10 20:20:25.067650)
Review request for Dan Dumont.
Changes
-------
Creating JIRA
Summary
-------
The proposed changes are to introduce an abstract class that implements LockedDomainService and provides some infrastructure to make creating one's own LockedDomainService a bit easier.
Sorry for the horrible diffs. I moved a lot of stuff around in HashLockedDomainService.
This addresses bug SHINDIG-1637.
https://issues.apache.org/jira/browse/SHINDIG-1637
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java 1181021
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/HashLockedDomainServiceTest.java 1181021
Diff: https://reviews.apache.org/r/2333/diff
Testing
-------
Updated and ran existing JUnits.
Thanks,
Stanton
> Introduce abstract LockedDomainService implementation to enable easier customization
> ------------------------------------------------------------------------------------
>
> Key: SHINDIG-1637
> URL: https://issues.apache.org/jira/browse/SHINDIG-1637
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 3.0.0
> Reporter: Stanton Sievers
> Priority: Minor
> Fix For: 3.0.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Currently when one wants to created a customized LockedDomainService, one has to implement all of the functionality from scratch. The proposed changes are to introduce an abstract class that implements LockedDomainService and provides some infrastructure to make creating one's own LockedDomainService a bit easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira