You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2008/05/31 01:18:44 UTC
[jira] Created: (HADOOP-3476) Code cleanup needed in fuse-dfs
Code cleanup needed in fuse-dfs
-------------------------------
Key: HADOOP-3476
URL: https://issues.apache.org/jira/browse/HADOOP-3476
Project: Hadoop Core
Issue Type: Bug
Components: contrib/fuse-dfs
Reporter: Tsz Wo (Nicholas), SZE
Some of the comments in fuse-dfs are not related to the codes. For example, search "facebook" in src/contrib/fuse-dfs/configure.ac
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3476) Code cleanup needed in fuse-dfs
Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pete Wyckoff updated HADOOP-3476:
---------------------------------
Attachment: patch0.txt
> Code cleanup needed in fuse-dfs
> -------------------------------
>
> Key: HADOOP-3476
> URL: https://issues.apache.org/jira/browse/HADOOP-3476
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/fuse-dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Attachments: patch0.txt
>
>
> Some of the comments in fuse-dfs are not related to the codes. For example, search "facebook" in src/contrib/fuse-dfs/configure.ac
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3476) Code cleanup needed in fuse-dfs
Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pete Wyckoff updated HADOOP-3476:
---------------------------------
Status: Patch Available (was: Open)
This is a change in autoconf only, no code changes.
> Code cleanup needed in fuse-dfs
> -------------------------------
>
> Key: HADOOP-3476
> URL: https://issues.apache.org/jira/browse/HADOOP-3476
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/fuse-dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Attachments: patch0.txt
>
>
> Some of the comments in fuse-dfs are not related to the codes. For example, search "facebook" in src/contrib/fuse-dfs/configure.ac
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3476) Code cleanup needed in fuse-dfs
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-3476:
-------------------------------------
Resolution: Fixed
Fix Version/s: 0.18.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I juts committed this. Thanks Pete!
> Code cleanup needed in fuse-dfs
> -------------------------------
>
> Key: HADOOP-3476
> URL: https://issues.apache.org/jira/browse/HADOOP-3476
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/fuse-dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Pete Wyckoff
> Fix For: 0.18.0
>
> Attachments: patch0.txt
>
>
> Some of the comments in fuse-dfs are not related to the codes. For example, search "facebook" in src/contrib/fuse-dfs/configure.ac
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-3476) Code cleanup needed in fuse-dfs
Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Chansler reassigned HADOOP-3476:
---------------------------------------
Assignee: Pete Wyckoff
Assigning to whomever submitted a patch so as to better manage committing things that are ready for prime time.
> Code cleanup needed in fuse-dfs
> -------------------------------
>
> Key: HADOOP-3476
> URL: https://issues.apache.org/jira/browse/HADOOP-3476
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/fuse-dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Pete Wyckoff
> Attachments: patch0.txt
>
>
> Some of the comments in fuse-dfs are not related to the codes. For example, search "facebook" in src/contrib/fuse-dfs/configure.ac
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3476) Code cleanup needed in fuse-dfs
Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602055#action_12602055 ]
Pete Wyckoff commented on HADOOP-3476:
--------------------------------------
NOTE: I renamed some of the macros from FB_blah to FUSE_DFS_blah; longer term, maybe we could figure a way to share macros and such between this, pipes and libhdfs??
> Code cleanup needed in fuse-dfs
> -------------------------------
>
> Key: HADOOP-3476
> URL: https://issues.apache.org/jira/browse/HADOOP-3476
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/fuse-dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Attachments: patch0.txt
>
>
> Some of the comments in fuse-dfs are not related to the codes. For example, search "facebook" in src/contrib/fuse-dfs/configure.ac
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3476) Code cleanup needed in fuse-dfs
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602380#action_12602380 ]
dhruba borthakur commented on HADOOP-3476:
------------------------------------------
+1. Code looks good.
> Code cleanup needed in fuse-dfs
> -------------------------------
>
> Key: HADOOP-3476
> URL: https://issues.apache.org/jira/browse/HADOOP-3476
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/fuse-dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Pete Wyckoff
> Fix For: 0.18.0
>
> Attachments: patch0.txt
>
>
> Some of the comments in fuse-dfs are not related to the codes. For example, search "facebook" in src/contrib/fuse-dfs/configure.ac
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3476) Code cleanup needed in fuse-dfs
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602198#action_12602198 ]
Hadoop QA commented on HADOOP-3476:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12383317/patch0.txt
against trunk revision 662976.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2564/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2564/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2564/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2564/console
This message is automatically generated.
> Code cleanup needed in fuse-dfs
> -------------------------------
>
> Key: HADOOP-3476
> URL: https://issues.apache.org/jira/browse/HADOOP-3476
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/fuse-dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Attachments: patch0.txt
>
>
> Some of the comments in fuse-dfs are not related to the codes. For example, search "facebook" in src/contrib/fuse-dfs/configure.ac
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3476) Code cleanup needed in fuse-dfs
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602120#action_12602120 ]
Hadoop QA commented on HADOOP-3476:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12383317/patch0.txt
against trunk revision 662913.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
-1 patch. The patch command could not apply the patch.
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2555/console
This message is automatically generated.
> Code cleanup needed in fuse-dfs
> -------------------------------
>
> Key: HADOOP-3476
> URL: https://issues.apache.org/jira/browse/HADOOP-3476
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/fuse-dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Attachments: patch0.txt
>
>
> Some of the comments in fuse-dfs are not related to the codes. For example, search "facebook" in src/contrib/fuse-dfs/configure.ac
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3476) Code cleanup needed in fuse-dfs
Posted by "Pete Wyckoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601770#action_12601770 ]
Pete Wyckoff commented on HADOOP-3476:
--------------------------------------
Good catch - I used the default facebook external autoconf macros. I've changed these things internally and am awaiting my internal code review and will provide a patch shortly.
> Code cleanup needed in fuse-dfs
> -------------------------------
>
> Key: HADOOP-3476
> URL: https://issues.apache.org/jira/browse/HADOOP-3476
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/fuse-dfs
> Reporter: Tsz Wo (Nicholas), SZE
>
> Some of the comments in fuse-dfs are not related to the codes. For example, search "facebook" in src/contrib/fuse-dfs/configure.ac
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.