[GitHub] [spark] wangyum commented on a change in pull request #26589: [SPARK-29947][SQL] Improve ResolveRelations performance

[GitBox <gi...@apache.org>]

wangyum commented on a change in pull request #26589: [SPARK-29947][SQL] Improve ResolveRelations performance
URL: https://github.com/apache/spark/pull/26589#discussion_r361780484
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ##########
 @@ -847,21 +847,32 @@ class Analyzer(
       case _ => plan
     }
 
-    def apply(plan: LogicalPlan): LogicalPlan = ResolveTempViews(plan).resolveOperatorsUp {
-      case i @ InsertIntoStatement(table, _, _, _, _) if i.query.resolved =>
-        val relation = table match {
-          case u @ UnresolvedRelation(SessionCatalogAndIdentifier(catalog, ident)) =>
-            lookupRelation(catalog, ident, recurse = false).getOrElse(u)
-          case other => other
-        }
+    def apply(plan: LogicalPlan): LogicalPlan = {
+      var logicalPlans = Map.empty[UnresolvedRelation, LogicalPlan]
 
 Review comment:
   Add comment to doc:
   https://github.com/apache/spark/blob/07e6b7f7529f07a73dae9baede5e2046a18e35bc/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L94-L96

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org