You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by cenyuhai <gi...@git.apache.org> on 2017/09/16 08:17:49 UTC

[GitHub] spark pull request #19219: [SPARK-21993][SQL][WIP] Close sessionState when f...

Github user cenyuhai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19219#discussion_r139281683
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionStateBuilder.scala ---
    @@ -42,7 +42,7 @@ class HiveSessionStateBuilder(session: SparkSession, parentState: Option[Session
        * Create a Hive aware resource loader.
        */
       override protected lazy val resourceLoader: HiveSessionResourceLoader = {
    -    val client: HiveClient = externalCatalog.client.newSession()
    +    val client: HiveClient = externalCatalog.client
    --- End diff --
    
    newSession is to isolate SparkSession in Spark ThriftServer, You must judge whether is thriftserver or not.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org