You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org> on 2025/01/15 00:06:55 UTC
[Impala-ASF-CR] Calcite parser test changes
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22349
Change subject: Calcite parser test changes
......................................................................
Calcite parser test changes
Note that this patch also includes the changes to the following files
Steve has on top of https://gerrit.cloudera.org/c/22334/2.
- AuthorizationStmtTest.java.
- AuthorizationTestBase.java.
- java/calcite-planner/pom.xml.
Change-Id: I7967b9b48604565d7bdf66d4b4ea01a55455c5c6
---
A fe/src/test/java/org/apache/impala/analysis/CalciteParserFixture.java
M fe/src/test/java/org/apache/impala/analysis/CupParserFixture.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java
M fe/src/test/java/org/apache/impala/authorization/AuthorizationTestBase.java
M fe/src/test/java/org/apache/impala/common/ParserFixture.java
M java/calcite-planner/pom.xml
7 files changed, 654 insertions(+), 49 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/22349/1
--
To view, visit http://gerrit.cloudera.org:8080/22349
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7967b9b48604565d7bdf66d4b4ea01a55455c5c6
Gerrit-Change-Number: 22349
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] Calcite parser test changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22349 )
Change subject: Calcite parser test changes
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/17988/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22349
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7967b9b48604565d7bdf66d4b4ea01a55455c5c6
Gerrit-Change-Number: 22349
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Jan 2025 00:37:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Calcite parser test changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22349 )
Change subject: Calcite parser test changes
......................................................................
Patch Set 1:
(2 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/22349/1/fe/src/test/java/org/apache/impala/analysis/CalciteParserFixture.java
File fe/src/test/java/org/apache/impala/analysis/CalciteParserFixture.java:
http://gerrit.cloudera.org:8080/#/c/22349/1/fe/src/test/java/org/apache/impala/analysis/CalciteParserFixture.java@254
PS1, Line 254: throw new RuntimeException("Statment did not parse in Calcite but parsed in Impala: " + stmt);
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/22349/1/fe/src/test/java/org/apache/impala/analysis/CalciteParserFixture.java@465
PS1, Line 465: private ParsedStatement createParsedStatement(TQueryCtx queryCtx) throws ImpalaException {
line too long (92 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/22349
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7967b9b48604565d7bdf66d4b4ea01a55455c5c6
Gerrit-Change-Number: 22349
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Jan 2025 00:18:59 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Calcite parser test changes
Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has abandoned this change. ( http://gerrit.cloudera.org:8080/22349 )
Change subject: Calcite parser test changes
......................................................................
Abandoned
Abandon this since it's no longer needed.
--
To view, visit http://gerrit.cloudera.org:8080/22349
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I7967b9b48604565d7bdf66d4b4ea01a55455c5c6
Gerrit-Change-Number: 22349
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>