You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2010/10/27 07:58:24 UTC
DO NOT REPLY [Bug 50161] New: "index.jsp" is added to paths ending
in a "/" before doFilter is called on matching Filters
https://issues.apache.org/bugzilla/show_bug.cgi?id=50161
Summary: "index.jsp" is added to paths ending in a "/" before
doFilter is called on matching Filters
Product: Tomcat 7
Version: 7.0.4
Platform: PC
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: hossman_apachebugzilla@fucit.org
Created an attachment (id=26216)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26216)
war file demonstrating the bug
When registering a Filter with a wildcarded url-patterm (ie: "/*") tomcat 7.0.4
seems to be adding "index.jsp" to the end of any url which ends in a "/" prior
to invoking the Filter's doFilter method.
This is a change in behavior from tomcat 6.0.29 (and certainly seems like a
bug, but i'm not an expert on the servlet spec)
The attached war file includes a filter (and it's source) which is mapped to
the url-pattern "/*". This filter causes a 400 response for any request it
sees, specifying the path information included in the HttpServletRequest as the
error message.
If you start up tomcat 6.0.* using port 8080, running this war, a URL like
this....
http://localhost:8080/filter-bug/asdf
...will produce an error message like...
FilterBugDemo@24988707 Got:/asdf + null
...likewise a URL like this...
http://localhost:8080/filter-bug/asdf/
...will produce the error message...
FilterBugDemo@24988707 Got:/asdf/ + null
Using Tomcat 7.0.4 however, the last URL method above produces this error...
FilterBugDemo@4a8d3d62 Got:/asdf/index.jsp + null
...indicating that the Filter did not receive an HttpServletRequest
containing the "correct" URL sent by the client.
(Note: This behavior may exist in other versions of Tomcat 7.0.*, i only tested
7.0.4)
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 50161] "index.jsp" is added to paths ending in a
"/" before doFilter is called on matching Filters
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50161
--- Comment #5 from Attila Király <ki...@gmail.com> 2010-10-27 15:52:31 EDT ---
Don't know how legal it is but I use the following workaround in the web.xml
(works with 7.0.4):
<welcome-file-list>
<welcome-file></welcome-file>
</welcome-file-list>
This turns off the default welcome file list and adds nothing to the end of the
url.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 50161] "index.jsp" is added to paths ending in a
"/" before doFilter is called on matching Filters
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50161
--- Comment #1 from hossman <ho...@fucit.org> 2010-10-27 01:59:45 EDT ---
Note: this is (evidently) the root cause of SOLR-2022...
https://issues.apache.org/jira/browse/SOLR-2022
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 50161] "index.jsp" is added to paths ending in a
"/" before doFilter is called on matching Filters
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50161
--- Comment #4 from hossman <ho...@fucit.org> 2010-10-27 14:35:17 EDT ---
While i appreciate that the underlying change that caused this bug is most
certainly the same as that of bug#49422 i would like to point out that the
actual issue is (to me at least) fairly distinct.
Having read the comments in bug#49422 I (somewhat) understand the reasons why a
servlet wishing to receive requests for "/foo/" should be registered with a
url-mapping of "/foo/*" in order to receive the implicit request for
"/foo/index.jsp" but in the case of this bug (bug#50161) We are already using a
url-mapping of "/*" for the Filter in question.
The issue at hand is what the return value of
HttpServletRequest.getServletPath() should be when the Servlet (or in our case
Filter) processes the request.
Shouldn't that method (per the javadocs) "Returns the part of this request's
URL that calls the servlet" ... w/o having additional (implicit) values tacked
on to the end?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 50161] "index.jsp" is added to paths ending in a
"/" before doFilter is called on matching Filters
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50161
Konstantin Kolinko <kn...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|INVALID |DUPLICATE
--- Comment #3 from Konstantin Kolinko <kn...@gmail.com> 2010-10-27 11:32:42 EDT ---
*** This bug has been marked as a duplicate of bug 49422 ***
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 50161] "index.jsp" is added to paths ending in a
"/" before doFilter is called on matching Filters
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50161
--- Comment #6 from Mark Thomas <ma...@apache.org> 2010-10-27 21:30:44 EDT ---
(In reply to comment #4)
> The issue at hand is what the return value of
> HttpServletRequest.getServletPath() should be when the Servlet (or in our case
> Filter) processes the request.
>
> Shouldn't that method (per the javadocs) "Returns the part of this request's
> URL that calls the servlet" ... w/o having additional (implicit) values tacked
> on to the end?
There are a couple of ambiguities in the spec in this area:
- It isn't clear if filter mapping occurs before or after welcome file
processing. The implication is that filter mapping is after welcome file
processing.
- It isn't clear if the welcome file should be included in getServletPath()
etc. The implication is that it should.
Both of these issues - and a bunch of others - are on my list of things to nag
the EG about.
The option(s) that get added for the next 7.0.x release should fix this for you
- or at least enable you to work around it.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 50161] "index.jsp" is added to paths ending in a
"/" before doFilter is called on matching Filters
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50161
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |INVALID
--- Comment #2 from Mark Thomas <ma...@apache.org> 2010-10-27 05:22:41 EDT ---
Looks like another case of bug 49422.
More discussions in http://tomcat.markmail.org/thread/xvuophujspik5liq
Short version:
- Tomcat is stricter in applying the spec rules for welcome files
- Some EG members think the spec does not reflect what was agreed in the EG
- Tomcat will be adding some new options to handle this - probably defaulting
to previous behaviour
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org