You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by kh...@apache.org on 2019/06/10 13:20:56 UTC

[commons-geometry] branch GEOMETRY-57 created (now d905b30)

This is an automated email from the ASF dual-hosted git repository.

khmarbaise pushed a change to branch GEOMETRY-57
in repository https://gitbox.apache.org/repos/asf/commons-geometry.git.


      at d905b30  [GEOMETRY-57] - BigFraction Constructors are private

This branch includes the following new commits:

     new d905b30  [GEOMETRY-57] - BigFraction Constructors are private

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[commons-geometry] 01/01: [GEOMETRY-57] - BigFraction Constructors are private

Posted by kh...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

khmarbaise pushed a commit to branch GEOMETRY-57
in repository https://gitbox.apache.org/repos/asf/commons-geometry.git

commit d905b3030263aabf718cd015b2f965e912a1ce9d
Author: Karl Heinz Marbaise <ka...@soebes.de>
AuthorDate: Mon Jun 10 15:18:15 2019 +0200

    [GEOMETRY-57] - BigFraction Constructors are private
---
 .../geometry/euclidean/threed/enclosing/SphereGenerator.java | 12 ++++++------
 .../geometry/euclidean/twod/enclosing/DiskGenerator.java     |  4 ++--
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/commons-geometry-enclosing/src/main/java/org/apache/commons/geometry/euclidean/threed/enclosing/SphereGenerator.java b/commons-geometry-enclosing/src/main/java/org/apache/commons/geometry/euclidean/threed/enclosing/SphereGenerator.java
index bd6ac7e..87a7c87 100644
--- a/commons-geometry-enclosing/src/main/java/org/apache/commons/geometry/euclidean/threed/enclosing/SphereGenerator.java
+++ b/commons-geometry-enclosing/src/main/java/org/apache/commons/geometry/euclidean/threed/enclosing/SphereGenerator.java
@@ -94,16 +94,16 @@ public class SphereGenerator implements SupportBallGenerator<Vector3D> {
                         // Note that the minors m_11, m_12, m_13 and m_14 all have the last column
                         // filled with 1.0, hence simplifying the computation
                         final BigFraction[] c2 = new BigFraction[] {
-                            new BigFraction(vA.getX()), new BigFraction(vB.getX()),
-                            new BigFraction(vC.getX()), new BigFraction(vD.getX())
+                            BigFraction.from(vA.getX()), BigFraction.from(vB.getX()),
+                            BigFraction.from(vC.getX()), BigFraction.from(vD.getX())
                         };
                         final BigFraction[] c3 = new BigFraction[] {
-                            new BigFraction(vA.getY()), new BigFraction(vB.getY()),
-                            new BigFraction(vC.getY()), new BigFraction(vD.getY())
+                            BigFraction.from(vA.getY()), BigFraction.from(vB.getY()),
+                            BigFraction.from(vC.getY()), BigFraction.from(vD.getY())
                         };
                         final BigFraction[] c4 = new BigFraction[] {
-                            new BigFraction(vA.getZ()), new BigFraction(vB.getZ()),
-                            new BigFraction(vC.getZ()), new BigFraction(vD.getZ())
+                            BigFraction.from(vA.getZ()), BigFraction.from(vB.getZ()),
+                            BigFraction.from(vC.getZ()), BigFraction.from(vD.getZ())
                         };
                         final BigFraction[] c1 = new BigFraction[] {
                             c2[0].multiply(c2[0]).add(c3[0].multiply(c3[0])).add(c4[0].multiply(c4[0])),
diff --git a/commons-geometry-enclosing/src/main/java/org/apache/commons/geometry/euclidean/twod/enclosing/DiskGenerator.java b/commons-geometry-enclosing/src/main/java/org/apache/commons/geometry/euclidean/twod/enclosing/DiskGenerator.java
index 15a6382..5af9b99 100644
--- a/commons-geometry-enclosing/src/main/java/org/apache/commons/geometry/euclidean/twod/enclosing/DiskGenerator.java
+++ b/commons-geometry-enclosing/src/main/java/org/apache/commons/geometry/euclidean/twod/enclosing/DiskGenerator.java
@@ -67,10 +67,10 @@ public class DiskGenerator implements SupportBallGenerator<Vector2D> {
                     // Note that the minors m_11, m_12 and m_13 all have the last column
                     // filled with 1.0, hence simplifying the computation
                     final BigFraction[] c2 = new BigFraction[] {
-                        new BigFraction(vA.getX()), new BigFraction(vB.getX()), new BigFraction(vC.getX())
+                        BigFraction.from(vA.getX()), BigFraction.from(vB.getX()), BigFraction.from(vC.getX())
                     };
                     final BigFraction[] c3 = new BigFraction[] {
-                        new BigFraction(vA.getY()), new BigFraction(vB.getY()), new BigFraction(vC.getY())
+                            BigFraction.from(vA.getY()), BigFraction.from(vB.getY()), BigFraction.from(vC.getY())
                     };
                     final BigFraction[] c1 = new BigFraction[] {
                         c2[0].multiply(c2[0]).add(c3[0].multiply(c3[0])),