You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2018/06/05 22:22:35 UTC
Review Request 67463: Fixed type error when using `check_output` in
Python 3 scripts.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67463/
-----------------------------------------------------------
Review request for mesos and Andrew Schwartzmeyer.
Bugs: MESOS-8979
https://issues.apache.org/jira/browse/MESOS-8979
Repository: mesos
Description
-------
Fixed type error when using `check_output` in Python 3 scripts.
Diffs
-----
support/python3/generate-endpoint-help.py 711d3d325acbc1fe9e96d65caaf089727f03904f
support/python3/mesos-gtest-runner.py 153ded2994daad6ffb610866d499603af5a53b0a
support/python3/push-commits.py 82a700418341731833f165a24054f0879648ea92
Diff: https://reviews.apache.org/r/67463/diff/1/
Testing
-------
Removed part of the content of `push-commits.py` and run it using Python 3.
Thanks,
Armand Grillet
Re: Review Request 67463: Fixed type error when using `check_output`
in Python 3 scripts.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67463/#review204370
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67463]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 5, 2018, 10:22 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67463/
> -----------------------------------------------------------
>
> (Updated June 5, 2018, 10:22 p.m.)
>
>
> Review request for mesos and Andrew Schwartzmeyer.
>
>
> Bugs: MESOS-8979
> https://issues.apache.org/jira/browse/MESOS-8979
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed type error when using `check_output` in Python 3 scripts.
>
>
> Diffs
> -----
>
> support/python3/generate-endpoint-help.py 711d3d325acbc1fe9e96d65caaf089727f03904f
> support/python3/mesos-gtest-runner.py 153ded2994daad6ffb610866d499603af5a53b0a
> support/python3/push-commits.py 82a700418341731833f165a24054f0879648ea92
>
>
> Diff: https://reviews.apache.org/r/67463/diff/1/
>
>
> Testing
> -------
>
> Removed part of the content of `push-commits.py` and run it using Python 3.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 67463: Fixed type error when using `check_output`
in Python 3 scripts.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67463/#review204356
-----------------------------------------------------------
PASS: Mesos patch 67463 was successfully built and tested.
Reviews applied: `['67463']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67463
- Mesos Reviewbot Windows
On June 5, 2018, 3:22 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67463/
> -----------------------------------------------------------
>
> (Updated June 5, 2018, 3:22 p.m.)
>
>
> Review request for mesos and Andrew Schwartzmeyer.
>
>
> Bugs: MESOS-8979
> https://issues.apache.org/jira/browse/MESOS-8979
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed type error when using `check_output` in Python 3 scripts.
>
>
> Diffs
> -----
>
> support/python3/generate-endpoint-help.py 711d3d325acbc1fe9e96d65caaf089727f03904f
> support/python3/mesos-gtest-runner.py 153ded2994daad6ffb610866d499603af5a53b0a
> support/python3/push-commits.py 82a700418341731833f165a24054f0879648ea92
>
>
> Diff: https://reviews.apache.org/r/67463/diff/1/
>
>
> Testing
> -------
>
> Removed part of the content of `push-commits.py` and run it using Python 3.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 67463: Fixed type error when using `check_output`
in Python 3 scripts.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67463/#review204451
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Schwartzmeyer
On June 5, 2018, 3:22 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67463/
> -----------------------------------------------------------
>
> (Updated June 5, 2018, 3:22 p.m.)
>
>
> Review request for mesos and Andrew Schwartzmeyer.
>
>
> Bugs: MESOS-8979
> https://issues.apache.org/jira/browse/MESOS-8979
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed type error when using `check_output` in Python 3 scripts.
>
>
> Diffs
> -----
>
> support/python3/generate-endpoint-help.py 711d3d325acbc1fe9e96d65caaf089727f03904f
> support/python3/mesos-gtest-runner.py 153ded2994daad6ffb610866d499603af5a53b0a
> support/python3/push-commits.py 82a700418341731833f165a24054f0879648ea92
>
>
> Diff: https://reviews.apache.org/r/67463/diff/1/
>
>
> Testing
> -------
>
> Removed part of the content of `push-commits.py` and run it using Python 3.
>
>
> Thanks,
>
> Armand Grillet
>
>