You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2018/08/21 16:45:01 UTC
Review Request 68443: Fixed the example for image_gc_config.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68443/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, James Peach, Stéphane Cottin, and Zhitao Li.
Repository: mesos
Description
-------
Since the unit is nanoseconds, setting it to 3600 is way too small, and
misleading. This patch fixed the example to use 1 hour instead.
Diffs
-----
src/slave/flags.cpp fd208f64416ae865b81c8ba5950b20bde6be00a3
Diff: https://reviews.apache.org/r/68443/diff/1/
Testing
-------
trivial
Thanks,
Jie Yu
Re: Review Request 68443: Fixed the example for image_gc_config.
Posted by Jie Yu <yu...@gmail.com>.
> On Aug. 21, 2018, 4:54 p.m., James Peach wrote:
> > docs/configuration/agent.md
> > Line 1016 (original), 1016 (patched)
> > <https://reviews.apache.org/r/68443/diff/2/?file=2075695#file2075695line1016>
> >
> > How are people reading the docs expected to find `flags.proto`?
Yeah, we should follow up to clean this up.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68443/#review207671
-----------------------------------------------------------
On Aug. 21, 2018, 4:45 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68443/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 4:45 p.m.)
>
>
> Review request for mesos, Gilbert Song, James Peach, Stéphane Cottin, and Zhitao Li.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the unit is nanoseconds, setting it to 3600 is way too small, and
> misleading. This patch fixed the example to use 1 hour instead.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md bcddea2f8606f71fc46a39debca323d85c1d94c1
> src/slave/flags.cpp fd208f64416ae865b81c8ba5950b20bde6be00a3
>
>
> Diff: https://reviews.apache.org/r/68443/diff/2/
>
>
> Testing
> -------
>
> trivial
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 68443: Fixed the example for image_gc_config.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68443/#review207671
-----------------------------------------------------------
Fix it, then Ship it!
docs/configuration/agent.md
Line 1016 (original), 1016 (patched)
<https://reviews.apache.org/r/68443/#comment291158>
How are people reading the docs expected to find `flags.proto`?
docs/configuration/agent.md
Line 1023 (original), 1023 (patched)
<https://reviews.apache.org/r/68443/#comment291157>
Can you add some expository text here?
Maybe somee=thing like this
```
In this example, image garbage collection is configured to sample disk usage every hour, and will attempt to maintain at least 10% of free space on the container image filesystem:
```
- James Peach
On Aug. 21, 2018, 4:45 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68443/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 4:45 p.m.)
>
>
> Review request for mesos, Gilbert Song, James Peach, Stéphane Cottin, and Zhitao Li.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the unit is nanoseconds, setting it to 3600 is way too small, and
> misleading. This patch fixed the example to use 1 hour instead.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md bcddea2f8606f71fc46a39debca323d85c1d94c1
> src/slave/flags.cpp fd208f64416ae865b81c8ba5950b20bde6be00a3
>
>
> Diff: https://reviews.apache.org/r/68443/diff/2/
>
>
> Testing
> -------
>
> trivial
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 68443: Fixed the example for image_gc_config.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68443/#review207676
-----------------------------------------------------------
PASS: Mesos patch 68443 was successfully built and tested.
Reviews applied: `['68443']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2205/mesos-review-68443
- Mesos Reviewbot Windows
On Aug. 21, 2018, 4:45 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68443/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 4:45 p.m.)
>
>
> Review request for mesos, Gilbert Song, James Peach, Stéphane Cottin, and Zhitao Li.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the unit is nanoseconds, setting it to 3600 is way too small, and
> misleading. This patch fixed the example to use 1 hour instead.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md bcddea2f8606f71fc46a39debca323d85c1d94c1
> src/slave/flags.cpp fd208f64416ae865b81c8ba5950b20bde6be00a3
>
>
> Diff: https://reviews.apache.org/r/68443/diff/2/
>
>
> Testing
> -------
>
> trivial
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 68443: Fixed the example for image_gc_config.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68443/
-----------------------------------------------------------
(Updated Aug. 21, 2018, 4:45 p.m.)
Review request for mesos, Gilbert Song, James Peach, Stéphane Cottin, and Zhitao Li.
Repository: mesos
Description
-------
Since the unit is nanoseconds, setting it to 3600 is way too small, and
misleading. This patch fixed the example to use 1 hour instead.
Diffs (updated)
-----
docs/configuration/agent.md bcddea2f8606f71fc46a39debca323d85c1d94c1
src/slave/flags.cpp fd208f64416ae865b81c8ba5950b20bde6be00a3
Diff: https://reviews.apache.org/r/68443/diff/2/
Changes: https://reviews.apache.org/r/68443/diff/1-2/
Testing
-------
trivial
Thanks,
Jie Yu