[GitHub] [bigtop] evans-ye commented on a change in pull request #535: Bps dockerfile

[GitBox <gi...@apache.org>]

evans-ye commented on a change in pull request #535: Bps dockerfile
URL: https://github.com/apache/bigtop/pull/535#discussion_r289180337
 
 

 ##########
 File path: bigtop-bigpetstore/bigpetstore-transaction-queue/Dockerfile
 ##########
 @@ -13,21 +13,12 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 FROM centos:7
-MAINTAINER jay@apache.org
+LABEL maintainer="jay@apache.org"
 RUN yum update -y
-RUN yum install -y java-1.8.0-openjdk unzip wget
-RUN yum install -y java-1.8.0-openjdk-devel
+RUN yum install -y java-1.8.0-openjdk
 
 WORKDIR /opt/
 
-# Get Bigtop
-# This comes with a gradlew wrapper we can use.
-RUN wget http://www.apache.org/dist/bigtop/bigtop-1.0.0/bigtop-1.0.0-project.tar.gz
-RUN  tar -xvf bigtop-1.0.0-project.tar.gz
+COPY build/libs/bigpetstore-transaction-queue-all-1.0.jar /opt
 
 Review comment:
   Sorry I'm not familiar with BPS.
   So the idea here is to build bigpetstore-transaction-queue-all-1.0.jar locally and committed in the docker image?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services