You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@ip-10-146-233-104.ec2.internal> on 2016/01/05 23:14:03 UTC
[kudu-CR] Do not add thirdparty/bin to PATH in during builds
Dan Burkert has posted comments on this change.
Change subject: Do not add thirdparty/bin to PATH in during builds
......................................................................
Patch Set 2:
(1 comment)
I think what I'll do is go ahead and not add Python to the thirdparty/install directory (or move it to a subdirectory of that) so that this doesn't catch developers off guard. Regardless I think this is a good change to make. That python change will go into the C++11 patch.
http://gerrit.cloudera.org:8080/#/c/1678/2/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:
Line 239: ctest -j$NUM_PROCS $EXTRA_TEST_FLAGS || EXIT_STATUS=$?
> Does this have to be run out of THIRDPARTY_BIN too?
Done
--
To view, visit http://gerrit.cloudera.org:8080/1678
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fabe02686eca5e1ec3dbf901d95f36d0443dc41
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@danburkert.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@danburkert.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Todd Lipcon <to...@cloudera.com>
Gerrit-HasComments: Yes