[GitHub] [incubator-nuttx] juniskane commented on pull request #4566: drivers/syslog: Call up_puts in syslog_default_write instad up_putc

[GitBox <gi...@apache.org>]

juniskane commented on pull request #4566:
URL: https://github.com/apache/incubator-nuttx/pull/4566#issuecomment-923830708


   The commit ca62341c931a2ee2 is incorrect and should be reverted. Nothing guarantees that the buffer is NUL-terminated. Nothing guarantees there won't be multiple NUL-terminated C-strings in the buffer. That is the reason for the length parameter in the syslog API. With this change, I started getting garbage at beginning of syslog lines:
   
   ```
   �7r�z+�.Xٰ������R��2�L;%��H��S�lَ������(B2w's<�/�����[1632217938.702673] wirepas_stack_start: Wait for WP FW to start...
   TTPing after MQTTPublish (AWS GG workaround).
   �7r�z+�.Xٰ������R��2�L;%��H��S�lَ������(B2w's<�/�����[1632217938.762673] cycle: Received MQTT Ping response!
   ��[��[1632217938.762673] handle_event: SEND_DONE [RUNNING]
   �D�U���Q�F*�`��0�NQ�4�3�v�vg�֞j[1632217938.762673] handle_event: network connected : 200
   ING]
   �D�U���Q�F*�`��0�NQ�4�3�v�vg�֞j[1632217938.762673] handle_event: PING [RUNNING]
   �D�U���Q�F*�`��0�NQ�4�3�v�vg�֞j[1632217938.982673] Platform_LOG: [msap] I: Status is 0x01
   �D�U���Q�F*�`��0�NQ�4�3�v�vg�֞j[1632217939.732673] Platform_LOG: [msap] I: Stop request result = 0x00
   K�D�U���Q�F*�`��0�NQ�4�3�v�vg�֞j[1632217940.242673] Platform_LOG: [SLIP] W: Timeout to receive frame (size=0)
   ��Q�F*�`��0�NQ�4�3�v�vg�֞j[1632217940.242673] Platform_LOG: [wpc_int] E: Didn't receive answer to the request 0x0c
   �0�NQ�4�3�v�vg�֞j[1632217940.282673] Platform_LOG: [msap] I: Status is 0x01
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org