You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/07 13:35:57 UTC

[GitHub] [superset] adam-stasiak opened a new issue #12328: add Annotation layers dropdowns do not respond for click

adam-stasiak opened a new issue #12328:
URL: https://github.com/apache/superset/issues/12328


   I cannot modify dropdown options for annotation layers (chart explore view)
   ### Expected results
   
   Dropdowns can be open.
   ### Actual results
   
   Dropdowns do not react on click.
   
   #### Screenshots
   
   
   https://user-images.githubusercontent.com/25153919/103898333-108fc800-50f5-11eb-92d5-2697cb2fd092.mov
   
   
   #### How to reproduce the bug
   
   1. Launch application with: CYPRESS_CONFIG=true docker-compose up
   2. Go to chart ```Rise & Fall of Video Game Consoles```
   3. Click on Add annotation layer
   4. See error
   
   ### Environment
   
   (please complete the following information):
   
   commit master f48284909dde84d13276bb40ddd91ec6935f10e5
   
   ### Checklist
   
   Make sure to follow these steps before submitting your issue - thank you!
   
   - [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [ x] I have reproduced the issue with at least the latest released version of superset.
   - [ x] I have checked the issue tracker for the same issue and I haven't found one similar.
   
   ### Additional context
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido edited a comment on issue #12328: [Explore]add Annotation layers dropdowns do not respond for click

Posted by GitBox <gi...@apache.org>.
geido edited a comment on issue #12328:
URL: https://github.com/apache/superset/issues/12328#issuecomment-756898594


   Fixed by #12330
   
   ![Num-Births-Trend](https://user-images.githubusercontent.com/60598000/104046448-655c3d00-51e0-11eb-9dff-8068d2d41150.gif)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #12328: [Explore]add Annotation layers dropdowns do not respond for click

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12328:
URL: https://github.com/apache/superset/issues/12328#issuecomment-756148790


   @adam-stasiak Thanks for reporting 
   @agatapst let's fix this one, I don't think it's a regression from your last PR, but you now have the most context. 
   
   thanks both! 🙏


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #12328: [Explore]add Annotation layers dropdowns do not respond for click

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12328:
URL: https://github.com/apache/superset/issues/12328#issuecomment-757330833


   original issue is resolved thanks @geido and @adam-stasiak !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc closed issue #12328: [Explore]add Annotation layers dropdowns do not respond for click

Posted by GitBox <gi...@apache.org>.
junlincc closed issue #12328:
URL: https://github.com/apache/superset/issues/12328


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido commented on issue #12328: [Explore]add Annotation layers dropdowns do not respond for click

Posted by GitBox <gi...@apache.org>.
geido commented on issue #12328:
URL: https://github.com/apache/superset/issues/12328#issuecomment-756899467


   There might be another issue though. It seems the Popover is closed on every change without giving the user the ability to apply the changes @junlincc 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido commented on issue #12328: [Explore]add Annotation layers dropdowns do not respond for click

Posted by GitBox <gi...@apache.org>.
geido commented on issue #12328:
URL: https://github.com/apache/superset/issues/12328#issuecomment-756898594






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido commented on issue #12328: [Explore]add Annotation layers dropdowns do not respond for click

Posted by GitBox <gi...@apache.org>.
geido commented on issue #12328:
URL: https://github.com/apache/superset/issues/12328#issuecomment-756898594


   Fixed by #12330 @junlincc 
   
   ![Num-Births-Trend](https://user-images.githubusercontent.com/60598000/104046448-655c3d00-51e0-11eb-9dff-8068d2d41150.gif)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido edited a comment on issue #12328: [Explore]add Annotation layers dropdowns do not respond for click

Posted by GitBox <gi...@apache.org>.
geido edited a comment on issue #12328:
URL: https://github.com/apache/superset/issues/12328#issuecomment-756898594


   Fixed by #12330
   
   ![Num-Births-Trend](https://user-images.githubusercontent.com/60598000/104046448-655c3d00-51e0-11eb-9dff-8068d2d41150.gif)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #12328: [Explore]add Annotation layers dropdowns do not respond for click

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12328:
URL: https://github.com/apache/superset/issues/12328#issuecomment-756911674






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #12328: [Explore]add Annotation layers dropdowns do not respond for click

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12328:
URL: https://github.com/apache/superset/issues/12328#issuecomment-756911674


   > There might be another issue though. It seems the Popover is closed on every change without giving the user the ability to apply the changes @junlincc
   
   right, that's also happening in the LONGITUDE & LATITUDE popover in deck.gl chart 😭


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc closed issue #12328: [Explore]add Annotation layers dropdowns do not respond for click

Posted by GitBox <gi...@apache.org>.
junlincc closed issue #12328:
URL: https://github.com/apache/superset/issues/12328


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org