You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/09/02 21:33:05 UTC
Re: Review Request 37284: Maintenance Primitives: Added support for
Accept / Decline of InverseOffers in master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37284/
-----------------------------------------------------------
(Updated Sept. 2, 2015, 7:33 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019
Diff: https://reviews.apache.org/r/37284/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37284: Maintenance Primitives: Added support for
Accept / Decline of InverseOffers in master.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37284/#review98803
-----------------------------------------------------------
Ship it!
src/master/master.cpp (line 3283)
<https://reviews.apache.org/r/37284/#comment155398>
Don't need the extra newline here.
- Benjamin Hindman
On Sept. 13, 2015, 8:34 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37284/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2015, 8:34 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574
>
> Diff: https://reviews.apache.org/r/37284/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37284: Maintenance Primitives: Added support for
Accept / Decline of InverseOffers in master.
Posted by Jian Qiu <qi...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37284/#review98795
-----------------------------------------------------------
Ship it!
Ship It!
- Jian Qiu
On 九月 13, 2015, 8:34 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37284/
> -----------------------------------------------------------
>
> (Updated 九月 13, 2015, 8:34 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574
>
> Diff: https://reviews.apache.org/r/37284/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37284: Maintenance Primitives: Added support for
Accept / Decline of InverseOffers in master.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37284/
-----------------------------------------------------------
(Updated Sept. 14, 2015, 1:03 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Changes
-------
Removed extra new-line.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574
Diff: https://reviews.apache.org/r/37284/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37284: Maintenance Primitives: Added support for
Accept / Decline of InverseOffers in master.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37284/
-----------------------------------------------------------
(Updated Sept. 13, 2015, 8:34 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574
Diff: https://reviews.apache.org/r/37284/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37284: Maintenance Primitives: Added support for
Accept / Decline of InverseOffers in master.
Posted by Yong Qiao Wang <yq...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37284/#review98142
-----------------------------------------------------------
Ship it!
Ship It!
- Yong Qiao Wang
On Sept. 2, 2015, 7:33 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37284/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 7:33 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019
>
> Diff: https://reviews.apache.org/r/37284/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37284: Maintenance Primitives: Added support for
Accept / Decline of InverseOffers in master.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37284/#review98531
-----------------------------------------------------------
Ship it!
Still a Ship it, just another comment.
src/master/master.cpp (lines 2757 - 2758)
<https://reviews.apache.org/r/37284/#comment155051>
Can we make these comments more verbose please?
- Benjamin Hindman
On Sept. 2, 2015, 7:33 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37284/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 7:33 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019
>
> Diff: https://reviews.apache.org/r/37284/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37284: Maintenance Primitives: Added support for
Accept / Decline of InverseOffers in master.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37284/#review97553
-----------------------------------------------------------
Ship it!
src/master/master.cpp (line 3243)
<https://reviews.apache.org/r/37284/#comment153547>
Missing a space here.
- Joseph Wu
On Sept. 2, 2015, 12:33 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37284/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 12:33 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019
>
> Diff: https://reviews.apache.org/r/37284/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>