You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "waynexia (via GitHub)" <gi...@apache.org> on 2023/07/18 03:28:03 UTC
[GitHub] [arrow-datafusion] waynexia opened a new pull request, #7007: refactor: Merge Expr::Like and Expr::ILike
waynexia opened a new pull request, #7007:
URL: https://github.com/apache/arrow-datafusion/pull/7007
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #6841.
# Rationale for this change
Both `Expr::Like` and `Expr::ILike` are based on the same struct `Like` (actually `Expr::Similar` is also based on it). We can add one marker `case_insensitive` in struct `Like` to distinguish them. This can simplify related logic on handling `LIKE` and `ILIKE`.
# What changes are included in this PR?
Merge `Expr::Like` and `Expr::ILike` variants
# Are these changes tested?
By existing tests
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
Yes, this is a breaking change as `Expr` doesn't have `Expr::ILike` now.
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #7007: refactor: Merge Expr::Like and Expr::ILike
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #7007:
URL: https://github.com/apache/arrow-datafusion/pull/7007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #7007: refactor: Merge Expr::Like and Expr::ILike
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #7007:
URL: https://github.com/apache/arrow-datafusion/pull/7007#issuecomment-1641847242
Thank you @waynexia -- I agree with @jackwener that this is a really nice cleanup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org