You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "PurelyApplied (GitHub)" <gi...@apache.org> on 2018/10/25 20:29:45 UTC
[GitHub] [geode] PurelyApplied opened pull request #2720: GEODE-5803:
Remove dependencies resulting from bad merge.
Co-authored-by: Robert Houghton <rh...@pivotal.io>
Co-authored-by: Patrick Rhomberg <pr...@pivotal.io>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/2720 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on issue #2720: GEODE-5803:
Remove dependencies resulting from bad merge.
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
For what it's worth, this mistake would be readily apparent in the file's history if we didn't rebase as part of a PR's merge action. The history is preserved in #2613 for the time being, where we can see that the collapsing of multiple dependency blocks erroneously reintroduced the very dependencies GEODE-5803 was meant to remove. The surrounding changes, however, were preserved and the removal of these lines appears to be stable.
[ Full content available at: https://github.com/apache/geode/pull/2720 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied closed pull request #2720: GEODE-5803:
Remove dependencies resulting from bad merge.
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
[ pull request closed by PurelyApplied ]
[ Full content available at: https://github.com/apache/geode/pull/2720 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org