[GitHub] [iceberg] dramaticlly commented on a diff in pull request #7551: Core: Check for all specs in partitionsTable

["dramaticlly (via GitHub)" <gi...@apache.org>]

dramaticlly commented on code in PR #7551:
URL: https://github.com/apache/iceberg/pull/7551#discussion_r1191661451


##########
core/src/test/java/org/apache/iceberg/TestMetadataTableScansWithPartitionEvolution.java:
##########
@@ -222,6 +222,14 @@ public void testPositionDeletesPartitionSpecRemoval() {
         constantsMap(posDeleteTask, partitionType).get(MetadataColumns.FILE_PATH.fieldId()));
   }
 
+  @Test
+  public void testPartitionSpecEvolutionToUnpartitioned() {

Review Comment:
   feels like test name is not super clear, maybe `testPreviouslyPartitionedSpecStillShowPartitionColumnWhenEvolveToUnpartitioned` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org