You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@fluo.apache.org by GitBox <gi...@apache.org> on 2018/02/05 16:37:27 UTC

[GitHub] mikewalch commented on a change in pull request #1013: Making changes in the file according to issue 1011

mikewalch commented on a change in pull request #1013: Making changes in the file according to issue 1011
URL: https://github.com/apache/fluo/pull/1013#discussion_r166029888
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/fluo/core/async/SyncCommitObserver.java
 ##########
 @@ -28,27 +30,32 @@
   private volatile boolean aacked = false;
   private volatile Exception error = null;
   private volatile String commitFailMsg = "";
+  private AtomicBoolean anyMethodCalled= new AtomicBoolean(false);
 
 Review comment:
   This line doesn't conform to our coding standards.  However, don't worry about fixing it by hand. Fluo has a Maven plugin that formats our code. It runs when you run `mvn verify`.  Can you run this, commit any changes it makes to this file, and push this commit to your branch?  It will update this pull request.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services